Page MenuHomePhabricator
Feed Advanced Search

Mar 20 2023

atul committed rCOMM4935b4875f60: [lib] Fix `TUnion`/`TInterface` imports (authored by atul).
[lib] Fix `TUnion`/`TInterface` imports
Mar 20 2023, 4:52 PM
atul closed D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types.
Mar 20 2023, 3:48 PM
atul committed rCOMMbcb8e9e4126e: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo`… (authored by atul).
[lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo`…
Mar 20 2023, 3:48 PM
atul updated the diff for D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types.

rebase and land

Mar 20 2023, 3:45 PM
atul closed D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding.
Mar 20 2023, 3:26 PM
atul committed rCOMMe927714acf3f: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding (authored by atul).
[keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding
Mar 20 2023, 3:26 PM
atul updated the diff for D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding.

rebase and land

Mar 20 2023, 3:23 PM
atul closed D7107: [lib] Introduce `updateUserAvatarRequestValidator`.
Mar 20 2023, 3:19 PM
atul committed rCOMM4c6ac988e277: [lib] Introduce `updateUserAvatarRequestValidator` (authored by atul).
[lib] Introduce `updateUserAvatarRequestValidator`
Mar 20 2023, 3:19 PM
atul updated the diff for D7107: [lib] Introduce `updateUserAvatarRequestValidator`.

rebase and land

Mar 20 2023, 3:17 PM
atul accepted D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Mar 20 2023, 3:10 PM
atul resigned from D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Mar 20 2023, 2:50 PM
atul added a comment to D7060: [lib] Introduce superblock padding.

{F436096}

Putting it in scripts/ sounds like a good idea to me!

Mar 20 2023, 2:48 PM
atul requested changes to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

One last change

Mar 20 2023, 2:46 PM
atul added inline comments to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Mar 20 2023, 2:33 PM
atul added 1 blocking reviewer(s) for D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types: ginsu.
Mar 20 2023, 2:29 PM
atul published D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types for review.
Mar 20 2023, 2:29 PM
atul accepted D7105: Build files set-up for Android 13.
Mar 20 2023, 1:29 PM
atul updated the diff for D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding.

fix typo

Mar 20 2023, 1:28 PM
atul published D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding for review.
Mar 20 2023, 1:08 PM
atul published D7107: [lib] Introduce `updateUserAvatarRequestValidator` for review.
Mar 20 2023, 12:42 PM
atul closed D7098: [keyserver] Add `avatar` column to `threads` table of serverDB.
Mar 20 2023, 7:37 AM
atul committed rCOMMc49378d39f63: [keyserver] Add `avatar` column to `threads` table of serverDB (authored by atul).
[keyserver] Add `avatar` column to `threads` table of serverDB
Mar 20 2023, 7:37 AM
atul updated the diff for D7098: [keyserver] Add `avatar` column to `threads` table of serverDB.

rebase and land

Mar 20 2023, 7:33 AM
atul closed D7097: [lib] Introduce `*AvatarDBContent` types.
Mar 20 2023, 7:32 AM
atul committed rCOMM4fbb34a3f4cd: [lib] Introduce `*AvatarDBContent` types (authored by atul).
[lib] Introduce `*AvatarDBContent` types
Mar 20 2023, 7:32 AM
atul updated the diff for D7097: [lib] Introduce `*AvatarDBContent` types.

address feedback (and sneak in ENSAvatarDBContent)

Mar 20 2023, 7:21 AM
atul added inline comments to D7097: [lib] Introduce `*AvatarDBContent` types.
Mar 20 2023, 7:18 AM
atul accepted D7061: [lib] Introduce combined padding interface.
Mar 20 2023, 7:07 AM

Mar 17 2023

atul accepted D7060: [lib] Introduce superblock padding.

The Notion doc was super helpful for understanding what's going on. Thanks for taking the time to write that all out.

Mar 17 2023, 2:11 PM
atul added inline comments to D7059: [lib] Introduce PKCS#7 padding.
Mar 17 2023, 1:08 PM
atul accepted D7059: [lib] Introduce PKCS#7 padding.

Thanks for including unit tests!

Mar 17 2023, 1:01 PM
atul published D7098: [keyserver] Add `avatar` column to `threads` table of serverDB for review.
Mar 17 2023, 12:51 PM
atul accepted D7091: [native] Fork Olm.
Mar 17 2023, 12:49 PM
atul accepted D7089: [web][keyserver] Fork Olm.
Mar 17 2023, 12:48 PM
atul added inline comments to D7097: [lib] Introduce `*AvatarDBContent` types.
Mar 17 2023, 12:20 PM
atul published D7097: [lib] Introduce `*AvatarDBContent` types for review.
Mar 17 2023, 12:19 PM

Mar 16 2023

atul committed rCOMMa642904cfbf4: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
Mar 16 2023, 2:17 PM
atul committed rCOMM231f12c54514: [native] `codeVersion` -> 202 (authored by atul).
[native] `codeVersion` -> 202
Mar 16 2023, 2:17 PM
atul committed rCOMMcd03dee294ec: [native] Temporary changes for staff release (authored by atul).
[native] Temporary changes for staff release
Mar 16 2023, 2:17 PM
atul committed rCOMMdd2f634cda2d: [native] `codeVersion` -> 201 (authored by atul).
[native] `codeVersion` -> 201
Mar 16 2023, 2:17 PM
atul accepted D7086: [lib] Add message type to "content must be defined" errors.
Mar 16 2023, 2:00 PM
atul accepted D7085: [native] Add a C++ MessageSpec for SidebarSource.
Mar 16 2023, 2:00 PM
atul added a reviewer for D7061: [lib] Introduce combined padding interface: tomek.

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

Mar 16 2023, 1:37 PM
atul added a reviewer for D7060: [lib] Introduce superblock padding: tomek.

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

Mar 16 2023, 1:37 PM
atul added a comment to D7059: [lib] Introduce PKCS#7 padding.

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

Mar 16 2023, 1:36 PM
atul added a reviewer for D7059: [lib] Introduce PKCS#7 padding: tomek.
Mar 16 2023, 1:36 PM
atul accepted D7080: [lib] Don't mention GENESIS in chat creation notifs.
Mar 16 2023, 12:56 PM
atul accepted D7079: [lib] Don't refer to children of GENESIS as channels.
Mar 16 2023, 12:56 PM
atul accepted D7084: [native] Remove length check when unpickling.
Mar 16 2023, 12:55 PM
atul published D7084: [native] Remove length check when unpickling for review.
Mar 16 2023, 12:55 PM
atul accepted D7078: [lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity.
Mar 16 2023, 8:23 AM
atul accepted D7071: [keyserver] Fix update-geoip call in Docker environment.
Mar 16 2023, 8:22 AM
atul committed rCOMMccb5daf8d543: Bump activesupport from 6.1.7.1 to 6.1.7.3 in /native (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump activesupport from 6.1.7.1 to 6.1.7.3 in /native
Mar 16 2023, 8:14 AM

Mar 15 2023

atul closed D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 4:35 PM
atul committed rCOMM734df39d7857: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response (authored by atul).
[keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response
Mar 15 2023, 4:35 PM
atul added inline comments to D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 4:32 PM
atul updated the diff for D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.

rebase before landing

Mar 15 2023, 4:32 PM
atul added inline comments to D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 4:24 PM
atul closed D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.
Mar 15 2023, 4:20 PM
atul committed rCOMM6bfaf0746b8f: [web] Add `CryptoStore` to `persistConfig.whitelist` (authored by atul).
[web] Add `CryptoStore` to `persistConfig.whitelist`
Mar 15 2023, 4:20 PM
atul updated the diff for D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.

rebase and land

Mar 15 2023, 4:12 PM
atul closed D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.
Mar 15 2023, 3:48 PM
atul committed rCOMM61f34545c837: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();` (authored by atul).
[web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`
Mar 15 2023, 3:48 PM
atul updated the diff for D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.

extract useSignedIdentityKeysBlob hook to cut repetition

Mar 15 2023, 3:34 PM
atul updated the test plan for D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 1:45 PM
atul published D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response for review.

This is the last diff in the stack that I planned on putting up Monday/Tuesday, but ran into issues with D7081. Going to do some additional testing before landing to be extra careful.

Mar 15 2023, 1:43 PM
atul updated the diff for D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.

rebase

Mar 15 2023, 1:16 PM
atul updated the summary of D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.
Mar 15 2023, 1:13 PM
atul updated the summary of D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.
Mar 15 2023, 1:12 PM
atul updated the test plan for D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.
Mar 15 2023, 1:12 PM
atul published D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();` for review.
Mar 15 2023, 1:10 PM
atul committed rCOMM7bbc37d4486f: Bump sqlite3 from 5.1.2 to 5.1.5 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump sqlite3 from 5.1.2 to 5.1.5
Mar 15 2023, 11:10 AM
atul committed rCOMMd5870e96ded1: Bump openssl-src in /services/tunnelbroker (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump openssl-src in /services/tunnelbroker
Mar 15 2023, 11:08 AM
atul committed rCOMMead0fc5d467d: Bump webpack from 5.75.0 to 5.76.0 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump webpack from 5.75.0 to 5.76.0
Mar 15 2023, 11:07 AM
atul committed rCOMMaf9e74003217: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
Mar 15 2023, 11:04 AM
atul added a reverting change for rCOMM52f4a8f5d972: [native] Temporary changes for staff release: rCOMMaf9e74003217: Revert "[native] Temporary changes for staff release".
Mar 15 2023, 11:04 AM
atul committed rCOMMeaa353868c78: [native] `codeVersion` -> 200 (authored by atul).
[native] `codeVersion` -> 200
Mar 15 2023, 11:04 AM
atul committed rCOMM52f4a8f5d972: [native] Temporary changes for staff release (authored by atul).
[native] Temporary changes for staff release
Mar 15 2023, 11:04 AM
atul committed rCOMM62a4d758338d: [native] `codeVersion` -> 199 (authored by atul).
[native] `codeVersion` -> 199
Mar 15 2023, 11:04 AM

Mar 14 2023

atul requested review of D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.
Mar 14 2023, 2:43 PM
atul accepted D7068: [keyserver][web] Use unique filename for each prod olm.wasm asset.

Would be good to quickly make sure login/SIWE on web continue to work as expected

Mar 14 2023, 2:09 PM
atul requested changes to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

(back to your queue pending changes)

Mar 14 2023, 1:47 PM
atul committed rCOMM5c7c93c99de3: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
Mar 14 2023, 1:45 PM
atul added a reverting change for rCOMM4f5dda9f0298: [native] Temporary changes for staff release: rCOMM5c7c93c99de3: Revert "[native] Temporary changes for staff release".
Mar 14 2023, 1:45 PM
atul committed rCOMMe380a24f6307: [native] `codeVersion` -> 198 (authored by atul).
[native] `codeVersion` -> 198
Mar 14 2023, 1:45 PM
atul committed rCOMM4f5dda9f0298: [native] Temporary changes for staff release (authored by atul).
[native] Temporary changes for staff release
Mar 14 2023, 1:45 PM
atul committed rCOMMc77de3d9207b: [native] `codeVersion` -> 197 (authored by atul).
[native] `codeVersion` -> 197
Mar 14 2023, 1:45 PM
atul closed D7052: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is "none".
Mar 14 2023, 1:08 PM
atul committed rCOMMf0195ddd8301: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is… (authored by atul).
[direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is…
Mar 14 2023, 1:08 PM
atul updated the diff for D7052: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is "none".

address feedback

Mar 14 2023, 12:58 PM
atul closed D7051: [keyserver] Send `SIGNED_IDENTITY_KEYS_BLOB` request to client if data missing in DB.
Mar 14 2023, 12:51 PM
atul committed rCOMM157e772a80ac: [keyserver] Send `SIGNED_IDENTITY_KEYS_BLOB` request to client if data missing… (authored by atul).
[keyserver] Send `SIGNED_IDENTITY_KEYS_BLOB` request to client if data missing…
Mar 14 2023, 12:51 PM
atul added inline comments to D7052: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is "none".
Mar 14 2023, 12:48 PM
atul updated the diff for D7051: [keyserver] Send `SIGNED_IDENTITY_KEYS_BLOB` request to client if data missing in DB.

move promise earlier

Mar 14 2023, 12:47 PM
atul updated the diff for D7051: [keyserver] Send `SIGNED_IDENTITY_KEYS_BLOB` request to client if data missing in DB.

remove viewer.cookieID check

Mar 14 2023, 12:45 PM
atul attached a referenced file: F427377: b0cf0a-1.png.
Mar 14 2023, 12:44 PM
atul added inline comments to D7051: [keyserver] Send `SIGNED_IDENTITY_KEYS_BLOB` request to client if data missing in DB.
Mar 14 2023, 12:44 PM
atul added a comment to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

Ehhh I'd really prefer if we stayed away from these syntax tricks. I think spreading and destructuring can already get a little tricky on occasion (eg nested restructuring, reassigning names, etc) and I can see this just further confusing things.. especially for new devs

Mar 14 2023, 12:27 PM
atul closed D7050: [keyserver] Introduce `isCookieMissingSignedIdentityKeysBlob`.
Mar 14 2023, 12:24 PM