Rebase
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Feb 26 2023
Feb 26 2023
rohan updated the diff for D6467: [native] Render the media gallery in the thread settings on native.
Rebase
Rebase
Rebase
rebase before landing
ginsu updated the diff for D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise.
rebase before landing
ginsu updated the diff for D6307: [lib] modify reaction message generatesNotifs function to return a pushType based on the reaction action.
rebase before landing
ginsu updated the diff for D6875: [lib/native/web] switch reactions data structure from map to plain object.
rebase before landing
ashoat accepted D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
Awesome!! I thought you had earlier indicated that a parentheses was necessary, but either way it sounds like now you’re in agreement with that StackOverflow post about the ORDER BY / LIMIT.
rohan updated the summary of D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
rohan added a comment to D6865: [web] Allow media gallery items to click through to a full screen view on web.
In D6865#204399, @ashoat wrote:Why are we using Modal though? Should we just update MultimediaModal to look like those designs?
rohan added a comment to D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
In D6485#204702, @ashoat wrote:On the ORDER BY / LIMIT question from earlier, I think you had mentioned over chat that you would have to wrap the SELECT / UNION SELECT and apply them to the whole thing. Is that still your belief? I noticed this StackOverflow implies the opposite, but I haven't done any testing to confirm.
rohan updated the diff for D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
Make sure lines are < 80 characters
rohan updated the test plan for D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
ashoat requested changes to D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.
Nice! After this verification step, we should then JSON.parse(signedIdentityKeysBlob.payload) and run the result through an input validator. Then we'll be ready to store them in the DB. (Assume that's for a later diff, though.)
PS looks like a missing screenshot in the Test Plan.
Nice!!
ashoat removed 1 blocking reviewer(s) for D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise: atul.
I spent some time reading through this and I understand how it works now. @ginsu wanted to catch the ref just as it was set, so he made a useEffect that would trigger immediately after renderEmojiKeyboard flips, which as it turns out will trigger the rendering of the emoji keyboard. He got this idea from the article he linked earlier.
Moving forward, if I run into situations where I am submitting code that is not an obviously clear solution, I will be sure to annote with comments with my rationale-- something that I can work on. This should require me think more critically of my solutions, learn better, and offer more context for my reviewer.
ashoat added inline comments to D6884: [web] "Unpickle" primary OLM account to sign keys and get `SignedIdentityKeysBlob`.
It looks like you're adding support for sending push notifs, but support is still missing for rescinds and for updateBadgeCount. Rescinds may be hard but updateBadgeCount should be easy.
Perfect! Love the small extra improvements you made
ashoat requested changes to D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
Permission checks query seems good. Can you amend the Test Plan to mention how you tested them?
Feb 25 2023
Feb 25 2023
Looks fine to me.
Seems like from ashoat's feedback the nonce is similar to a unique token, in which case I think this is alright.
rohan updated the diff for D6531: [keyserver/lib] Set up the endpoints and responder for retrieving media.
Pass in viewer parameter
rohan updated the diff for D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
Check visible permission
Looks good to me, but letting @jon take a look
atul requested review of D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.
atul published D6895: [keyserver] Add `signedIdentityKeysBlobValidator` to `logInRequestInputValidator` for review.
ginsu retitled D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise from [keyserver] convert existing logic for building userPushInfoPromises to an IIFE called generateNotifUserInfoPromise
ginsu updated the diff for D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise.
address ashoat's comments
ginsu updated the test plan for D6875: [lib/native/web] switch reactions data structure from map to plain object.
ginsu updated the diff for D6875: [lib/native/web] switch reactions data structure from map to plain object.
address ashoat's comments
Feb 24 2023
Feb 24 2023
Good catch @inka!!
Accepting to unblock, but would be great if we could avoid Object for new code. Not sure how easy it is to avoid here and whether the type there is predictable from whatever API we are getting it from
ashoat removed 1 blocking reviewer(s) for D6485: [keyserver] Create a function to query for all uploads from a provided threadID: atul.
ashoat accepted D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
Please only land if you can confirm that the ORDER BY and LIMIT apply to the whole query, not just the second half
It might be for backwards compatibility, or maybe just for convenience of accessing. The idea of getConstants() is that it's called once by the module at initialization, so actually I think calling it directly might also have some nuanced differences if there is some stateful code there
merge conflict
newline
rohan updated the diff for D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
thumbnailUploadType and thumbnailUploadExtra are not used so I'm removing them from the query