Page MenuHomePhorge
Feed All Stories

Feb 27 2023

bartek requested changes to D6854: [services] Extract common database code to a separate lib.
  • CI is failing because blob and backup (and feature_flag) Dockerfiles need rust_lib to be copied.
  • Identity service also uses these functions.
Feb 27 2023, 1:23 PM
tomek updated the diff for D6861: [services][feature-flags] Introduce `features` endpoint.

Rebase. Use to_owned instead of clone

Feb 27 2023, 1:19 PM
bartek accepted D6858: [services][feature-flags] Determine enabled features set.
Feb 27 2023, 1:05 PM
bartek accepted D6855: [services][feature-flags] Introduce map and i32 parsing.
Feb 27 2023, 1:02 PM
Harbormaster failed remote builds in B16940: Diff 23152 for D6860: [services][feature-flags] Add hello world http server!
Feb 27 2023, 1:00 PM
tomek added inline comments to D6861: [services][feature-flags] Introduce `features` endpoint.
Feb 27 2023, 12:59 PM
tomek updated the test plan for D6860: [services][feature-flags] Add hello world http server.
Feb 27 2023, 12:56 PM
tomek updated the diff for D6860: [services][feature-flags] Add hello world http server.

Bind IPv6 address

Feb 27 2023, 12:56 PM
kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Undo rebase

Feb 27 2023, 12:49 PM
tomek added inline comments to D6860: [services][feature-flags] Add hello world http server.
Feb 27 2023, 12:45 PM
Harbormaster failed remote builds in B16938: Diff 23150 for D6858: [services][feature-flags] Determine enabled features set!
Feb 27 2023, 12:40 PM
tomek updated the diff for D6858: [services][feature-flags] Determine enabled features set.

Rebase and simplify code version check

Feb 27 2023, 12:35 PM
kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Rebase

Feb 27 2023, 12:33 PM
kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Rebase

Feb 27 2023, 12:32 PM
kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Rebase

Feb 27 2023, 12:32 PM
kuba updated the diff for D5462: [keyserver] Update userStore from chat creation url.

Rebase

Feb 27 2023, 12:32 PM
kuba planned changes to D5463: [web] Call searchUsers in chat composer.
Feb 27 2023, 12:29 PM
kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Fixed according to Michal notes

Feb 27 2023, 12:28 PM
max closed D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.
Feb 27 2023, 12:23 PM
max committed rCOMM35260f3a78a9: [keyserver] Unifying API interface and adding Tunnelbroker types.
Feb 27 2023, 12:23 PM
tomek added a comment to D6858: [services][feature-flags] Determine enabled features set.

I've created a task where we can discuss the caching https://linear.app/comm/issue/ENG-3082/consider-using-cache-in-feature-flags-service. I think it is really not worth it in near future, as it greatly increases the complexity and doesn't introduce measurable value.

Feb 27 2023, 12:21 PM
max closed D6843: [services] Tunnelbroker - Fix calling blocking C++ function from an async task.
Feb 27 2023, 12:21 PM
max committed rCOMM70ebd47b4563: [services] Tunnelbroker - Fix calling blocking C++ function from an async task.
Feb 27 2023, 12:21 PM
max published D6898: [keyserver] Tunnelbroker integration - Adding message object on message consuming for review.
Feb 27 2023, 12:15 PM
varun accepted D6843: [services] Tunnelbroker - Fix calling blocking C++ function from an async task.
Feb 27 2023, 12:13 PM
Harbormaster failed remote builds in B16931: Diff 23141 for D6857: [services][feature-flags] Query the db!
Feb 27 2023, 12:07 PM
tomek updated the test plan for D6854: [services] Extract common database code to a separate lib.
Feb 27 2023, 12:06 PM
tomek updated the diff for D6857: [services][feature-flags] Query the db.

Rebase and introduce platform constants

Feb 27 2023, 12:02 PM
Harbormaster failed remote builds in B16930: Diff 23140 for D6856: [services][feature-flags] Parse feature flags response from DynamoDB!
Feb 27 2023, 11:59 AM
tomek added inline comments to D6857: [services][feature-flags] Query the db.
Feb 27 2023, 11:57 AM
tomek updated the diff for D6856: [services][feature-flags] Parse feature flags response from DynamoDB.

Rebase

Feb 27 2023, 11:54 AM
tomek added inline comments to D6856: [services][feature-flags] Parse feature flags response from DynamoDB.
Feb 27 2023, 11:52 AM
Harbormaster failed remote builds in B16929: Diff 23139 for D6855: [services][feature-flags] Introduce map and i32 parsing!
Feb 27 2023, 11:44 AM
tomek updated the diff for D6855: [services][feature-flags] Introduce map and i32 parsing.

Reabase and make error handling more consistent with other places.

Feb 27 2023, 11:38 AM
tomek added inline comments to D6855: [services][feature-flags] Introduce map and i32 parsing.
Feb 27 2023, 11:37 AM
michal added inline comments to D5463: [web] Call searchUsers in chat composer.
Feb 27 2023, 11:33 AM
Harbormaster failed remote builds in B16928: Diff 23138 for D6854: [services] Extract common database code to a separate lib!
Feb 27 2023, 11:27 AM
tomek requested review of D6854: [services] Extract common database code to a separate lib.
Feb 27 2023, 11:25 AM
tomek retitled D6854: [services] Extract common database code to a separate lib from [services][feature-flags] Copy DynamoDB utils from other services
Feb 27 2023, 11:23 AM
tomek updated the diff for D6854: [services] Extract common database code to a separate lib.

Extarct common code into a lib

Feb 27 2023, 11:22 AM
marcin accepted D6712: [native] support operations failure in error handling.
Feb 27 2023, 11:05 AM
max updated the diff for D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.

Rebasing on master and parent changes.

Feb 27 2023, 11:05 AM
max added a comment to D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.

Fix Flow types and remove .default

Feb 27 2023, 11:00 AM
bartek accepted D6821: Implement method to sign message.
Feb 27 2023, 10:35 AM
marcin closed D6823: Make types exact.
Feb 27 2023, 10:35 AM
marcin committed rCOMM0f81d4aa56d4: Make types exact.
Feb 27 2023, 10:34 AM
marcin updated the diff for D6821: Implement method to sign message.

Log error from olmUtility structure when signature verification fails.

Feb 27 2023, 10:33 AM
marcin added inline comments to D6781: Initialize notifications olm account in CommCoreModule and expose notifications public keys to JS.
Feb 27 2023, 10:23 AM
kamil added inline comments to D6712: [native] support operations failure in error handling.
Feb 27 2023, 10:19 AM
marcin updated the diff for D6823: Make types exact.

Rebase before landing

Feb 27 2023, 10:16 AM
kamil updated the diff for D6713: [native] handle database operations errors in reducer.

reabase

Feb 27 2023, 10:15 AM
kamil updated the diff for D6712: [native] support operations failure in error handling.

improve code readability

Feb 27 2023, 10:14 AM
tomek added a comment to D6854: [services] Extract common database code to a separate lib.

This seems like it would've been a great time to introduce a shared library instead of copy-pasting. I understand there is a monthly goal at play here, but how long does it really take to set up a shared library? In JavaScript it can be done in ~15min, but I'm not as familiar with Rust

Feb 27 2023, 9:59 AM
tomek added inline comments to D6853: [services][feature-flags] Describe feature flags table in terraform.
Feb 27 2023, 9:53 AM
tomek accepted D6815: [keyserver/ web] Handle device_token on web.
Feb 27 2023, 9:03 AM
max closed D6771: [keyserver] Adding metadata to the Tunnelbroker client constructor.
Feb 27 2023, 8:30 AM
max committed rCOMM31a3e54aa020: [keyserver] Adding metadata to the Tunnelbroker client constructor.
Feb 27 2023, 8:30 AM
max updated the diff for D6771: [keyserver] Adding metadata to the Tunnelbroker client constructor.

Fixing commit and rebasing on master.

Feb 27 2023, 8:09 AM
inka planned changes to D6845: [web] Style navigation state info in the top bar.

The idea to have the overflow: scroll was not accepted by the design team, so I'll have to update that once we decide what to do instead.

Feb 27 2023, 8:07 AM
max requested review of D6843: [services] Tunnelbroker - Fix calling blocking C++ function from an async task.
Feb 27 2023, 7:18 AM
max added inline comments to D6843: [services] Tunnelbroker - Fix calling blocking C++ function from an async task.
Feb 27 2023, 7:17 AM
bartek added inline comments to D6861: [services][feature-flags] Introduce `features` endpoint.
Feb 27 2023, 6:55 AM
bartek added a comment to D6858: [services][feature-flags] Determine enabled features set.

In the future, we may want to think about doing some memoization of feature flags; as they probably won't change significantly between calls (staff may change, but I don't have the context why staff are handled special here).

Feb 27 2023, 6:51 AM
rohan attached a referenced file: F402973: Screen Recording 2023-02-26 at 9.44.39 PM.mov.
Feb 27 2023, 2:46 AM
rohan updated the test plan for D6865: [web] Allow media gallery items to click through to a full screen view on web.
Feb 27 2023, 2:46 AM
atul closed D6896: [web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`.
Feb 27 2023, 2:03 AM
atul committed rCOMM0e56a7857d8c: [web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`.
Feb 27 2023, 2:03 AM
atul updated the diff for D6896: [web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`.

rebase + land

Feb 27 2023, 2:02 AM
atul added a comment to D6896: [web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`.

PS looks like a missing screenshot in the Test Plan.

Feb 27 2023, 1:54 AM
atul closed D6895: [keyserver] Add `signedIdentityKeysBlobValidator` to `logInRequestInputValidator`.
Feb 27 2023, 1:45 AM
atul committed rCOMM27c3ce790fd9: [keyserver] Add `signedIdentityKeysBlobValidator` to….
Feb 27 2023, 1:45 AM
atul updated the diff for D6895: [keyserver] Add `signedIdentityKeysBlobValidator` to `logInRequestInputValidator`.

rebase + land

Feb 27 2023, 1:38 AM
atul updated the test plan for D6896: [web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`.
Feb 27 2023, 1:18 AM
jon added inline comments to D6861: [services][feature-flags] Introduce `features` endpoint.
Feb 27 2023, 12:28 AM
jon added a comment to D6858: [services][feature-flags] Determine enabled features set.

agree with bartek, something name <object>_is_<condition>, should probably return a boolean, or be renamed to more accurately describe what is going on.

Feb 27 2023, 12:24 AM
rohan updated the diff for D6865: [web] Allow media gallery items to click through to a full screen view on web.

Revert Modal changes

Feb 27 2023, 12:20 AM
rohan added 1 blocking reviewer(s) for D6865: [web] Allow media gallery items to click through to a full screen view on web: atul.
Feb 27 2023, 12:16 AM
rohan updated the diff for D6865: [web] Allow media gallery items to click through to a full screen view on web.

Use MultimediaModal and allow video support for the modal

Feb 27 2023, 12:16 AM

Feb 26 2023

ginsu closed D6830: [keyserver] introduce sendRescindNotifs.
Feb 26 2023, 9:06 PM
ginsu closed D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise.
Feb 26 2023, 9:06 PM
ginsu committed rCOMM9518dca6bbf6: [keyserver] introduce sendRescindNotifs.
Feb 26 2023, 9:06 PM
ginsu committed rCOMM00510eaa214f: [keyserver] convert existing logic for building userPushInfoPromises to an….
Feb 26 2023, 9:06 PM
ginsu closed D6307: [lib] modify reaction message generatesNotifs function to return a pushType based on the reaction action.
Feb 26 2023, 9:06 PM
ginsu committed rCOMM1f10bbfc7149: [lib] modify reaction message generatesNotifs function to return a pushType….
Feb 26 2023, 9:06 PM
ginsu closed D6875: [lib/native/web] switch reactions data structure from map to plain object.
Feb 26 2023, 9:00 PM
ginsu committed rCOMMbe977b7db9fb: [lib/native/web] switch reactions data structure from map to plain object.
Feb 26 2023, 9:00 PM
rohan closed D6720: [native] Create the full screen media gallery component.
Feb 26 2023, 7:52 PM
rohan committed rCOMM188e6df1ad83: [native] Create the full screen media gallery component.
Feb 26 2023, 7:52 PM
rohan closed D6718: [native] Navigate to the image / video modal when a user clicks on a media item.
Feb 26 2023, 7:51 PM
rohan committed rCOMM6f6e14289405: [native] Navigate to the image / video modal when a user clicks on a media item.
Feb 26 2023, 7:51 PM
rohan closed D6660: [native] Allow user to ‘see more’ on native and navigate to a full screen gallery.
Feb 26 2023, 7:51 PM
rohan committed rCOMMa36d44a21dbe: [native] Allow user to ‘see more’ on native and navigate to a full screen….
Feb 26 2023, 7:51 PM
rohan closed D6659: [native] Display both photos and videos in the media gallery on native.
Feb 26 2023, 7:49 PM
rohan committed rCOMMea3f91b287d3: [native] Display both photos and videos in the media gallery on native.
Feb 26 2023, 7:49 PM
rohan closed D6587: [keyserver] Use the internal-ip package in the dev environment to ensure physical device / emulators can access uploads.
Feb 26 2023, 7:49 PM
rohan committed rCOMMc5e3e7ca5bc8: [keyserver] Use the internal-ip package in the dev environment to ensure….
Feb 26 2023, 7:49 PM
rohan closed D6531: [keyserver/lib] Set up the endpoints and responder for retrieving media.
Feb 26 2023, 7:48 PM
rohan committed rCOMMb813c7baa64b: [keyserver/lib] Set up the endpoints and responder for retrieving media.
Feb 26 2023, 7:48 PM
rohan closed D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
Feb 26 2023, 7:47 PM
rohan committed rCOMM9d78e018f716: [keyserver] Create a function to query for all uploads from a provided threadID.
Feb 26 2023, 7:47 PM