- CI is failing because blob and backup (and feature_flag) Dockerfiles need rust_lib to be copied.
- Identity service also uses these functions.
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
All Stories
Feb 27 2023
Rebase. Use to_owned instead of clone
Bind IPv6 address
Undo rebase
Rebase and simplify code version check
Rebase
Rebase
Rebase
Rebase
Fixed according to Michal notes
I've created a task where we can discuss the caching https://linear.app/comm/issue/ENG-3082/consider-using-cache-in-feature-flags-service. I think it is really not worth it in near future, as it greatly increases the complexity and doesn't introduce measurable value.
Rebase and introduce platform constants
Rebase
Reabase and make error handling more consistent with other places.
Extarct common code into a lib
Rebasing on master and parent changes.
In D6690#203834, @ashoat wrote:Fix Flow types and remove .default
Log error from olmUtility structure when signature verification fails.
reabase
improve code readability
In D6854#204407, @ashoat wrote:This seems like it would've been a great time to introduce a shared library instead of copy-pasting. I understand there is a monthly goal at play here, but how long does it really take to set up a shared library? In JavaScript it can be done in ~15min, but I'm not as familiar with Rust
Fixing commit and rebasing on master.
The idea to have the overflow: scroll was not accepted by the design team, so I'll have to update that once we decide what to do instead.
In the future, we may want to think about doing some memoization of feature flags; as they probably won't change significantly between calls (staff may change, but I don't have the context why staff are handled special here).
rebase + land
PS looks like a missing screenshot in the Test Plan.
rebase + land
agree with bartek, something name <object>_is_<condition>, should probably return a boolean, or be renamed to more accurately describe what is going on.
Revert Modal changes
Use MultimediaModal and allow video support for the modal