rebase + land

rebase + land

rebase + land

rebase + land

annotate

Thought the approach here was cleaner: https://phab.comm.dev/D6901

In D6897#205161, @ashoat wrote:

this can be landed without issue

Did you test calling await olm.init() multiple times?

this can be landed without issue

In D6897#205149, @atul wrote:

We could probably just have a function getOlmUtility that returns a Promise that does lines 345 and 346 here, and caches the result.

I'll need to make sure there that await olm.init(); is "idempotent" and there aren't any issues with calling it multiple times. Just want to make sure in the case where the keyserver gets multiple siwe_auth requests at the same time that calling await olm.init() simultaneously/multiple times doesn't break anything.

The reason this diff is titled [DRAFT] is because of the way we're calling olm.init() and new olm.Utility() every time logInResponder encounters a request with signedIdentityKeysBlob. Instead we'll want to probably run olm.init() once when keyserver starts up, and we'll want to instantiate olm.Utility() once and make it accessible globally.

We could probably just have a function getOlmUtility that returns a Promise that does lines 345 and 346 here, and caches the result.

Address review

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Update cargo dependency

Just two inlines

Please make the requested edit before landing. Otherwise Flow types look good, but defer to others on Rust

Rename lib, update Dockerfiles and list services script

[...] which probably can be fixed by bumping old versions of libs, but I don't think it is a good idea to further increase the scope of this diff.

• Identity service also uses these functions.

Haven't figured out how to send a request from host, but verifying that is the next step.

Not sure what you exactly mean, but docker-compose exposes the service port to host, so you should be able to simply

yarn run-feature-flags-service-in-sandbox
# in a separate terminal
curl "http://localhost:50055/features?platform=..." # etc

Make code more readable and make platfor case-insensitive