Page MenuHomePhabricator
Feed All Stories

Fri, Nov 8

angelika requested review of D13897: [sqlite] Add getInboundP2PMessagesByID query.
Fri, Nov 8, 8:14 AM
bartek closed D13747: [native] Improve device labels on device list screen.
Fri, Nov 8, 6:25 AM
bartek committed rCOMM085f43d75697: [native] Improve device labels on device list screen (authored by bartek).
[native] Improve device labels on device list screen
Fri, Nov 8, 6:25 AM
bartek closed D13262: [native] only display remove device button if current device is primary device.
Fri, Nov 8, 6:25 AM
bartek closed D13125: [native] add ability to remove devices from linked devices bottom sheet.
Fri, Nov 8, 6:25 AM
bartek committed rCOMM89cbd85b1c2a: [native] only display remove device button if current device is primary device (authored by varun).
[native] only display remove device button if current device is primary device
Fri, Nov 8, 6:25 AM
bartek committed rCOMMa4517c9d13ba: [native] add ability to remove devices from linked devices bottom sheet (authored by varun).
[native] add ability to remove devices from linked devices bottom sheet
Fri, Nov 8, 6:25 AM
ashoat added a comment to D13888: [lib] Stop shimming Blob-hosted multimedia messages.

Sorry, you're absolutely right... that was my mistake, I mixed up FUTURE_CODE_VERSION and NEXT_CODE_VERSION

Fri, Nov 8, 6:24 AM
bartek accepted D13896: Upgrade to Rust 1.81.
Fri, Nov 8, 6:21 AM
bartek added a comment to D13888: [lib] Stop shimming Blob-hosted multimedia messages.

Hmmmm this doesn't look right... the file on the left doesn't seem to be master

Fri, Nov 8, 6:20 AM
ashoat added a comment to D13892: [native][web] Clean up dead conditions for media encryption.

There's now an increasingly long list of "dangling" functions/types that can be removed:

Fri, Nov 8, 5:34 AM
ashoat accepted D13262: [native] only display remove device button if current device is primary device.
Fri, Nov 8, 5:30 AM
bartek updated the diff for D13892: [native][web] Clean up dead conditions for media encryption.

Rebase, add invariants for encrypted uploads, remove more dead code: legacy calls

Fri, Nov 8, 5:29 AM
ashoat accepted D13125: [native] add ability to remove devices from linked devices bottom sheet.
Fri, Nov 8, 5:27 AM
ashoat added a comment to D13888: [lib] Stop shimming Blob-hosted multimedia messages.

Hmmmm this doesn't look right... the file on the left doesn't seem to be master

Fri, Nov 8, 5:26 AM
bartek updated the diff for D13888: [lib] Stop shimming Blob-hosted multimedia messages.

Use version 389 as minimal

Fri, Nov 8, 5:23 AM
bartek updated the diff for D13262: [native] only display remove device button if current device is primary device.
  • Made primary device non-clickable
  • Added pencil icons to editable items
  • Refactored isThisDevice
  • Made type readonly
Fri, Nov 8, 5:20 AM
bartek updated the diff for D13125: [native] add ability to remove devices from linked devices bottom sheet.

Remove padding

Fri, Nov 8, 5:19 AM
bartek attached a referenced file: F3180751: Simulator Screenshot - iPhone 15 Pro - 2024-11-08 at 14.13.50.png.
Fri, Nov 8, 5:16 AM
bartek added a comment to D13262: [native] only display remove device button if current device is primary device.

Neat ideas, I came up with something like this (the first item is not clickable):

Simulator Screenshot - iPhone 15 Pro - 2024-11-08 at 14.13.50.png (2×1 px, 140 KB)

Fri, Nov 8, 5:16 AM
ashoat added a comment to D13889: [native][web] Add migration to unshim Blob-hosted multimedia.

Thanks for explaining and sharing the details & logs!

Fri, Nov 8, 4:59 AM
ashoat added inline comments to D13888: [lib] Stop shimming Blob-hosted multimedia messages.
Fri, Nov 8, 4:56 AM
tomek accepted D13889: [native][web] Add migration to unshim Blob-hosted multimedia.
Fri, Nov 8, 4:42 AM
tomek closed D13845: [lib] Delete remove members spec.
Fri, Nov 8, 4:29 AM
tomek closed D13858: [lib] Validate IDs in DM operations.
Fri, Nov 8, 4:29 AM
tomek closed D13848: [lib] Propagate thread infos to the notifs generating code.
Fri, Nov 8, 4:29 AM
tomek committed rCOMM8eec4d2895c3: [lib] Propagate thread infos to the notifs generating code (authored by tomek).
[lib] Propagate thread infos to the notifs generating code
Fri, Nov 8, 4:29 AM
tomek committed rCOMM58824ef48b2e: [lib] Delete remove members spec (authored by tomek).
[lib] Delete remove members spec
Fri, Nov 8, 4:29 AM
tomek committed rCOMMd8ed20cf4b9c: [lib] Validate IDs in DM operations (authored by tomek).
[lib] Validate IDs in DM operations
Fri, Nov 8, 4:29 AM
tomek closed D13842: [lib] Tighten utils type to contain only thick threads.
Fri, Nov 8, 4:29 AM
tomek closed D13843: [lib] Merge generating notifs data with processing operations.
Fri, Nov 8, 4:29 AM
tomek committed rCOMM580b6451cbab: [lib] Tighten utils type to contain only thick threads (authored by tomek).
[lib] Tighten utils type to contain only thick threads
Fri, Nov 8, 4:29 AM
tomek committed rCOMM50bce357c2ac: [lib] Merge generating notifs data with processing operations (authored by tomek).
[lib] Merge generating notifs data with processing operations
Fri, Nov 8, 4:29 AM
tomek closed D13698: [lib] Use the actions queue in the peer to peer context.
Fri, Nov 8, 4:29 AM
tomek committed rCOMMf9423b4ea946: [lib] Use the actions queue in the peer to peer context (authored by tomek).
[lib] Use the actions queue in the peer to peer context
Fri, Nov 8, 4:29 AM
bartek added a comment to D13889: [native][web] Add migration to unshim Blob-hosted multimedia.

I talked with @tomek, and we concluded that I had previously done the test plan wrong, and the migration didn't actually run. In short, I was logging in with state version 85 from the beginning.

Fri, Nov 8, 4:09 AM
tomek updated the diff for D13858: [lib] Validate IDs in DM operations.

Rename

Fri, Nov 8, 3:16 AM
tomek updated the diff for D13848: [lib] Propagate thread infos to the notifs generating code.

Rebase and rename

Fri, Nov 8, 3:08 AM
tomek updated the diff for D13843: [lib] Merge generating notifs data with processing operations.

Make notificationsCreationData optional

Fri, Nov 8, 2:54 AM
bartek added inline comments to D13888: [lib] Stop shimming Blob-hosted multimedia messages.
Fri, Nov 8, 1:42 AM
bartek added inline comments to D13888: [lib] Stop shimming Blob-hosted multimedia messages.
Fri, Nov 8, 1:09 AM

Thu, Nov 7

ashoat added a reviewer for D13889: [native][web] Add migration to unshim Blob-hosted multimedia: tomek.

I did not do any testing. @barthap will need to test this before landing, thoroughly this time.

Thu, Nov 7, 8:33 PM
ashoat updated the diff for D13889: [native][web] Add migration to unshim Blob-hosted multimedia.
  1. Split out legacyUnshimClientDB for existing usages
  2. Introduce new unshimClientDB
  3. Do the same for web
Thu, Nov 7, 8:31 PM
ashoat added inline comments to D13889: [native][web] Add migration to unshim Blob-hosted multimedia.
Thu, Nov 7, 8:26 PM
ashoat committed rCOMM00a76250d774: [terraform] Bump keyserver image to 1.0.142 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.142
Thu, Nov 7, 7:38 PM
ashoat added a reverting change for rCOMM4f50a8857c46: [native] Temporary changes for staff release: rCOMM5b2bb7e63014: Revert "[native] Temporary changes for staff release".
Thu, Nov 7, 7:37 PM
ashoat committed rCOMM26a58db77d92: [native] codeVersion -> 440 (authored by ashoat).
[native] codeVersion -> 440
Thu, Nov 7, 7:37 PM
ashoat committed rCOMM5b2bb7e63014: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Thu, Nov 7, 7:37 PM
ashoat committed rCOMM4f50a8857c46: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Thu, Nov 7, 7:37 PM
ashoat committed rCOMM21ebc7583aea: [native] codeVersion -> 439 (authored by ashoat).
[native] codeVersion -> 439
Thu, Nov 7, 7:37 PM
ashoat committed rCOMMcf1cec5beb1c: [web][keyserver] codeVersion -> 142 (authored by ashoat).
[web][keyserver] codeVersion -> 142
Thu, Nov 7, 7:37 PM
ashoat added inline comments to D13888: [lib] Stop shimming Blob-hosted multimedia messages.
Thu, Nov 7, 7:22 PM
ashoat reopened D13888: [lib] Stop shimming Blob-hosted multimedia messages.

First, give this comment a read.

Thu, Nov 7, 7:22 PM
ashoat reopened D13889: [native][web] Add migration to unshim Blob-hosted multimedia.
Thu, Nov 7, 7:20 PM
ashoat added a comment to D13891: [native][web] Flip the switch for blob-hosted media/avatar uploads.

Reverted this diff because blob-hosted multimedia in thin threads will get shimmed by the keyserver to recent mobile clients.

Thu, Nov 7, 7:19 PM
ashoat reopened D13891: [native][web] Flip the switch for blob-hosted media/avatar uploads.
Thu, Nov 7, 7:13 PM
ashoat added a reverting change for rCOMM0b058dcfae34: [lib] Stop shimming Blob-hosted multimedia messages: rCOMMf73497ae9535: Revert "[lib] Stop shimming Blob-hosted multimedia messages".
Thu, Nov 7, 7:13 PM
ashoat committed rCOMMf73497ae9535: Revert "[lib] Stop shimming Blob-hosted multimedia messages" (authored by ashoat).
Revert "[lib] Stop shimming Blob-hosted multimedia messages"
Thu, Nov 7, 7:13 PM
ashoat added a reverting change for D13888: [lib] Stop shimming Blob-hosted multimedia messages: rCOMMf73497ae9535: Revert "[lib] Stop shimming Blob-hosted multimedia messages".
Thu, Nov 7, 7:13 PM
ashoat added a reverting change for rCOMM30f6d90c525a: [native][web] Add migration to unshim Blob-hosted multimedia: rCOMM40822b3c7079: Revert "[native][web] Add migration to unshim Blob-hosted multimedia".
Thu, Nov 7, 7:13 PM
ashoat added a reverting change for D13889: [native][web] Add migration to unshim Blob-hosted multimedia: rCOMM40822b3c7079: Revert "[native][web] Add migration to unshim Blob-hosted multimedia".
Thu, Nov 7, 7:13 PM
ashoat committed rCOMM40822b3c7079: Revert "[native][web] Add migration to unshim Blob-hosted multimedia" (authored by ashoat).
Revert "[native][web] Add migration to unshim Blob-hosted multimedia"
Thu, Nov 7, 7:13 PM
ashoat added a reverting change for rCOMMb1a48f05876f: [native][web] Flip the switch for blob-hosted media/avatar uploads: rCOMMeea1df0f6502: Revert "[native][web] Flip the switch for blob-hosted media/avatar uploads".
Thu, Nov 7, 7:13 PM
ashoat added a reverting change for D13891: [native][web] Flip the switch for blob-hosted media/avatar uploads: rCOMMeea1df0f6502: Revert "[native][web] Flip the switch for blob-hosted media/avatar uploads".
Thu, Nov 7, 7:13 PM
ashoat committed rCOMMeea1df0f6502: Revert "[native][web] Flip the switch for blob-hosted media/avatar uploads" (authored by ashoat).
Revert "[native][web] Flip the switch for blob-hosted media/avatar uploads"
Thu, Nov 7, 7:13 PM
ashoat committed rCOMM3c9cffd71120: Revert "[keyserver] Update NEXT_CODE_VERSION" (authored by ashoat).
Revert "[keyserver] Update NEXT_CODE_VERSION"
Thu, Nov 7, 7:13 PM
ashoat added a reverting change for rCOMM119b4f44a029: [keyserver] Update NEXT_CODE_VERSION: rCOMM3c9cffd71120: Revert "[keyserver] Update NEXT_CODE_VERSION".
Thu, Nov 7, 7:13 PM
ashoat added inline comments to D13892: [native][web] Clean up dead conditions for media encryption.
Thu, Nov 7, 7:09 PM
varun updated the diff for D13896: Upgrade to Rust 1.81.

minimal Cargo.lock update

Thu, Nov 7, 5:29 PM
will accepted D13896: Upgrade to Rust 1.81.
Thu, Nov 7, 4:18 PM
varun requested review of D13896: Upgrade to Rust 1.81.
Thu, Nov 7, 4:13 PM
varun updated the diff for D13895: [shared] bump opaque-ke to 2.1.0-pre.1.

add argon2 to root Cargo.toml

Thu, Nov 7, 1:56 PM
varun updated the summary of D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Thu, Nov 7, 1:41 PM
varun updated the summary of D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Thu, Nov 7, 1:40 PM
varun removed a reviewer for D13895: [shared] bump opaque-ke to 2.1.0-pre.1: ashoat.

realize there's Rust code so @ashoat isn't a good reviewer

Thu, Nov 7, 1:39 PM
varun updated the test plan for D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Thu, Nov 7, 1:37 PM
varun requested review of D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Thu, Nov 7, 1:36 PM
varun accepted D13894: [CommCoreModule] make sure `backupID` is URL-safe string.
Thu, Nov 7, 11:38 AM
ashoat committed rCOMM01fbbc84278c: [terraform] Bump keyserver image to 1.0.141 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.141
Thu, Nov 7, 10:17 AM
ashoat committed rCOMM5ccd884b92b2: [native] codeVersion -> 438 (authored by ashoat).
[native] codeVersion -> 438
Thu, Nov 7, 9:08 AM
ashoat committed rCOMM0de97fe7e475: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Thu, Nov 7, 9:08 AM
ashoat added a reverting change for rCOMM2ba1b1443455: [native] Temporary changes for staff release: rCOMM0de97fe7e475: Revert "[native] Temporary changes for staff release".
Thu, Nov 7, 9:08 AM
ashoat committed rCOMM2ba1b1443455: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Thu, Nov 7, 9:08 AM
ashoat committed rCOMM5ffbb9c9aca1: [native] codeVersion -> 437 (authored by ashoat).
[native] codeVersion -> 437
Thu, Nov 7, 9:08 AM
ashoat committed rCOMM510c72b2a5b0: [web][keyserver] codeVersion -> 141 (authored by ashoat).
[web][keyserver] codeVersion -> 141
Thu, Nov 7, 9:08 AM
ashoat committed rCOMM119b4f44a029: [keyserver] Update NEXT_CODE_VERSION (authored by ashoat).
[keyserver] Update NEXT_CODE_VERSION
Thu, Nov 7, 9:08 AM
bartek closed D13891: [native][web] Flip the switch for blob-hosted media/avatar uploads.
Thu, Nov 7, 8:25 AM
bartek committed rCOMMb1a48f05876f: [native][web] Flip the switch for blob-hosted media/avatar uploads (authored by bartek).
[native][web] Flip the switch for blob-hosted media/avatar uploads
Thu, Nov 7, 8:25 AM
bartek closed D13890: [native][web] Stop limiting media encryption to staff community.
Thu, Nov 7, 8:25 AM
bartek closed D13889: [native][web] Add migration to unshim Blob-hosted multimedia.
Thu, Nov 7, 8:25 AM
bartek committed rCOMMdc9c299698c2: [native][web] Stop limiting media encryption to staff community (authored by bartek).
[native][web] Stop limiting media encryption to staff community
Thu, Nov 7, 8:25 AM
bartek committed rCOMM30f6d90c525a: [native][web] Add migration to unshim Blob-hosted multimedia (authored by bartek).
[native][web] Add migration to unshim Blob-hosted multimedia
Thu, Nov 7, 8:25 AM
bartek closed D13888: [lib] Stop shimming Blob-hosted multimedia messages.
Thu, Nov 7, 8:25 AM
bartek committed rCOMM0b058dcfae34: [lib] Stop shimming Blob-hosted multimedia messages (authored by bartek).
[lib] Stop shimming Blob-hosted multimedia messages
Thu, Nov 7, 8:25 AM
kamil published D13894: [CommCoreModule] make sure `backupID` is URL-safe string for review.
Thu, Nov 7, 8:13 AM
bartek added inline comments to D13892: [native][web] Clean up dead conditions for media encryption.
Thu, Nov 7, 7:23 AM
tomek added inline comments to D13858: [lib] Validate IDs in DM operations.
Thu, Nov 7, 7:07 AM
tomek added inline comments to D13843: [lib] Merge generating notifs data with processing operations.
Thu, Nov 7, 7:05 AM
Harbormaster failed remote builds in B32576: Diff 45689 for D13886: [lib] Fix useThreadsWithPermission check!
Thu, Nov 7, 6:28 AM
ashoat closed D13886: [lib] Fix useThreadsWithPermission check.
Thu, Nov 7, 6:22 AM