- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Thu, Nov 7
Add code comment
It seems like we can delete commStaffCommunity and threadInfoInsideCommunity from the codebase as well. What do you think?
I compiled some notes that we can go through in our next 1:1. Ahead of that, I figured it might help to share a list of React render cycles issues solved by adding React.useMemos like this:
Ok, it makes sense, though it's a bit weird to me. This useMemo affects how another hook is calculated.
I probably should have explained this differently. What I meant is that we're currently forcing the useMemo in useThreadsWithPermission to be recalculated on every call from useThreadHasPermission. This diff fixes that.
Ok, it makes sense, though it's a bit weird to me. This useMemo affects how another hook is calculated. Maybe a comment would be useful?
remove extra line
rebase before landing
address review
In D13849#387643, @bartek wrote:Alternatively, we can download only backupID and read backupDataKey and backupLogDataKey (it should exist on primary always) to avoid downloading User Keys - but curious about @bartek's perspective as I don't fully remember why it was implemented that way,
I don't remember either. Your changes make sense though
address nit