update migrations

ensure the connect farcaster prompt appears on second cold start

fix migration logic

I want to review the icon before landing, but this generally looks good

Can you share a screenshot of what a mouseover looks like in this case? Wondering if the timestamp still appears, and where it appears

Same feedback as in D14544

The white background feels like too strong of a contrast... I feel like a deleted message should be less visible than a non-deleted message. Could we try something closer to what Rahul had in his designs?

Thanks for explaining! I can confirm the fix works for me :)

For web I agree the style of the icon should be more similar (outline vs fill).

Ok, I'll search for something else

For web I agree the style of the icon should be more similar (outline vs fill). For native, does the action sheet only pop up if there are too many actions, and the user clicks more to see the extra actions?

Consider that a deleted message can be a sidebar source

I was asking about why the aspect ratio in the video I put in the bug report is still correct.

As I answered before the values in the report come from expo's image picker. Details:

• correctly rotated video has width 1080, height 1920
• selection.dimensions comes from ImagePicker, which takes into account exif data
• the first step in the bug report is the following:

{
        "dimensions": {
          "height": 1920,
          "width": 1080
        },
        "duration": 2.2316666666666665,
        "filename": "IMG_9232.MOV",
        "mediaNativeID": "8483761D-54E0-4A64-9D3B-AD0BDD99DEBE/L0/001",
        "retries": 0,
        "selectTime": 1743430376010,
        "sendTime": 1743430376010,
        "step": "video_library",
        "uri": "assets-library://asset/asset.mov?id=8483761D-54E0-4A64-9D3B-AD0BDD99DEBE&ext=mov"
      },

and is created here: https://github.com/CommE2E/comm/blob/master/native/media/media-gallery-keyboard.react.js#L386 so the dimensions are from image picker so they're correct

• now as for displayed video, the dimensions come from getVideoInfo (I won't dig exactly how) and it reports width 1920, height 1080 (incorrectly)
• the phone you're holding has portrait orientation
• so, what I think happens now is that we create video player, scale it down with styles so it displays "horizontal" video on a screen with portrait orientation that fits the screen with correct aspect ratio but the video player figures out that the video is rotated so it's still displayed in correct orientation, just scaled down with our styles

Do we need to do anything for it to be included in the Android build, eg. update some CMakeLists.txt file?

I was asking about why the aspect ratio in the video I put in the bug report is still correct.

Fix flow

It's interesting that the height/width values were rotated, as the dimensions of the video still appear correct in my bug report... just the video appears smaller. Can you explain why the dimensions of the video in the bug report still look correct?

There are two places we get the dimensions of the video from. One is getVideoInfo(), the second one is the result of ImagePicker: https://github.com/CommE2E/comm/blob/master/native/media/media-utils.js#L93 I guess in the report there were values from ImagePicker.

Remove uri from fetchFileInfo

In D14510#402801, @ashoat wrote:

Can you retitle all of the diffs in this stack to explicitly reference message deletion? Just realized that they're just generically titled.

Use FUTURE_CODE_VERSION

address review

In D14517#403050, @bartek wrote:

Don't we want this method to take a vector of tables to copy? Looking at D14519, I see you're running this in a loop, so the ATTACH DATABASE ..., DETACH statements are repeated for each table