update prop types for thread settings avatar
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 22 2023
Mar 22 2023
ginsu updated the summary of D7137: [native] render thread avatars for parent/child threads in thread settings.
ginsu updated the diff for D7135: [native] render thread avatar in CHANNEL AVATAR thread settings section.
ginsu updated the summary of D7135: [native] render thread avatar in CHANNEL AVATAR thread settings section.
removed some unnecssary checks
double checked android rendering
Mar 21 2023
Mar 21 2023
Discovered bug with the avatar generating new random avatar when creating a new chat or sub channel will update this when resolved
ginsu requested review of D7137: [native] render thread avatars for parent/child threads in thread settings.
ginsu requested review of D7135: [native] render thread avatar in CHANNEL AVATAR thread settings section.
atul committed rCOMM56fdc906a28d: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
[native] `codeVersion` -> 204
[native] Temporary changes for staff release
[native] `codeVersion` -> 203
Expand comment on Sender / Receiver RPCs
Use Sender / Receiver as X3DH roles
rohan added a comment to D6924: [keyserver] Introduce columns in messages table to support pinned messages.
In D6924#211499, @tomek wrote:How the pinning will be saved on client's side? Do we plan to have it included in a message info? If that's the case, do we plan to update all the message infos saved on all the clients?
• kuba requested review of D7127: [lib][keyserver] Introduce new threadPermissions types for editing messages.
Addressed @ginsu feedback from the web version of diff
The same comments as in: https://phab.comm.dev/D7017?id=23714#inline-46406
Addressed @ginsu comments
bartek committed rCOMMa37f8d4289a4: [lib] Introduce combined padding interface (authored by bartek).
[lib] Introduce combined padding interface
[lib] Introduce superblock padding
[lib] Introduce PKCS#7 padding
In D7017#210367, @ginsu wrote:Also, I personally feel like the label for edited messages should be below the reactions/threads and not to the left/right of it. Could you link or send a screenshot of what the figma has?
bartek requested changes to D7106: Native Java code to request notifications permissions from JS on Android 13.
Besides nits, some considerations about promise handling.
not very well versed in gradle, but please add me to cmake related stuff in the future :)
How the pinning will be saved on client's side? Do we plan to have it included in a message info? If that's the case, do we plan to update all the message infos saved on all the clients?
Rebase, fix exports
Rebase, fix exports
Rebase, fix exports
ginsu committed rCOMM30bbf4162d48: [native] add feature flag to avatars render work (authored by ginsu).
[native] add feature flag to avatars render work
ginsu committed rCOMM7dd079eabea8: [native] render the rest of the user avatars (authored by ginsu).
[native] render the rest of the user avatars
[native] render avatar in profile screen
address tomeks comments
rebase after merge
rohan updated the diff for D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
Call parseMessageSQLResult instead of rawMessageInfoFromRows
Bump buildToolsVersion
[native] introduce Avatar component
ginsu committed rCOMMdeb559ef04b0: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo (authored by ginsu).
[keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo
ginsu committed rCOMMb5df71ba24a0: [lib] introduce getAvatarForUser in avatar-utils (authored by ginsu).
[lib] introduce getAvatarForUser in avatar-utils
rebase after merge
use new avatar types introduced by @atul
ginsu updated the diff for D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
rebase after merge
use new avatar types introduced by @atul
ashoat added inline comments to D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
rohan added inline comments to D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
rohan added inline comments to D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.