Rebase. Extract repeating code
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 13 2023
Jun 13 2023
Rebase. Fix typo
Jun 12 2023
Jun 12 2023
Rebase on master
• ted added inline comments to D8156: [native] Create a new screen that will show the role change information.
Harbormaster failed remote builds in B20198: Diff 27668 for D8160: [native] Create a ChangeRolesHeaderRightButton to save role changes!
rohan attached a referenced file: F584774: Simulator Screen Shot - iPhone 14 Pro - 2023-06-12 at 17.09.18.png.
rohan added inline comments to D8156: [native] Create a new screen that will show the role change information.
rohan attached a referenced file: F584771: Simulator Screen Recording - iPhone 14 Pro - 2023-06-12 at 17.00.25.mp4.
Rebase
rohan updated the diff for D8160: [native] Create a ChangeRolesHeaderRightButton to save role changes.
Rebase for CI and add a loading indicator (involved moving the headerRight declaration from chat.react.js to inside the change roles screen )
rohan added inline comments to D8158: [native] Create a ChangeRolesHeaderLeftButton to cancel role changes.
Harbormaster failed remote builds in B20194: Diff 27664 for D8183: [web] remove avatar feature flag logic!
Address feedback
In D8159#241874, @atul wrote:It's not clear to me as of this diff how the user is supposed to save their changes, maybe that's more clear in a subsequent diff?
trigger blob unit tests
atul requested changes to D8160: [native] Create a ChangeRolesHeaderRightButton to save role changes.
Can we show a spinner when the request is in progress? It's probably pretty "instant" in your dev environment, but could look janky on prod if things are frozen until the request completes.
rebase before landing
Requesting changes for changes suggested by @ashoat.
atul requested changes to D8156: [native] Create a new screen that will show the role change information.
Requesting changes for letterSpacing justification. Also adding @ginsu as blocking to take a look at showActionSheet(...), specifically how it behaves "across platforms."
In D8155#241852, @atul wrote:Was removing "Remove admin" and "Make admin" options also intended to be a part of this diff? Didn't see anything in the title or summary so just want to make sure before this diff is accepted.
Was removing "Remove admin" and "Make admin" options also intended to be a part of this diff? Didn't see anything in the title or summary so just want to make sure before this diff is accepted.
(We're also ensuring that this isn't possible from the keyserver side, right?)
Seems a little weird to me from a product standpoint, but code looks correct.
(Restarted failing iOS build)
atul added a comment to D8114: Provided detailed error messages on olm functions failures in CryptoModule.
(Restarted failing iOS build)
(Shellcheck CI job should pass after pulling in latest changes.)
(Shellcheck CI job should pass after pulling in latest changes.)
(Shellcheck CI job should pass after pulling in latest changes.)
(Shellcheck CI job should pass after pulling in latest changes.)
(Shellcheck CI job should pass after pulling in latest changes.)
New package looks good! Resigning so that one of the other reviews can take a look at the Rust
marcin updated the diff for D8113: Refactor android notifications native and JavaScript code so that JS can register for events using native constants.
Rebase before landing
marcin updated the diff for D8106: Refactor CommIOSNotifications native and JavaScript code so that JavaScript registers to events using getConstants object instead of hardcoded strings.
Rebase before landing
Harbormaster failed remote builds in B20185: Diff 27651 for D8143: [keyserver] Validate search endpoint response!
Can you pull in latest changes before landing and ensure CI checks pass
Trusting the numbers, would be good if there was a comment explaining where the numbers come from
inka updated the diff for D8144: [kayserver] Fix search endpoint failing when called with a stopword.
Add a test
Harbormaster failed remote builds in B20182: Diff 27648 for D8114: Provided detailed error messages on olm functions failures in CryptoModule!
Rebase
Harbormaster failed remote builds in B20183: Diff 27649 for D8183: [web] remove avatar feature flag logic!
forgot to remove unused class
marcin updated the diff for D8114: Provided detailed error messages on olm functions failures in CryptoModule.
Rebase before landing
Ouch, sorry, landed this ASAP to unblock CI. Will apply your suggestion in another diff
Harbormaster failed remote builds in B20181: Diff 27646 for D8143: [keyserver] Validate search endpoint response!
Modify input logic