Fix flow
Feed All Stories
Jun 14 2023
Jun 14 2023
tomek requested review of D8204: [native] Fix invite link button positioning.
michal updated the diff for D8009: [lib] Include searchUsers results in getPotentialMemberItems.
Rebase
michal planned changes to D8010: [native] Use search users in chat composer.
inka added inline comments to D8027: [web] Scrolling to the edited message when it overflows.
Harbormaster failed remote builds in B20234: Diff 27716 for D8010: [native] Use search users in chat composer!
michal added inline comments to D8010: [native] Use search users in chat composer.
michal updated the diff for D8010: [native] Use search users in chat composer.
Catch errors
@michal created a new stack with this feature: https://phab.comm.dev/D8013
• kuba updated the diff for D8027: [web] Scrolling to the edited message when it overflows.
Respond to the review
Restricted Repository Identity closed D8036: [native] Unify alert behavior when changing selected edited message.
kosmydel <kukubaczek@gmail.com> committed rCOMMa5f9b1e53b7f: [native] Unify alert behavior when changing selected edited message.
varun requested review of D8202: [keyserver] add removeReservedUsername method to rust-node-addon.
varun requested review of D8201: [keyserver] add addReservedUsername method to rust-node-addon.
rohan attached a referenced file: F586189: Simulator Screen Recording - iPhone 14 Pro - 2023-06-13 at 21.29.51.mp4.
rohan updated the diff for D8161: [native] Prevent the only admin role from being changed.
Refactor the way we indicate a role change cannot be possible to be similar to web (block the user from getting into an invalid state all together)
Thanks for addressing feedback
atul added a reviewer for D8200: [keyserver] Prevent the only admin role from being changed on the keyserver: ashoat.
Adding @ashoat as blocking here to take another look
Looks good, thanks for linking successful workflow
Jun 13 2023
Jun 13 2023
rohan requested review of D8200: [keyserver] Prevent the only admin role from being changed on the keyserver.
rohan attached a referenced file: F586047: Screen Recording 2023-06-13 at 4.11.56 PM.mov.
rohan updated the diff for D8136: [web] Implement a custom dropdown menu component.
Correct syntax
rohan updated the diff for D8141: [web] Prevent changing the only admin role in a community.
Address design feedback (video below)
rohan updated the diff for D8138: [web] Create a modal that allows admins to change a member's role (dropdown menu, actionable buttons).
Rebase
rohan updated the diff for D8137: [web] Create a modal that allows admins to change a member's role (modal, description, avatar).
Rebase
rohan updated the diff for D8136: [web] Implement a custom dropdown menu component.
Add disabled prop
Probably outside the scope of this diff, but might be worth to consider disabling auto correct on the Enter a keyserver RegistrationTextInput in a follow up diff. Would avoid the situation in the demo video where "localhost" => "local host" and I think if people had unique keyserver names in the future, autocorrect here could be annoying in the user experience
rohan updated the diff for D8156: [native] Create a new screen that will show the role change information.
Address action sheet feedback
ginsu added inline comments to D8156: [native] Create a new screen that will show the role change information.
rohan attached a referenced file: F585851: Screenshot 2023-06-13 at 3.21.53 PM.png.
rohan added a comment to D8156: [native] Create a new screen that will show the role change information.
rohan added inline comments to D8156: [native] Create a new screen that will show the role change information.
ginsu updated the diff for D8172: [landing] make all external links open in a new tab.
address comments
ginsu requested changes to D8156: [native] Create a new screen that will show the role change information.
Requesting changes for Android action/bottom sheet implementation. Here is the doc for android action/bottom sheet best practices
ashoat requested review of D8198: [native] Add error handling to KeyserverSelection.
• ted attached a referenced file: F585775: Screenshot 2023-06-13 at 2.05.18 PM.png.
varun added inline comments to D8178: [Tunnelbroker] Use rabbitmq for message delivery.
varun added inline comments to D8178: [Tunnelbroker] Use rabbitmq for message delivery.
• jon added inline comments to D8178: [Tunnelbroker] Use rabbitmq for message delivery.
ashoat requested review of D8197: [native] Set urlPrefix in Redux following successful registration.
ashoat requested review of D8196: [native] Part 2: use user's keyserver selection in registration flow.
ashoat requested review of D8195: [native] Part 1: use user's keyserver selection in registration flow.
inka updated the diff for D8112: [native] Flatten nested FlatLists in community drawer.
Address review
ashoat requested review of D8194: [native] Update KeyserverSelection to take URL instead of username as input.
ashoat requested review of D8193: [native] keyserverUsername -> keyserverURL.
inka updated the diff for D8105: [native] Add functions to filter thread descendants in community drawer.
Rename function
• ted added a comment to D8141: [web] Prevent changing the only admin role in a community.
Agree with @atul as well.
ashoat requested review of D8191: [lib] Introduce action for new getVersion endpoint.
ashoat requested review of D8190: [keyserver][lib] Introduce `version` endpoint.
ashoat requested review of D8189: [lib][web] Move web codeVersion to lib.
LGTM, let atul have a look
rohan planned changes to D8161: [native] Prevent the only admin role from being changed.
Planning changes to hold off on review until feedback on D8141 is addressed
• ted added a comment to D8137: [web] Create a modal that allows admins to change a member's role (modal, description, avatar).
rohan added a comment to D8137: [web] Create a modal that allows admins to change a member's role (modal, description, avatar).
• ted added a comment to D8137: [web] Create a modal that allows admins to change a member's role (modal, description, avatar).
rohan planned changes to D8141: [web] Prevent changing the only admin role in a community.
rohan added a comment to D8141: [web] Prevent changing the only admin role in a community.
rohan updated the diff for D8156: [native] Create a new screen that will show the role change information.
Remove letterSpacing, add fontWeight, set avatar size to profile
rohan added inline comments to D8156: [native] Create a new screen that will show the role change information.
rohan attached a referenced file: F585238: Screenshot 2023-06-13 at 7.47.23 AM.png.
rohan attached a referenced file: F585235: Screenshot 2023-06-13 at 7.46.50 AM.png.
rohan added a comment to D8137: [web] Create a modal that allows admins to change a member's role (modal, description, avatar).
Based on our discussion for using size="profile" in the screen on native, do we also want to do that on web? I personally think the profile-sized avatar looks too big on web, but open to a second option
tomek added inline comments to D8124: [web-db] avoid database init on app start on Safari.