Looks like a fairly straightforward refactor

Remove unused green color

The code makes sense, but I can't actually see the screenshots since they seem to be restricted. Could you attach them please?

rebase before landing

@ginsu, I think it could be good if we could "abstract away" these platform-specific quirks

address review

rename param

address review

rebase and land

make params read-only

Disable autoCorrect following @ginsu's feedback in D8198. Also disabled autoCapitalize

Oops, updated the wrong diff

Disable autoCorrect following @ginsu's feedback in D8198. Also disabled autoCapitalize

In D8198#242231, @ginsu wrote:

Probably outside the scope of this diff, but might be worth to consider disabling auto correct on the Enter a keyserver RegistrationTextInput in a follow up diff. Would avoid the situation in the demo video where "localhost" => "local host" and I think if people had unique keyserver names in the future, autocorrect here could be annoying in the user experience

I don't have context on future uses for this endpoint, but will we have to worry about scenarios where user-deployed "malicious" keyservers could potentially "lie" about their version?

After a discussion with @inka we decided to add dynamic height calculation. Now, the maximum height of the edit box will be adjusted to the container height. We will scroll to the edited message only when there is insufficient space for the 150px text area in the edit box.

Added dynamic maximum height, addressed review

Add comment