Page MenuHomePhorge
Feed All Stories

Apr 11 2025

ashoat requested changes to D14561: [native][web] Add migrations unshimming delete messages.

A cursory glance shows that createAsyncMigrate handles calling handleReduxMigrationFailure when an exception is thrown. I wish both @tomek and @bartek had looked at the code a little closer here.

Apr 11 2025, 3:06 PM
kamil published D14570: [SQLite][native] introduce `SQLiteUtils` class for review.
Apr 11 2025, 3:03 PM
ashoat added a comment to D14566: [native] Fix uploading images with ph-upload:// scheme.

It seems like we're discarding the processed media, since we're returning uploadURI to the caller (non-processed media). I hope I'm missing something here, as both @angelika and @bartek did not flag this...

Apr 11 2025, 2:49 PM
angelika closed D14566: [native] Fix uploading images with ph-upload:// scheme.
Apr 11 2025, 2:44 PM
angelika committed rCOMM7be9e166f04c: [native] Fix uploading images with ph-upload:// scheme.
Apr 11 2025, 2:44 PM
kamil accepted D14569: [native] Make missing AuthMetadata message more accurate.
Apr 11 2025, 11:54 AM
bartek published D14569: [native] Make missing AuthMetadata message more accurate for review.
Apr 11 2025, 10:43 AM
bartek published D14568: [native] Fetch platform details during restore flow for review.
Apr 11 2025, 10:39 AM
bartek accepted D14561: [native][web] Add migrations unshimming delete messages.
Apr 11 2025, 7:20 AM
bartek accepted D14566: [native] Fix uploading images with ph-upload:// scheme.
Apr 11 2025, 6:41 AM
angelika requested review of D14566: [native] Fix uploading images with ph-upload:// scheme.
Apr 11 2025, 1:10 AM

Apr 10 2025

tomek updated the diff for D14534: [lib] Add a new endpoint for deleting messages.

Fix the logic

Apr 10 2025, 4:23 PM
ashoat accepted D14534: [lib] Add a new endpoint for deleting messages.

Accepting pending resolution of CI

Apr 10 2025, 3:59 PM
Harbormaster failed remote builds in B33961: Diff 47745 for D14534: [lib] Add a new endpoint for deleting messages!
Apr 10 2025, 3:36 PM
ashoat closed D14565: [keyserver] Introduce checkThreadsOr.
Apr 10 2025, 3:27 PM
ashoat committed rCOMM7fcc58529c58: [keyserver] Introduce checkThreadsOr.
Apr 10 2025, 3:27 PM
tomek updated the diff for D14534: [lib] Add a new endpoint for deleting messages.

Reduce number of queries

Apr 10 2025, 3:17 PM
tomek accepted D14565: [keyserver] Introduce checkThreadsOr.
Apr 10 2025, 3:06 PM
tomek added inline comments to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 3:04 PM
tomek updated the diff for D14557: [native][web] Handle deleted messages when searching.

Rebase

Apr 10 2025, 3:02 PM
ashoat accepted D14556: [keyserver] Handle deleted messages when searching.
Apr 10 2025, 3:00 PM
ashoat added inline comments to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 2:59 PM
tomek added inline comments to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 2:46 PM
tomek added inline comments to D14556: [keyserver] Handle deleted messages when searching.
Apr 10 2025, 2:40 PM
tomek updated the diff for D14556: [keyserver] Handle deleted messages when searching.

Return deleted message when fetching related messages

Apr 10 2025, 2:40 PM
ashoat requested changes to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 2:32 PM
ashoat published D14565: [keyserver] Introduce checkThreadsOr for review.
Apr 10 2025, 2:32 PM
tomek added inline comments to D14548: [native][web] Hide edit label and reactions of deleted messages.
Apr 10 2025, 2:26 PM
tomek updated the diff for D14542: [native][web] Show an option to delete a message.

Fix deleting messages in a sidebar

Apr 10 2025, 2:22 PM
ashoat added inline comments to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 2:14 PM
tomek added inline comments to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 2:09 PM
tomek updated the diff for D14534: [lib] Add a new endpoint for deleting messages.

Update a comment

Apr 10 2025, 2:09 PM
ashoat accepted D14564: [lib] Handle deleted messages when generating notifs.
Apr 10 2025, 2:04 PM
ashoat added a reviewer for D14561: [native][web] Add migrations unshimming delete messages: bartek.
Apr 10 2025, 1:41 PM
tomek requested review of D14564: [lib] Handle deleted messages when generating notifs.
Apr 10 2025, 1:27 PM
ashoat requested changes to D14556: [keyserver] Handle deleted messages when searching.
Apr 10 2025, 1:14 PM
tomek updated subscribers of D14561: [native][web] Add migrations unshimming delete messages.
Apr 10 2025, 12:50 PM
tomek updated the diff for D14561: [native][web] Add migrations unshimming delete messages.

Handle migration failure

Apr 10 2025, 12:50 PM
tomek updated the diff for D14560: [native][web] Add migrations unshimming delete message operations.

Rebase

Apr 10 2025, 12:48 PM
tomek updated the diff for D14505: [lib] Migrate delete message permissions on clients.

Rebase

Apr 10 2025, 12:45 PM
tomek added inline comments to D14556: [keyserver] Handle deleted messages when searching.
Apr 10 2025, 12:31 PM
tomek updated the diff for D14556: [keyserver] Handle deleted messages when searching.

Remove unnecessary condition

Apr 10 2025, 12:30 PM
tomek added inline comments to D14549: [keyserver] Handle unpinning deleted messages.
Apr 10 2025, 12:25 PM
tomek updated the diff for D14549: [keyserver] Handle unpinning deleted messages.

Optimize the code a bit

Apr 10 2025, 12:25 PM
bartek closed D14563: [lib] Use AuxUserStore peer list in primary logout.
Apr 10 2025, 10:56 AM
bartek committed rCOMM2fae88ffe011: [lib] Use AuxUserStore peer list in primary logout.
Apr 10 2025, 10:56 AM
kamil closed D14562: [native][SQLite] add logging to errors.
Apr 10 2025, 10:11 AM
kamil committed rCOMM0db8526f1c97: [native][SQLite] add logging to errors.
Apr 10 2025, 10:11 AM
kamil accepted D14563: [lib] Use AuxUserStore peer list in primary logout.
Apr 10 2025, 10:10 AM
bartek published D14563: [lib] Use AuxUserStore peer list in primary logout for review.
Apr 10 2025, 10:06 AM
bartek accepted D14562: [native][SQLite] add logging to errors.
Apr 10 2025, 9:59 AM
kamil published D14562: [native][SQLite] add logging to errors for review.
Apr 10 2025, 9:54 AM
ashoat requested changes to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 3:12 AM
ashoat added inline comments to D14548: [native][web] Hide edit label and reactions of deleted messages.
Apr 10 2025, 3:12 AM
ashoat added a comment to D14547: [web] Disable all the actions for a deleted message.

Looks a little weird, but it's okay

Apr 10 2025, 3:07 AM
ashoat accepted D14546: [native] Update message height measurement logic to handle deleted messages.

I suppose the italics don't change the height

Apr 10 2025, 3:07 AM
ashoat accepted D14545: [native] Display a deleted message on native.
Apr 10 2025, 3:05 AM
ashoat accepted D14544: [web] Display a deleted message on web.
Apr 10 2025, 3:04 AM
ashoat accepted D14542: [native][web] Show an option to delete a message.
Apr 10 2025, 3:02 AM
ashoat added inline comments to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 3:00 AM
ashoat accepted D14561: [native][web] Add migrations unshimming delete messages.
Apr 10 2025, 2:56 AM
ashoat accepted D14560: [native][web] Add migrations unshimming delete message operations.
Apr 10 2025, 2:55 AM

Apr 9 2025

tomek added inline comments to D14548: [native][web] Hide edit label and reactions of deleted messages.
Apr 9 2025, 5:57 PM
tomek added inline comments to D14548: [native][web] Hide edit label and reactions of deleted messages.
Apr 9 2025, 5:55 PM
tomek updated the diff for D14548: [native][web] Hide edit label and reactions of deleted messages.

Simplify

Apr 9 2025, 5:55 PM
tomek updated the summary of D14547: [web] Disable all the actions for a deleted message.
Apr 9 2025, 5:37 PM
tomek added a comment to D14547: [web] Disable all the actions for a deleted message.

Can you share a screenshot of what a mouseover looks like in this case? Wondering if the timestamp still appears, and where it appears

Apr 9 2025, 5:37 PM
tomek updated the diff for D14548: [native][web] Hide edit label and reactions of deleted messages.

Rebase

Apr 9 2025, 5:36 PM
tomek updated the diff for D14546: [native] Update message height measurement logic to handle deleted messages.

Delete outdated comment

Apr 9 2025, 5:33 PM
tomek added inline comments to D14546: [native] Update message height measurement logic to handle deleted messages.
Apr 9 2025, 5:33 PM
tomek updated the diff for D14546: [native] Update message height measurement logic to handle deleted messages.

Don't use markdown when measuring deleted messages

Apr 9 2025, 5:33 PM
tomek updated the summary of D14545: [native] Display a deleted message on native.
Apr 9 2025, 5:25 PM
tomek updated the diff for D14545: [native] Display a deleted message on native.

Avoid using markdown. Update the design.

Apr 9 2025, 5:25 PM
tomek added a comment to D14544: [web] Display a deleted message on web.

The white background feels like too strong of a contrast... I feel like a deleted message should be less visible than a non-deleted message. Could we try something closer to what Rahul had in his designs?

Apr 9 2025, 5:07 PM
tomek updated the summary of D14544: [web] Display a deleted message on web.
Apr 9 2025, 5:06 PM
tomek updated the diff for D14544: [web] Display a deleted message on web.

Simplify. Update the style.

Apr 9 2025, 5:06 PM
tomek updated the diff for D14543: [lib] Update chat selector to return an info telling if a message was deleted.

Simplify

Apr 9 2025, 4:51 PM
tomek updated the diff for D14552: [web] Show a confirmation modal when deleting a message.

Rebase

Apr 9 2025, 4:47 PM
tomek added a comment to D14542: [native][web] Show an option to delete a message.

I want to review the icon before landing, but this generally looks good

Apr 9 2025, 4:46 PM
tomek updated the summary of D14542: [native][web] Show an option to delete a message.
Apr 9 2025, 4:45 PM
tomek updated the diff for D14542: [native][web] Show an option to delete a message.

Use the util and replace the web icon

Apr 9 2025, 4:44 PM
tomek updated the diff for D14541: [lib] Create a hook that can delete thin and thick messages.

Await the promise to make this symmetric with the thick thread's code

Apr 9 2025, 4:31 PM
tomek added inline comments to D14541: [lib] Create a hook that can delete thin and thick messages.
Apr 9 2025, 4:29 PM
tomek updated the diff for D14541: [lib] Create a hook that can delete thin and thick messages.

Simplify the code

Apr 9 2025, 4:29 PM
tomek added a comment to D14536: [native] Add delete message spec to the C++ layer.

Do we need to do anything for it to be included in the Android build, eg. update some CMakeLists.txt file?

Apr 9 2025, 4:23 PM
tomek requested review of D14534: [lib] Add a new endpoint for deleting messages.
Apr 9 2025, 4:11 PM
tomek updated the diff for D14561: [native][web] Add migrations unshimming delete messages.

Rebase

Apr 9 2025, 3:29 PM
tomek updated the diff for D14560: [native][web] Add migrations unshimming delete message operations.

Rebase

Apr 9 2025, 3:27 PM
tomek updated the summary of D14561: [native][web] Add migrations unshimming delete messages.
Apr 9 2025, 3:26 PM
tomek updated the summary of D14560: [native][web] Add migrations unshimming delete message operations.
Apr 9 2025, 3:26 PM
tomek updated the diff for D14557: [native][web] Handle deleted messages when searching.

Rebase

Apr 9 2025, 3:25 PM
tomek updated the diff for D14505: [lib] Migrate delete message permissions on clients.

Rebase

Apr 9 2025, 3:22 PM
tomek requested review of D14561: [native][web] Add migrations unshimming delete messages.
Apr 9 2025, 3:15 PM
tomek planned changes to D14542: [native][web] Show an option to delete a message.
Apr 9 2025, 3:15 PM
tomek updated the diff for D14542: [native][web] Show an option to delete a message.

Close the tooltip after deleting a message

Apr 9 2025, 3:15 PM
tomek requested review of D14560: [native][web] Add migrations unshimming delete message operations.
Apr 9 2025, 3:14 PM
kamil closed D14559: [terraform] bump staging Tunnelbroker to 0.18.4.
Apr 9 2025, 11:27 AM
kamil committed rCOMM8832665bb4fe: [terraform] bump staging Tunnelbroker to 0.18.4.
Apr 9 2025, 11:27 AM
tomek accepted D14559: [terraform] bump staging Tunnelbroker to 0.18.4.
Apr 9 2025, 11:09 AM
kamil published D14559: [terraform] bump staging Tunnelbroker to 0.18.4 for review.
Apr 9 2025, 11:01 AM