Paths

Table of Contentst

Differential D12428

Bump minimal native code version to 149
ClosedPublic
Actions

Authored by marcin on Jun 13 2024, 8:58 AM.

Tags

None

Referenced Files

	F2829063: D12428.diff
	Fri, Sep 27, 3:18 PM

	Unknown Object (File)
	Sat, Sep 7, 9:34 AM

	Unknown Object (File)
	Tue, Sep 3, 7:11 PM

	Unknown Object (File)
	Tue, Sep 3, 7:10 PM

	Unknown Object (File)
	Tue, Sep 3, 7:10 PM

	Unknown Object (File)
	Tue, Sep 3, 7:10 PM

	Unknown Object (File)
	Tue, Sep 3, 7:10 PM

	Unknown Object (File)
	Tue, Sep 3, 7:10 PM

View All 54 Files

Subscribers

Details

Reviewers

kamil
tomek
ashoat

Commits

rCOMMafedfbff8d09: Bump minimal native code version to 149

Summary

I want to remove support for 135 code version not to have to handle managedAps: {} in APNs rescind types I am about to introduce. The next code version after 135 that we have checks for is 150. Therefore I cut support for less than 149 to minimize the amout of checks to remove and the scope of this diff. The oldest code version in use is currently 185 (1 ios user).

Test Plan

N/A

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Jun 13 2024, 8:58 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 13 2024, 8:58 AM

marcin added a parent revision: D12427: Move android rescinds and badge updates to lib.Jun 13 2024, 8:59 AM

marcin added a child revision: D12429: Implement notification types, creation and encryption for APNs notifications.Jun 13 2024, 9:05 AM

Harbormaster completed remote builds in B29667: Diff 41291.Jun 13 2024, 9:14 AM

marcin requested review of this revision.Jun 13 2024, 9:14 AM

ashoat accepted this revision.Jun 13 2024, 11:41 AM

ashoat added inline comments.

keyserver/src/fetchers/message-fetchers.js
457–458	Should this be removed?
470	Should `'NONE'` be removed here?

This revision is now accepted and ready to land.Jun 13 2024, 11:41 AM

Remove 'NONE' and its usages

Harbormaster completed remote builds in B30079: Diff 41943.Jul 3 2024, 3:49 AM

Rebase before landing

Harbormaster completed remote builds in B30138: Diff 42015.Jul 4 2024, 6:08 AM

Closed by commit rCOMMafedfbff8d09: Bump minimal native code version to 149 (authored by marcin). · Explain WhyJul 4 2024, 7:19 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMafedfbff8d09: Bump minimal native code version to 149.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

message-fetchers.js

15 lines

push/

23 lines

session/

2 lines

Diff 41291

keyserver/src/fetchers/message-fetchers.js

Loading...

keyserver/src/push/rescind.js

Loading...

keyserver/src/session/version.js

Loading...