[web-db] not include `crypto`, `fs`, and `path` polyfills for workers
ClosedPublic
Actions

Authored by kamil on Mar 7 2023, 8:34 AM.

Details

Reviewers

michal
tomek
ashoat

Commits

rCOMMc768b34b0417: [web-db] not include `crypto`, `fs`, and `path` polyfills for workers

Summary

Docs: webpack.

Without this change including sql,js module in worker will cause issues with module not found.

Depends on D6987

Test Plan

cd web && yarn dev

Diff Detail

Repository

rCOMM Comm

Branch

db-on-web-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Mar 7 2023, 8:34 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 7 2023, 8:34 AM

kamil added a child revision: D6990: [web-db] add indexedDB config.Mar 7 2023, 8:45 AM

Harbormaster completed remote builds in B17164: Diff 23506.Mar 7 2023, 8:50 AM

kamil published this revision for review.Mar 7 2023, 10:05 AM

The title is somewhat misleading, but mostly the fault of Webpack docs. Before this diff, the polyfills were not included. After this diff, each of these is set to the empty object (I think)

This revision is now accepted and ready to land.Mar 7 2023, 4:25 PM

Closed by commit rCOMMc768b34b0417: [web-db] not include `crypto`, `fs`, and `path` polyfills for workers (authored by kamil). · Explain WhyMar 17 2023, 3:47 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMc768b34b0417: [web-db] not include `crypto`, `fs`, and `path` polyfills for workers.

Revision Contents
Changeset List

Path

Size

web/

webpack.config.cjs

7 lines

Diff 23506

View Options

[web-db] not include `crypto`, `fs`, and `path` polyfills for workersClosedPublicActions