Page MenuHomePhabricator
Differential D8480

[landing] fix body scrolling when modal is active
ClosedPublic
Actions

Authored by ginsu on Jul 11 2023, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 2:18 AM
Unknown Object (File)
Sun, Nov 17, 1:40 AM
Unknown Object (File)
Sun, Nov 17, 1:40 AM
Unknown Object (File)
Sun, Nov 17, 1:40 AM
Unknown Object (File)
Sun, Nov 17, 1:40 AM
Unknown Object (File)
Sat, Nov 16, 11:28 PM
Unknown Object (File)
Oct 18 2024, 11:41 PM
Unknown Object (File)
Oct 17 2024, 2:15 AM
View All 84 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMMd1bdf88145aa: [landing] fix body scrolling when modal is active
Summary

As I was working on D8477, I noticed that I introduced a regression in D8175 where the page would still scroll even when a modal was active. With @ashoat's help, we built this diff to fix this regression

Depends on D8477

Test Plan

Please see the demo video to see that the scroll no longer works when the modal is active, and that the keyserver animations and scroll to top functionality on navigation still works

Diff Detail

Repository
rCOMM Comm
Branch
eng-3423 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 11 2023, 3:52 PM
Herald added a subscriber: tomek. · View Herald TranscriptJul 11 2023, 3:52 PM
ginsu edited the summary of this revision. (Show Details)Jul 11 2023, 3:54 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu attached a referenced file: F632171: Screen Recording 2023-07-11 at 6.53.02 PM.mov. (Show Details)
ginsu attached a referenced file: F632177: Screen Recording 2023-07-11 at 5.00.34 PM.mov. (Show Details)
ginsu edited the summary of this revision. (Show Details)
ginsu added a parent revision: D8477: [landing] clean up competitor comparison UI.
Harbormaster completed remote builds in B20885: Diff 28607.Jul 11 2023, 4:10 PM
ginsu requested review of this revision.Jul 11 2023, 4:10 PM
kamil accepted this revision.Jul 13 2023, 2:37 AM
kamil added inline comments.
landing/landing.react.js
54–58

nit

This revision is now accepted and ready to land.Jul 13 2023, 2:37 AM
ginsu updated this revision to Diff 28679.Jul 13 2023, 10:20 AM

address comments

Harbormaster completed remote builds in B20925: Diff 28679.Jul 13 2023, 10:37 AM
ginsu updated this revision to Diff 29711.Aug 8 2023, 12:56 PM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM
Closed by commit rCOMMd1bdf88145aa: [landing] fix body scrolling when modal is active (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMd1bdf88145aa: [landing] fix body scrolling when modal is active.
Harbormaster completed remote builds in B21665: Diff 29711.Aug 8 2023, 3:25 PM

Revision Contents
Changeset List

PathSize
landing/
13 lines

Diff 28607

View Options

landing/landing.react.js

Loading...