Page MenuHomePhabricator
Differential D7288

[web-db] extract worker write requests to a separate condition
ClosedPublic
Actions

Authored by kamil on Apr 3 2023, 5:04 AM.
Tags
None
Referenced Files
F6311323: D7288.diff
Sat, Apr 26, 12:12 PM
Unknown Object (File)
Thu, Apr 24, 2:26 PM
Unknown Object (File)
Wed, Apr 23, 3:25 PM
Unknown Object (File)
Sun, Apr 20, 5:56 AM
Unknown Object (File)
Fri, Apr 18, 12:37 PM
Unknown Object (File)
Fri, Apr 18, 11:15 AM
Unknown Object (File)
Fri, Apr 18, 11:15 AM
Unknown Object (File)
Thu, Apr 17, 10:04 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
michal
tomek
Commits
rCOMM49c2a6e22823: [web-db] extract worker write requests to a separate condition
Summary

Improving code by extracting common code to separate branch.

Depends on D7186

Test Plan

yarn flow check

Diff Detail

Repository
rCOMM Comm
Branch
land-db
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Apr 3 2023, 5:04 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 3 2023, 5:04 AM
kamil mentioned this in D7186: [web-db] start persisting SQLite content.Apr 3 2023, 5:05 AM
kamil updated this revision to Diff 24573.Apr 3 2023, 5:16 AM

make array read only

Harbormaster completed remote builds in B17940: Diff 24572.Apr 3 2023, 5:20 AM
Harbormaster completed remote builds in B17941: Diff 24573.Apr 3 2023, 5:32 AM
kamil published this revision for review.Apr 3 2023, 5:37 AM
kamil added a child revision: D7289: [web-db] improve persisting lifecycle.Apr 3 2023, 5:46 AM
tomek accepted this revision.Apr 4 2023, 2:11 AM
tomek added inline comments.
web/database/worker/db-worker.js
207–231 ↗(On Diff #24573)

What do you think about having early exit? We can also consider extracting write operations to a separate function that only accepts workerWriteRequests

This revision is now accepted and ready to land.Apr 4 2023, 2:11 AM
kamil updated this revision to Diff 24703.Apr 6 2023, 3:35 AM

early exit

Harbormaster completed remote builds in B18031: Diff 24703.Apr 6 2023, 3:51 AM
Closed by commit rCOMM49c2a6e22823: [web-db] extract worker write requests to a separate condition (authored by kamil). · Explain WhyApr 6 2023, 3:59 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM49c2a6e22823: [web-db] extract worker write requests to a separate condition.
kamil removed a child revision: D7289: [web-db] improve persisting lifecycle.Apr 27 2023, 6:48 AM
kamil added a child revision: D7289: [web-db] improve persisting lifecycle.May 8 2023, 2:42 AM
kamil removed a child revision: D7289: [web-db] improve persisting lifecycle.May 8 2023, 2:44 AM
kamil added a child revision: D7289: [web-db] improve persisting lifecycle.May 11 2023, 3:26 AM

Revision Contents
Changeset List

PathSize
web/
database/
worker/
15 lines
types/
7 lines

Diff 24703

View Options

web/database/worker/db-worker.js

Loading...
View Options

web/types/worker-types.js

Loading...