Differential D7664
[lib] make fields in setting client store action optional Authored by kamil on Apr 27 2023, 7:36 AM. Tags None Referenced Files
Details I want to reuse this logic on the web, but only drafts are stored in the web database for now. Dispatching this with empty objects will affect the store, so we have somehow tell reducer that values are missing. A different approach will be introducing a new action type, with only drafts, and using it in draft reducer only - in reviewers think that this is better I am open to updating this. Depends on D7662 Check on native is this does not affect current logic
Diff Detail
Event TimelineComment Actions Should be ok both ways, but having a separate action is safer - the typesystem checks if all the required fields are set. And on native, not setting some fields, is probably an error state. We can also consider keeping one action but typing it safer, e.g. +payload: {
+platform: 'native'
+currentUserID: ?string,
+drafts: $ReadOnlyArray<ClientDBDraftInfo>,
+messages: $ReadOnlyArray<ClientDBMessageInfo>,
+threadStore: ThreadStore,
+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,
} | {
+platform: 'web'
+currentUserID: ?string,
+drafts: $ReadOnlyArray<ClientDBDraftInfo>,
}
| ||||||||||||||||||||||||||||||||||