Page MenuHomePhabricator

[landing] fix body scrolling when modal is active
ClosedPublic

Authored by ginsu on Jul 11 2023, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 3:17 PM
Unknown Object (File)
Wed, Dec 4, 3:17 PM
Unknown Object (File)
Wed, Dec 4, 2:57 PM
Unknown Object (File)
Wed, Dec 4, 2:42 PM
Unknown Object (File)
Wed, Dec 4, 6:42 AM
Unknown Object (File)
Sun, Nov 17, 2:18 AM
Unknown Object (File)
Sun, Nov 17, 1:40 AM
Unknown Object (File)
Sun, Nov 17, 1:40 AM
Subscribers

Details

Summary

As I was working on D8477, I noticed that I introduced a regression in D8175 where the page would still scroll even when a modal was active. With @ashoat's help, we built this diff to fix this regression

Depends on D8477

Test Plan

Please see the demo video to see that the scroll no longer works when the modal is active, and that the keyserver animations and scroll to top functionality on navigation still works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu edited the summary of this revision. (Show Details)
ginsu requested review of this revision.Jul 11 2023, 4:10 PM
kamil added inline comments.
landing/landing.react.js
54–58 ↗(On Diff #28607)

nit

This revision is now accepted and ready to land.Jul 13 2023, 2:37 AM
This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM
This revision was automatically updated to reflect the committed changes.