Page MenuHomePhabricator
Differential D8974

[services-lib][blob-client] Use Bytes instead of Vec<u8>
ClosedPublic
Actions

Authored by bartek on Aug 28 2023, 4:06 AM.
Tags
None
Referenced Files
F3368515: D8974.id30519.diff
Mon, Nov 25, 8:05 PM
Unknown Object (File)
Fri, Nov 22, 10:46 AM
Unknown Object (File)
Fri, Nov 22, 4:52 AM
Unknown Object (File)
Tue, Nov 12, 11:56 AM
Unknown Object (File)
Fri, Nov 8, 6:25 PM
Unknown Object (File)
Sun, Oct 27, 4:46 PM
Unknown Object (File)
Oct 14 2024, 8:49 PM
Unknown Object (File)
Oct 2 2024, 2:42 PM
View All 79 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
• jon
Commits
rCOMM758d5a4d6450: [services-lib][blob-client] Use Bytes instead of Vec<u8>
Summary

Partially overlaps with D8964 - we should use Bytes instead of Vec<u8> for blob data to avoid unnecessary allocations.

Also added the bytes dependency to services-lib and re-exported it.

Depends on D8786

Test Plan

Tested together with the next diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
backup/
comm-services-lib/
8 lines
src/
blob/
14 lines
9 lines
reports/

Diff 30432

View Options

services/backup/Cargo.lock

Loading...
View Options

services/comm-services-lib/Cargo.lock

Loading...
View Options

services/comm-services-lib/Cargo.toml

Loading...
View Options

services/comm-services-lib/src/blob/client.rs

Loading...
View Options

services/comm-services-lib/src/lib.rs

Loading...
View Options

services/reports/Cargo.lock

Loading...