Paths

Table of Contentst

[services-lib][blob-client] Use Bytes instead of Vec<u8>
ClosedPublic
Actions

Authored by bartek on Aug 28 2023, 4:06 AM.

Details

Reviewers

michal
• jon

Commits

rCOMM758d5a4d6450: [services-lib][blob-client] Use Bytes instead of Vec<u8>

Summary

Partially overlaps with D8964 - we should use Bytes instead of Vec<u8> for blob data to avoid unnecessary allocations.

Also added the bytes dependency to services-lib and re-exported it.

Depends on D8786

Test Plan

Tested together with the next diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 28 2023, 4:06 AM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptAug 28 2023, 4:06 AM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

bartek added a child revision: D8975: [reports-service] Implement Blob storage.Aug 28 2023, 4:16 AM

bartek published this revision for review.Aug 28 2023, 4:17 AM

Harbormaster completed remote builds in B22166: Diff 30432.Aug 28 2023, 4:24 AM

michal accepted this revision.Aug 29 2023, 5:34 AM

This revision is now accepted and ready to land.Aug 29 2023, 5:34 AM

Closed by commit rCOMM758d5a4d6450: [services-lib][blob-client] Use Bytes instead of Vec<u8> (authored by bartek). · Explain WhyAug 29 2023, 11:24 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM758d5a4d6450: [services-lib][blob-client] Use Bytes instead of Vec<u8>.

Revision Contents
Changeset List

Path

Size

services/

backup/

Cargo.lock

comm-services-lib/

Cargo.lock

Cargo.toml

8 lines

src/

blob/

client.rs

14 lines

lib.rs

9 lines

reports/

Cargo.lock

Diff 30519

View Options

services/backup/Cargo.lock

View Options

services/comm-services-lib/Cargo.lock

View Options

services/comm-services-lib/Cargo.toml

View Options

services/comm-services-lib/src/blob/client.rs

View Options

services/comm-services-lib/src/lib.rs

View Options

services/reports/Cargo.lock

[services-lib][blob-client] Use Bytes instead of Vec<u8>ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30519

services/backup/Cargo.lock

services/comm-services-lib/Cargo.lock

services/comm-services-lib/Cargo.toml

services/comm-services-lib/src/blob/client.rs

services/comm-services-lib/src/lib.rs

services/reports/Cargo.lock

[services-lib][blob-client] Use Bytes instead of Vec<u8>
ClosedPublic
Actions

Revision Contents
Changeset List