Page MenuHomePhorge
Feed Search

Search
Use Results
Hide Query

Jun 1 2023

ashoat accepted D8051: [web] Fix preloading blob service URIs.
Jun 1 2023, 2:58 PM
ashoat accepted D8050: [web] Preload encrypted media.

Two concerns:

Jun 1 2023, 2:58 PM
ashoat accepted D7702: [Keyserver] Introduce tunnelbroker types.

JS looks good. Rust changes look simple but I'm not clear on how all of them connect to the JS. Might be good to add a reviewer who has context on that part of the codebase, but defer to @jon

Jun 1 2023, 1:03 PM

May 31 2023

ashoat requested review of D8049: [native] Default to ENS avatar for users that have one.
May 31 2023, 8:41 PM
ashoat requested review of D8048: [native] Introduce avatarData state to hold pending avatar in AvatarSelection.
May 31 2023, 8:39 PM
ashoat requested review of D8047: [native] Make EditUserAvatar component conditionally navigate to registration screens.
May 31 2023, 8:38 PM
ashoat requested review of D8046: [native] Construct synthetic UserInfo to pass to EditUserAvatar.
May 31 2023, 8:37 PM
ashoat requested review of D8045: [lib] Introduce new GenericUserInfoWithAvatar type.
May 31 2023, 8:35 PM
ashoat requested review of D8044: [native] Introduce new RegistrationUserAvatarCameraModal screen for registration flow.
May 31 2023, 8:32 PM
ashoat requested review of D8043: [native] Introduce new EmojiAvatarSelection screen for registration flow.
May 31 2023, 8:30 PM
ashoat requested review of D8042: [native] Replace savedEmojiAvatarSelector with savedEmojiAvatarFunc.
May 31 2023, 8:30 PM
ashoat added inline comments to D8034: [landing] introduce competitor comparison.
May 31 2023, 8:29 PM
ashoat added inline comments to D8041: [native] Introduce RegistrationMode in EditUserAvatarProvider.
May 31 2023, 8:27 PM
ashoat requested review of D8041: [native] Introduce RegistrationMode in EditUserAvatarProvider.
May 31 2023, 8:26 PM
ashoat accepted D7810: [native] login wallet user (C++).
May 31 2023, 7:37 PM
ashoat added inline comments to D8035: [web][fix] Fixed cursor issue in the message editing.
May 31 2023, 2:25 PM
ashoat accepted D8037: Implement miogration to recreate olm accounts.
May 31 2023, 1:28 PM
ashoat published D8037: Implement miogration to recreate olm accounts for review.
May 31 2023, 1:28 PM
ashoat added inline comments to D8035: [web][fix] Fixed cursor issue in the message editing.
May 31 2023, 12:26 PM
ashoat added a reverting change for D7654: Establish olm sessions for notifs on both sides during log-in: rCOMM3ced32553f61: Revert "Establish olm sessions for notifs on both sides during log-in".
May 31 2023, 11:51 AM
ashoat added a reverting change for rCOMM09bfb917cf36: Establish olm sessions for notifs on both sides during log-in: rCOMM3ced32553f61: Revert "Establish olm sessions for notifs on both sides during log-in".
May 31 2023, 11:51 AM
ashoat added a reverting change for D7657: Establish olm notifs session on both sides during registration: rCOMM080355ee6040: Revert "Establish olm notifs session on both sides during registration".
May 31 2023, 11:51 AM
ashoat committed rCOMM3ced32553f61: Revert "Establish olm sessions for notifs on both sides during log-in".
May 31 2023, 11:51 AM
ashoat added a reverting change for rCOMM29f99ee4dfad: Establish olm notifs session on both sides during registration: rCOMM080355ee6040: Revert "Establish olm notifs session on both sides during registration".
May 31 2023, 11:51 AM
ashoat committed rCOMM080355ee6040: Revert "Establish olm notifs session on both sides during registration".
May 31 2023, 11:51 AM
ashoat committed rCOMMac32a79404e3: Revert "Establish olm notifs sessions during siwe account creation".
May 31 2023, 11:51 AM
ashoat added a reverting change for D7669: Establish olm notifs sessions during siwe account creation: rCOMMac32a79404e3: Revert "Establish olm notifs sessions during siwe account creation".
May 31 2023, 11:51 AM
ashoat added a reverting change for rCOMM8c78e9a9a193: Establish olm notifs sessions during siwe account creation: rCOMMac32a79404e3: Revert "Establish olm notifs sessions during siwe account creation".
May 31 2023, 11:51 AM
ashoat added a reverting change for D7860: Handle client response to initial notifications encrypted message request: rCOMM4b66a767ea75: Revert "Handle client response to initial notifications encrypted message….
May 31 2023, 11:51 AM
ashoat added a reverting change for rCOMMcbe5181ccb9f: Handle client response to initial notifications encrypted message request: rCOMM4b66a767ea75: Revert "Handle client response to initial notifications encrypted message….
May 31 2023, 11:51 AM
ashoat committed rCOMM4b66a767ea75: Revert "Handle client response to initial notifications encrypted message….
May 31 2023, 11:51 AM

May 30 2023

ashoat closed D8023: [native] Make EmojiThreadAvatarCreation work with activeThreadSelector.
May 30 2023, 7:09 PM
ashoat committed rCOMMce10be74ff99: [native] Make EmojiThreadAvatarCreation work with activeThreadSelector.
May 30 2023, 7:09 PM
ashoat closed D8022: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.
May 30 2023, 7:09 PM
ashoat closed D8021: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar.
May 30 2023, 7:09 PM
ashoat closed D8020: [native] Replace removeThreadAvatar with generic setThreadAvatar.
May 30 2023, 7:09 PM
ashoat committed rCOMM894ce8c8bac0: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar.
May 30 2023, 7:09 PM
ashoat committed rCOMM5d343f2ba01b: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.
May 30 2023, 7:09 PM
ashoat committed rCOMMf5969fd86183: [native] Replace removeThreadAvatar with generic setThreadAvatar.
May 30 2023, 7:09 PM
ashoat closed D8018: [native] Replace generic useSaveUserAvatar with new generic setUserAvatar.
May 30 2023, 7:09 PM
ashoat closed D8019: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.
May 30 2023, 7:09 PM
ashoat committed rCOMM886fbe9e1293: [native] Replace generic useSaveUserAvatar with new generic setUserAvatar.
May 30 2023, 7:09 PM
ashoat committed rCOMM649d3964fd77: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.
May 30 2023, 7:09 PM
ashoat closed D8017: [native] Replace setENSUserAvatar and removeUserAvatar with generic setUserAvatar.
May 30 2023, 7:09 PM
ashoat committed rCOMM4767be3e48bf: [native] Replace setENSUserAvatar and removeUserAvatar with generic….
May 30 2023, 7:09 PM
ashoat updated the diff for D8022: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.

displayFailureAlert

May 30 2023, 7:06 PM
ashoat updated the diff for D8019: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.

displayFailureAlert

May 30 2023, 7:05 PM
ashoat updated subscribers of D8025: [landing] introduce feature modal component.
May 30 2023, 3:00 PM
ashoat accepted D7691: [Keyserver] Open websocket connection with tunnelbroker.
May 30 2023, 2:15 PM
ashoat updated the diff for D8020: [native] Replace removeThreadAvatar with generic setThreadAvatar.

Make setThreadAvatar return Promise<void> for consistency with D8017, since nothing needs its return anyways

May 30 2023, 12:52 PM
ashoat updated the diff for D8017: [native] Replace setENSUserAvatar and removeUserAvatar with generic setUserAvatar.

Make setUserAvatar return Promise<void> so that it can be used in the registration flow with the expectation that it calls the keyserver

May 30 2023, 12:51 PM
ashoat accepted D8026: [web] Fix "invariant violation" for encrypted uploads.
May 30 2023, 11:38 AM
ashoat requested review of D8023: [native] Make EmojiThreadAvatarCreation work with activeThreadSelector.
May 30 2023, 1:20 AM
ashoat requested review of D8022: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.
May 30 2023, 1:19 AM
ashoat requested review of D8021: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar.
May 30 2023, 1:19 AM
ashoat requested review of D8020: [native] Replace removeThreadAvatar with generic setThreadAvatar.
May 30 2023, 1:15 AM
ashoat requested review of D8019: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.
May 30 2023, 12:56 AM
ashoat requested review of D8018: [native] Replace generic useSaveUserAvatar with new generic setUserAvatar.
May 30 2023, 12:52 AM
ashoat requested review of D8017: [native] Replace setENSUserAvatar and removeUserAvatar with generic setUserAvatar.
May 30 2023, 12:52 AM

May 29 2023

ashoat accepted D7874: Encrypt Android notifications on the keyserver before sending them.
May 29 2023, 8:02 PM
ashoat accepted D7815: Send encrypted notifications to iOS devices.
May 29 2023, 5:25 PM
ashoat accepted D8014: [web] Revert wordmark position on macos.
May 29 2023, 2:44 PM
ashoat added inline comments to D8012: [keyserver] Include initial navInfo selectedUserList.
May 29 2023, 2:43 PM
ashoat accepted D8012: [keyserver] Include initial navInfo selectedUserList.
May 29 2023, 2:43 PM
ashoat accepted D7753: [lib] introduce function to find deep difference between two objects.

Thanks for annotating everything. I tried it locally and couldn't figure out anything better, unfortunately

May 29 2023, 2:33 PM
ashoat added inline comments to D8009: [lib] Include searchUsers results in getPotentialMemberItems.
May 29 2023, 1:58 PM

May 26 2023

ashoat closed D8006: [native] Add migration to populate MANAGE_INVITE_LINKS permission.
May 26 2023, 8:50 PM
ashoat committed rCOMM094cad791838: [native] Add migration to populate MANAGE_INVITE_LINKS permission.
May 26 2023, 8:50 PM
ashoat accepted D8007: [keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions` < 221.
May 26 2023, 8:49 PM
ashoat published D8006: [native] Add migration to populate MANAGE_INVITE_LINKS permission for review.
May 26 2023, 8:46 PM
ashoat added a comment to D7762: [lib] Introduce a new permission for managing invite links.

This permission should not have been introduced without corresponding changes on the native side to prevent massive inconsistency reports from being generated.

May 26 2023, 8:43 PM
ashoat closed D8005: [native] Launch message editing on mobile.
May 26 2023, 8:25 PM
ashoat committed rCOMMc09ed2789c50: [native] Launch message editing on mobile.
May 26 2023, 8:25 PM
ashoat requested review of D8005: [native] Launch message editing on mobile.
May 26 2023, 8:22 PM
ashoat closed D8004: [native] Introduce AvatarSelection screen.
May 26 2023, 7:59 PM
ashoat closed D8003: [native] Prevent CoolOrNerdModeSelection emojis from rendering with opacity on Android.
May 26 2023, 7:59 PM
ashoat committed rCOMM46c4f8098ad7: [native] Introduce AvatarSelection screen.
May 26 2023, 7:59 PM
ashoat committed rCOMM98a1caa65c72: [native] Prevent CoolOrNerdModeSelection emojis from rendering with opacity on….
May 26 2023, 7:59 PM
ashoat closed D8002: [native] Add password autofill support to PasswordSelection.
May 26 2023, 7:59 PM
ashoat committed rCOMM0c853385763b: [native] Add password autofill support to PasswordSelection.
May 26 2023, 7:59 PM
ashoat requested review of D8004: [native] Introduce AvatarSelection screen.
May 26 2023, 7:37 PM
ashoat requested review of D8003: [native] Prevent CoolOrNerdModeSelection emojis from rendering with opacity on Android.
May 26 2023, 7:14 PM
ashoat requested review of D8002: [native] Add password autofill support to PasswordSelection.
May 26 2023, 7:11 PM
ashoat closed D8001: [native] Set RegistrationTextInput keyboardAppearance based on theme.
May 26 2023, 5:59 PM
ashoat committed rCOMMe80f9ddc2a62: [native] Set RegistrationTextInput keyboardAppearance based on theme.
May 26 2023, 5:59 PM
ashoat closed D8000: [native] Delay PasswordSelection autoFocus on Android.
May 26 2023, 5:59 PM
ashoat committed rCOMMa43b0f2ea47b: [native] Delay PasswordSelection autoFocus on Android.
May 26 2023, 5:59 PM
ashoat updated the diff for D8000: [native] Delay PasswordSelection autoFocus on Android.

Comment

May 26 2023, 5:46 PM
ashoat accepted D7997: [lib] Remove unused 3rd-party base64 lib.
May 26 2023, 5:34 PM
ashoat accepted D7991: [native] Add `CommunityCreationKeyserverLabel` to `CommunityCreationMembers`.
May 26 2023, 5:30 PM
ashoat accepted D7988: [native] Pull `CommunityCreationKeyserverLabel` out of `CommunityConfiguration`.
May 26 2023, 5:30 PM
ashoat accepted D7987: [native] Introduce placeholder `CommunityCreationMembers` component.
May 26 2023, 5:29 PM
ashoat added a comment to D7981: [web] Don't hide pinned messages on reload.

What happens on a refresh? Wondering if the results get "replaced" after the load is complete, or if they get "merged"

May 26 2023, 5:29 PM
ashoat accepted D7980: [native] Display error message when community creation fails.
May 26 2023, 5:26 PM
ashoat accepted D7979: [native] Show spinner when community creation request is in progress.
May 26 2023, 5:25 PM
ashoat accepted D7978: [native] Hit `new_thread` endpoint in `CommunityConfiguration`.
May 26 2023, 5:24 PM
ashoat requested changes to D7874: Encrypt Android notifications on the keyserver before sending them.

Taking over for @tomek on the review, since he is on vacation now. Thought about his feedback and have a proposed approach – @marcin, what do you think?

May 26 2023, 3:59 PM
ashoat added inline comments to D7957: [web] Create a modal where invite link can be accepted.
May 26 2023, 3:53 PM
ashoat added a comment to D7974: [native] Implement BlobUtils expo-module on Android.

Lack of syntax highlighting for Kotlin was annoying... solved it with this. Let me know if any other languages have similar problems

May 26 2023, 3:51 PM
ashoat requested review of D8001: [native] Set RegistrationTextInput keyboardAppearance based on theme.
May 26 2023, 3:18 PM
First
Prev
Next