@marcin, quick question – did you observe similar issues (delays to notification grouping) with other apps (eg. Signal) on the Realme GT 2 with ColorOS addition?
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jun 15 2023
Jun 15 2023
ashoat added inline comments to D8103: Implement message typoes validator and import it in root.react.js for side effect.
ashoat requested changes to D8200: [keyserver] Prevent the only admin role from being changed on the keyserver.
Jun 14 2023
Jun 14 2023
ashoat updated the diff for D8194: [native] Update KeyserverSelection to take URL instead of username as input.
Oops, updated the wrong diff
In D8198#242231, @ginsu wrote:Probably outside the scope of this diff, but might be worth to consider disabling auto correct on the Enter a keyserver RegistrationTextInput in a follow up diff. Would avoid the situation in the demo video where "localhost" => "local host" and I think if people had unique keyserver names in the future, autocorrect here could be annoying in the user experience
I don't have context on future uses for this endpoint, but will we have to worry about scenarios where user-deployed "malicious" keyservers could potentially "lie" about their version?
Jun 13 2023
Jun 13 2023
ashoat requested review of D8197: [native] Set urlPrefix in Redux following successful registration.
ashoat requested review of D8196: [native] Part 2: use user's keyserver selection in registration flow.
ashoat requested review of D8195: [native] Part 1: use user's keyserver selection in registration flow.
ashoat requested review of D8194: [native] Update KeyserverSelection to take URL instead of username as input.
Jun 12 2023
Jun 12 2023
New package looks good! Resigning so that one of the other reviews can take a look at the Rust
Jun 9 2023
Jun 9 2023
Increase comm-swoosh.png resolution
purpleLink instead of purpleButton
Realized useFocusEffect doesn't work because there are two other auxiliary screens we use for setting avatars. Reworked it to enable registrationMode while any of the 3 relevant screens are in focus
ashoat abandoned D8151: [native] Don't show loading spinner during avatar server call in registration screen.
Following D8163, we no longer do the server call from AvatarSelection, so this diff is no longer necessary
ashoat added inline comments to D8160: [native] Create a ChangeRolesHeaderRightButton to save role changes.
Makes sense. To address replay attacks we should definitely make sure that the signature has a recent timestamp
Jun 8 2023
Jun 8 2023
ashoat requested review of D8154: [native] Add cached user selection state into RegistrationContext.
ashoat requested review of D8149: [native] Introduce code to call keyserver for registration in new flow.
ashoat requested review of D8150: [native] Make callback param optional in useUploadSelectedMedia avatar hook.
ashoat added inline comments to D8067: [web] Refactor the members modal to support any variety of role labels.
Jun 7 2023
Jun 7 2023
ashoat added inline comments to D8140: [web] Add functionality on save to actually change a member's role.