Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Jul 18 2023

• jon accepted D8533: [keyserver] rename napi add_reserved_usernames function.

Jul 18 2023, 2:01 PM

Jul 17 2023

• jon abandoned D8052: [Keyserver] Use olm identity key for tunnelbroker connection.

squashed this into D7691 because of rebase work

Jul 17 2023, 7:25 AM

• jon abandoned D7702: [Keyserver] Introduce tunnelbroker types.

squashed this into D7691 because of rebase work

Jul 17 2023, 7:25 AM

• jon accepted D8520: Modify NIX and keyserver configuration files to allow node version >= 18.

LGTM if we just want node>=18 (as mentioned in summary)

Jul 17 2023, 7:23 AM

• jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Squash initial session commits into one

Jul 17 2023, 7:23 AM

Jul 16 2023

• jon closed D8405: [Keyserver] Attempt login to identity service.

Jul 16 2023, 7:40 PM

• jon committed rCOMM5092f6ecd961: [Keyserver] Attempt login to identity service (authored by • jon).

[Keyserver] Attempt login to identity service

Jul 16 2023, 7:39 PM

• jon closed D8404: [Keyserver/rust] Remove legacy auth_token configuration.

Jul 16 2023, 7:39 PM

• jon closed D8403: [Keyserver/rust] Enable logging of rust addon.

Jul 16 2023, 7:39 PM

• jon committed rCOMM0955edc89f9b: [Keyserver/rust] Remove legacy auth_token configuration (authored by • jon).

[Keyserver/rust] Remove legacy auth_token configuration

Jul 16 2023, 7:39 PM

• jon committed rCOMM2961e68cfce7: [Keyserver/rust] Enable logging of rust addon (authored by • jon).

[Keyserver/rust] Enable logging of rust addon

Jul 16 2023, 7:39 PM

• jon closed D8401: [Identity] Allow for setting logging levels through env.

Jul 16 2023, 7:39 PM

• jon closed D8402: [Identity] Fix opaque login.

Jul 16 2023, 7:39 PM

• jon committed rCOMM57cf5dbdec07: [Identity] Allow for setting logging levels through env (authored by • jon).

[Identity] Allow for setting logging levels through env

Jul 16 2023, 7:39 PM

• jon committed rCOMM6dc2a953186c: [Identity] Fix opaque login (authored by • jon).

[Identity] Fix opaque login

Jul 16 2023, 7:39 PM

• jon closed D8400: [Keyserver] Apply DB Migrations.

Jul 16 2023, 7:39 PM

• jon committed rCOMM06a3b6b3ff76: [Keyserver] Apply DB Migrations (authored by • jon).

[Keyserver] Apply DB Migrations

Jul 16 2023, 7:39 PM

• jon updated the diff for D8405: [Keyserver] Attempt login to identity service.

Rebase on master

Jul 16 2023, 7:15 PM

• jon updated the diff for D8404: [Keyserver/rust] Remove legacy auth_token configuration.

Rebase on master

Jul 16 2023, 7:14 PM

• jon updated the diff for D8403: [Keyserver/rust] Enable logging of rust addon.

Rebase on master

Jul 16 2023, 7:14 PM

• jon updated the diff for D8402: [Identity] Fix opaque login.

Rebase on master

Jul 16 2023, 7:14 PM

• jon updated the diff for D8401: [Identity] Allow for setting logging levels through env.

Rebase on master

Jul 16 2023, 7:13 PM

• jon updated the diff for D8400: [Keyserver] Apply DB Migrations.

Rebase on master

Jul 16 2023, 7:13 PM

• jon added inline comments to D8402: [Identity] Fix opaque login.

Jul 16 2023, 7:07 PM

• jon updated the diff for D8402: [Identity] Fix opaque login.

Remove unused import

Jul 16 2023, 7:05 PM

Jul 14 2023

• jon updated the diff for D8475: [Keyserver] Refactor identity utilities.

Remove extra async

Jul 14 2023, 3:37 PM

• jon added inline comments to D8475: [Keyserver] Refactor identity utilities.

Jul 14 2023, 3:33 PM

• jon updated the diff for D8405: [Keyserver] Attempt login to identity service.

remove extra async keyword

Jul 14 2023, 3:28 PM

• jon added inline comments to D8400: [Keyserver] Apply DB Migrations.

Jul 14 2023, 3:25 PM

• jon updated the diff for D8400: [Keyserver] Apply DB Migrations.

Fix whitespace

Jul 14 2023, 3:24 PM

• jon accepted D8500: [identity] helper functions for removing data from DDB.

Jul 14 2023, 3:12 PM

• jon accepted D8469: [CI] Buildkite for web emscripten build.

Jul 14 2023, 3:11 PM

Jul 13 2023

• jon updated the diff for D8473: [Keyserver/rust] Add publish_prekeys implementation.

Improve error handling

Jul 13 2023, 2:48 PM

• jon added inline comments to D8473: [Keyserver/rust] Add publish_prekeys implementation.

Jul 13 2023, 2:09 PM

• jon updated the diff for D8473: [Keyserver/rust] Add publish_prekeys implementation.

Address feedback, refactor auth client into self-contained module

Jul 13 2023, 2:09 PM

• jon added inline comments to D8464: [Identity] Implement RefreshUserPreKey.

Jul 13 2023, 10:19 AM

• jon updated the diff for D8464: [Identity] Implement RefreshUserPreKey.

Address feedback

Jul 13 2023, 10:19 AM

• jon added inline comments to D8463: [Services-test/identity] Refactor create_device.

Jul 13 2023, 10:05 AM

• jon updated the diff for D8434: [Identity] Add authenticated gRPC service.

Address feedback

Jul 13 2023, 10:05 AM

• jon added inline comments to D8434: [Identity] Add authenticated gRPC service.

Jul 13 2023, 10:05 AM

• jon added inline comments to D8405: [Keyserver] Attempt login to identity service.

Jul 13 2023, 9:45 AM

• jon updated the diff for D8405: [Keyserver] Attempt login to identity service.

Address feedback

Jul 13 2023, 9:45 AM

• jon added inline comments to D8401: [Identity] Allow for setting logging levels through env.

Jul 13 2023, 9:17 AM

• jon updated the diff for D8401: [Identity] Allow for setting logging levels through env.

Address feedback, fix parent diff

Jul 13 2023, 9:17 AM

• jon updated the diff for D8400: [Keyserver] Apply DB Migrations.

Address feedback

Jul 13 2023, 9:14 AM

Jul 11 2023

• jon added inline comments to D8405: [Keyserver] Attempt login to identity service.

Jul 11 2023, 11:12 AM

• jon updated the diff for D8473: [Keyserver/rust] Add publish_prekeys implementation.

Fix accidental rebase error

Jul 11 2023, 11:00 AM

• jon updated the diff for D8476: [Keyserver] Publish prekeys to identity service for cron job.

Rebase on other work

Jul 11 2023, 10:55 AM

• jon updated the diff for D8473: [Keyserver/rust] Add publish_prekeys implementation.

Rebase on other work

Jul 11 2023, 10:54 AM

• jon updated the diff for D8405: [Keyserver] Attempt login to identity service.

Address feedback

Jul 11 2023, 10:53 AM

• jon added a comment to D8402: [Identity] Fix opaque login.

Continuing on :)

Jul 11 2023, 10:44 AM

• jon added a comment to D8400: [Keyserver] Apply DB Migrations.

I think we'll need this check for new setups as well.

Jul 11 2023, 10:43 AM

• jon updated the diff for D8400: [Keyserver] Apply DB Migrations.

Address feedback

Jul 11 2023, 10:42 AM

• jon requested review of D8475: [Keyserver] Refactor identity utilities.

Jul 11 2023, 10:29 AM

• jon requested review of D8476: [Keyserver] Publish prekeys to identity service for cron job.

Jul 11 2023, 10:26 AM

• jon requested review of D8474: [Keyserver] Refactor prekey lifecycle logic.

Jul 11 2023, 10:18 AM

• jon requested review of D8473: [Keyserver/rust] Add publish_prekeys implementation.

Jul 11 2023, 10:13 AM

• jon accepted D8390: [shell] script to generate WASM database code.

Jul 11 2023, 9:59 AM

• jon accepted D8446: [Nix] Explicitly set emscripten cache.

Jul 11 2023, 8:51 AM

Jul 10 2023

• jon resigned from D8455: [blob-service] Implement upload logic with new db.

rust LGTM, would like for someone else to take a look

Jul 10 2023, 6:21 PM

• jon resigned from D8459: [blob-service] Delete old database code from http module.

rust LGTM, would like for someone else to take a look

Jul 10 2023, 6:20 PM

• jon resigned from D8458: [blob-service] Call service methods from handlers.

rust LGTM, would like for someone else to take a look

Jul 10 2023, 6:20 PM

• jon resigned from D8457: [blob-service] Support new abstraction in HTTP.

rust LGTM, would like for someone else to take a look

Jul 10 2023, 6:18 PM

• jon resigned from D8456: [blob-service] Implement holder management with new db.

rust LGTM, would like for someone else to take a look

Jul 10 2023, 6:18 PM

• jon resigned from D8454: [blob-service] Implement download logic with new db.

rust LGTM, would like for someone else to take a look

Jul 10 2023, 6:17 PM

• jon resigned from D8453: [blob-service] Create business logic abstraction.

rust LGTM, would like for someone else to take a look

Jul 10 2023, 6:07 PM

• jon resigned from D8452: [blob-service] DB: Add remaining client methods.

rust LGTM, would like for someone else to take a look

Jul 10 2023, 5:35 PM

• jon requested review of D8468: [Docs/nix] Document how to update flake and push artifacts.

Jul 10 2023, 3:14 PM

• jon resigned from D8451: [blob-service] DB: Add holder management methods.

Rust looks fine to me, but would like other to take a look

Jul 10 2023, 11:11 AM

• jon resigned from D8450: [blob-service] Introduce database client.

going to resign as I would like some of the others to review as well

Jul 10 2023, 10:45 AM

• jon accepted D8450: [blob-service] Introduce database client.

otherwise the rest of the rust stuff looks fine to me.

Jul 10 2023, 10:45 AM

• jon accepted D8447: [identity] hard-code the platform type for the identity docker image.

Jul 10 2023, 8:48 AM

• jon updated the diff for D8434: [Identity] Add authenticated gRPC service.

Update parent diff

Jul 10 2023, 7:38 AM

• jon closed D8312: [Docs] Document how to build and deploy tunnelbroker.

Jul 10 2023, 7:31 AM

• jon committed rCOMM64b6154ef565: [Docs] Document how to build and deploy tunnelbroker (authored by • jon).

[Docs] Document how to build and deploy tunnelbroker

Jul 10 2023, 7:31 AM

• jon requested review of D8464: [Identity] Implement RefreshUserPreKey.

Jul 10 2023, 6:56 AM

• jon requested review of D8463: [Services-test/identity] Refactor create_device.

Jul 10 2023, 6:51 AM

• jon requested review of D8434: [Identity] Add authenticated gRPC service.

Jul 10 2023, 6:42 AM

Jul 7 2023

• jon requested review of D8446: [Nix] Explicitly set emscripten cache.

Jul 7 2023, 12:16 PM

• jon requested changes to D8390: [shell] script to generate WASM database code.

Jul 7 2023, 11:56 AM

Jul 6 2023

• jon added inline comments to D8400: [Keyserver] Apply DB Migrations.

Jul 6 2023, 4:00 PM

• jon updated the diff for D8400: [Keyserver] Apply DB Migrations.

Address feedback

Jul 6 2023, 3:57 PM

• jon updated the diff for D8312: [Docs] Document how to build and deploy tunnelbroker.

ran -> run

Jul 6 2023, 3:43 PM

• jon closed D8326: [Docs] Mention Chrome needs to be restarted.

Jul 6 2023, 3:41 PM

• jon committed rCOMM8d63c6591600: [Docs] Mention Chrome needs to be restarted (authored by • jon).

[Docs] Mention Chrome needs to be restarted

Jul 6 2023, 3:41 PM

• jon accepted D8390: [shell] script to generate WASM database code.

Bash LGTM

Jul 6 2023, 3:40 PM

• jon added 1 blocking reviewer(s) for D8402: [Identity] Fix opaque login: bartek.

Jul 6 2023, 11:33 AM

• jon added a comment to D8402: [Identity] Fix opaque login.

should we just change the index projection to INCLUDE or ALL?

Jul 6 2023, 11:33 AM

• jon updated the diff for D8405: [Keyserver] Attempt login to identity service.

Address feedback

Jul 6 2023, 10:59 AM

• jon updated the diff for D8402: [Identity] Fix opaque login.

Address feedback

Jul 6 2023, 10:26 AM

• jon closed D8399: [Keyserver/rust] Ignore debug version of napi build.

Jul 6 2023, 10:22 AM

• jon closed D8366: [Keyserver/rust] Add device login and register.

Jul 6 2023, 10:22 AM

• jon committed rCOMM47e3232b9532: [Keyserver/rust] Ignore debug version of napi build (authored by • jon).

[Keyserver/rust] Ignore debug version of napi build

Jul 6 2023, 10:22 AM

• jon committed rCOMMaf11c5973624: [Keyserver/rust] Add device login and register (authored by • jon).

[Keyserver/rust] Add device login and register

Jul 6 2023, 10:22 AM

• jon closed D8365: [Keyserver] Remove legacy tunnelbroker types.

Jul 6 2023, 10:22 AM

• jon committed rCOMMea1ac74c0ee1: [Keyserver] Remove legacy tunnelbroker types (authored by • jon).

[Keyserver] Remove legacy tunnelbroker types

Jul 6 2023, 10:22 AM

• jon updated the summary of D8401: [Identity] Allow for setting logging levels through env.

Jul 6 2023, 10:21 AM

• jon updated the diff for D8401: [Identity] Allow for setting logging levels through env.

Address feedback

Jul 6 2023, 10:17 AM

• jon updated the diff for D8400: [Keyserver] Apply DB Migrations.

Rebase, address feedback

Jul 6 2023, 10:11 AM

• jon added a comment to D8400: [Keyserver] Apply DB Migrations.

Is there anybody else you can ask to help with review? Best to avoid having me as a solo reviewer. I've been getting pulled into a ton of diff reviews lately (more than before) and my time for them is very limited..

Jul 6 2023, 10:08 AM