Add a constant, fix lockfile
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Dec 20 2023
Dec 19 2023
Rebase
Rebase
Dec 18 2023
Add the whole native/facts to .gitignore, improve error messages
In D10260#299000, @varun wrote:sorry for the delay. accepting, but with a question: how are we setting the CA Certificate against which to verify the server’s TLS certificate?
Dec 14 2023
Dec 13 2023
Dec 12 2023
Rebase
Rebase
Using @atul suggestion from ENG-5556, I just added pkg-config to buildkite android config. I couldn't figure out a better solution...
It's also used in keyserver/scripts/generate-converter-from-validator.js, which I think is a one-off script and doesn't need to be updated CC @michal
Try installing pkg-config on the CI runner
Dec 11 2023
Keys are sorted lexicographically
Dec 8 2023
Remove GlobalDBSingleton, make the code sync.
wondering if we should also update the type to avoid things like this
Dec 7 2023
I will be extending this to handle backup service in the near future, do you think we should have a separate configuration json file per service?
Dec 6 2023
docker inspect commapp/electron-update-server:2.0 -f "{{.Os}}/{{.Architecture}}"
Dec 5 2023
Much better with the naming change
Dec 4 2023
Could you also quickly test if everything works if someone is using an older version of the desktop app, one that doesn't advertise its version (you can just comment out the desktop version line in registerConfig)?
You can just run yarn dev and open the hosted website on http://localhost:80. I checked your typo fix and the website correctly shows our repository and displays the newest desktop version (9).
Dec 1 2023
Fix mistake during rebase
Rebase
Nov 29 2023
I'm starting to consider the global static CONFIG as an anti-pattern.
Nov 28 2023
Remove cryptoThread from restore function and return restored olm account information.
Overall LGTM, just a few questions
There are a few issues with this (but they should be easily fixable):
- You are registering a callback on ipcMain everytime a window is loaded. This wouldn't be a problem in Windows but on macOS you can close the window without closing the app. Then if you would open a window again you would register another callback.
- The callbacks themselves use the main window variable which will stop being valid after the window is closed. So the previously registered callbacks will probably throw an error after re-opening the window.
Nov 27 2023
Update for flow 202