Page MenuHomePhabricator
Feed Advanced Search

Dec 20 2023

michal added inline comments to D10405: [comm-lib] Function for calculating dynamodb item size.
Dec 20 2023, 1:23 AM

Dec 19 2023

michal requested review of D10406: [backup] Update LogItem struct.
Dec 19 2023, 8:43 AM
michal requested review of D10405: [comm-lib] Function for calculating dynamodb item size.
Dec 19 2023, 8:02 AM
michal updated the diff for D10260: [commtest] Move backup client to shared.

Add a constant, fix lockfile

Dec 19 2023, 7:22 AM
michal requested review of D10401: [comm-lib] Add BlobInfo::from_bytes.
Dec 19 2023, 7:11 AM
michal requested review of D10402: [report service] Move ReportContent to lib.
Dec 19 2023, 7:01 AM
michal updated the diff for D10256: [service] Move services lib to shared.

Rebase

Dec 19 2023, 5:47 AM
michal updated the diff for D9926: [native] Expose SecureStore to Rust.

Rebase

Dec 19 2023, 5:36 AM
michal updated the diff for D9923: [native] Make SecureStore methods static.

Rebase

Dec 19 2023, 5:29 AM
michal updated the test plan for D9923: [native] Make SecureStore methods static.
Dec 19 2023, 5:27 AM

Dec 18 2023

michal accepted D10366: [services] update `Cargo.lock` files.
Dec 18 2023, 5:07 AM
michal requested changes to D10306: [web] avoid race condition while deleting database.
Dec 18 2023, 3:14 AM
michal requested review of D10263: [native-rust-library] Add backup client dependency.
Dec 18 2023, 2:57 AM
michal updated the diff for D10261: [native-rust-library] Backup service config.

Add the whole native/facts to .gitignore, improve error messages

Dec 18 2023, 2:34 AM
michal added a comment to D10260: [commtest] Move backup client to shared.

sorry for the delay. accepting, but with a question: how are we setting the CA Certificate against which to verify the server’s TLS certificate?

Dec 18 2023, 2:18 AM
michal added inline comments to D10258: [comm-lib] Hide aws behind a feature flag.
Dec 18 2023, 2:07 AM

Dec 14 2023

michal accepted D10245: Suffix web olm notifs session with cookieID to avoid race condition during multiple simultaneous log-in processes..
Dec 14 2023, 7:55 AM
michal requested changes to D10306: [web] avoid race condition while deleting database.
Dec 14 2023, 7:49 AM

Dec 13 2023

michal accepted D10218: [identity] Add function to check if device exists.
Dec 13 2023, 4:08 AM

Dec 12 2023

michal requested review of D10309: [web/native/lib] Combine openSocketSelector from web and native.
Dec 12 2023, 4:09 AM
michal updated the diff for D10265: [native/lib] Cleanup existing JS backup code.

Rebase

Dec 12 2023, 3:54 AM
michal updated the diff for D10264: [native-rust-library] Upload/download user backup.

Rebase

Dec 12 2023, 3:53 AM
michal updated the diff for D10263: [native-rust-library] Add backup client dependency.

Using @atul suggestion from ENG-5556, I just added pkg-config to buildkite android config. I couldn't figure out a better solution...

Dec 12 2023, 3:52 AM
michal added a comment to D10294: [lib][keyserver] Replace `legacyRawThreadInfoValidator` with `rawThreadInfoValidator`.

It's also used in keyserver/scripts/generate-converter-from-validator.js, which I think is a one-off script and doesn't need to be updated CC @michal

Dec 12 2023, 3:11 AM
michal planned changes to D10263: [native-rust-library] Add backup client dependency.
Dec 12 2023, 3:02 AM
michal updated the diff for D10263: [native-rust-library] Add backup client dependency.

Try installing pkg-config on the CI runner

Dec 12 2023, 3:01 AM
michal requested review of D10265: [native/lib] Cleanup existing JS backup code.
Dec 12 2023, 2:12 AM
michal requested review of D10264: [native-rust-library] Upload/download user backup.
Dec 12 2023, 2:12 AM

Dec 11 2023

michal planned changes to D10263: [native-rust-library] Add backup client dependency.
Dec 11 2023, 9:11 AM
michal requested review of D10263: [native-rust-library] Add backup client dependency.
Dec 11 2023, 9:10 AM
michal accepted D10289: [lib] Remove unnecessary code.
Dec 11 2023, 3:31 AM
michal requested changes to D10245: Suffix web olm notifs session with cookieID to avoid race condition during multiple simultaneous log-in processes..

Keys are sorted lexicographically

Dec 11 2023, 3:13 AM

Dec 8 2023

michal requested review of D10261: [native-rust-library] Backup service config.
Dec 8 2023, 9:03 AM
michal requested review of D10260: [commtest] Move backup client to shared.
Dec 8 2023, 8:54 AM
michal requested review of D10258: [comm-lib] Hide aws behind a feature flag.
Dec 8 2023, 8:27 AM
michal requested review of D10257: [services] Fix warnings.
Dec 8 2023, 8:22 AM
michal requested review of D10256: [service] Move services lib to shared.
Dec 8 2023, 7:50 AM
michal updated the summary of D9926: [native] Expose SecureStore to Rust.
Dec 8 2023, 6:38 AM
michal updated the diff for D9926: [native] Expose SecureStore to Rust.

Remove GlobalDBSingleton, make the code sync.

Dec 8 2023, 6:36 AM
michal accepted D10222: [web] add missing `userID` param.

wondering if we should also update the type to avoid things like this

Dec 8 2023, 3:23 AM
michal accepted D10219: [identity] Implement transactional device list updates.
Dec 8 2023, 2:50 AM
michal added inline comments to D10216: identity] Add function to get current device list timestamp.
Dec 8 2023, 1:44 AM

Dec 7 2023

michal accepted D10187: [native] use build configuration to set socket addr.

I will be extending this to handle backup service in the near future, do you think we should have a separate configuration json file per service?

Dec 7 2023, 2:03 AM

Dec 6 2023

michal accepted D10194: Encrypt notifications for Windows users with code version high enough to support this feature.
Dec 6 2023, 4:20 AM
michal accepted D10193: Implement API to encrypt Windows notifications.
Dec 6 2023, 3:58 AM
michal added a comment to D10196: [electron-update-server] Specify platform in docker compose.

docker inspect commapp/electron-update-server:2.0 -f "{{.Os}}/{{.Architecture}}"

Dec 6 2023, 3:26 AM
michal accepted D10199: [desktop] Enable unused-promise=error Flow lint.
Dec 6 2023, 1:40 AM

Dec 5 2023

michal requested review of D10196: [electron-update-server] Specify platform in docker compose.
Dec 5 2023, 8:57 AM
michal accepted D10188: Put collapse key in encrypted MacOS notification payload.

Much better with the naming change

Dec 5 2023, 6:43 AM
michal accepted D10184: Add unused-promise Lint to all Flow configs except desktop.
Dec 5 2023, 6:10 AM
michal accepted D10183: [keyserver] Ignore promise rejections from websocket message handler.
Dec 5 2023, 6:09 AM
michal accepted D10182: [keyserver] Ignore promise rejections from state check mechanism.
Dec 5 2023, 6:07 AM
michal accepted D10181: [keyserver] await dbQuery in updateLatestMessages.
Dec 5 2023, 6:05 AM
michal accepted D10180: [keyserver] await file operations for devs in MariaDB migrations.
Dec 5 2023, 5:59 AM
michal accepted D10179: [keyserver] Ignore potential to crash on promise rejections in keyserver preamble.
Dec 5 2023, 5:58 AM
michal accepted D10178: [keyserver] Silence unused-promise Flow lint in backupDB.
Dec 5 2023, 5:53 AM
michal added inline comments to D10177: [keyserver] Ignore potential to crash on promise rejections in scripts.
Dec 5 2023, 5:50 AM
michal accepted D10192: Pass majorDesktopVersion to platformDetails when creating macos badgeonly notifications..
Dec 5 2023, 5:46 AM
michal accepted D10176: [lib][native][web][landing] Silence unused-promise using void keyword.
Dec 5 2023, 5:44 AM
michal accepted D10173: [native] Return inputState.sendMultimediaMessage Promise directly in ChatCameraModal.
Dec 5 2023, 2:58 AM
michal accepted D10171: [native] await sendMultimediaMessage in KeyboardInputHost.onMediaGalleryItemSelected.
Dec 5 2023, 2:56 AM
michal accepted D10170: [native] Don't make Crash.onPressWipe an async function.
Dec 5 2023, 2:55 AM
michal accepted D10169: [native] Add some awaits in ChatInputBar.onSend.
Dec 5 2023, 2:55 AM
michal accepted D10165: [web] Updates to push notif service worker for unused-promise Flow lint.
Dec 5 2023, 2:52 AM
michal accepted D10162: [web] Hide that InputState.sendTextMessage returns a Promise.
Dec 5 2023, 1:52 AM
michal accepted D10161: [lib] Wrap spinPromises in ignorePromiseRejections.
Dec 5 2023, 1:41 AM
michal accepted D10160: [lib] Don't return a promise from ignorePromiseRejections.
Dec 5 2023, 1:40 AM
michal accepted D10158: [keyserver][lib] handleAsyncPromise -> ignorePromiseRejections.
Dec 5 2023, 1:40 AM
michal accepted D10155: Add some stuff to .prettierignore.
Dec 5 2023, 1:37 AM

Dec 4 2023

michal accepted D10151: Read desktop code version during socket connection creation.

Could you also quickly test if everything works if someone is using an older version of the desktop app, one that doesn't advertise its version (you can just comment out the desktop version line in registerConfig)?

Dec 4 2023, 6:20 AM
michal accepted D10143: [electron-update-server] Fix minor typo.

You can just run yarn dev and open the hosted website on http://localhost:80. I checked your typo fix and the website correctly shows our repository and displays the newest desktop version (9).

Dec 4 2023, 2:16 AM

Dec 1 2023

michal accepted D10130: [blob][backup] Remove unused build dependency.
Dec 1 2023, 7:10 AM
michal accepted D9762: [reports-service] Increase RAM and JSON payload size.
Dec 1 2023, 6:10 AM
michal accepted D10096: [lib][web][native] Refactor invalidSessionDowngrade for setNewSessionActionType.
Dec 1 2023, 6:08 AM
michal updated the diff for D9932: [native] Introduce Rust encryption functions.

Fix mistake during rebase

Dec 1 2023, 5:55 AM
michal updated the diff for D10067: [native] Backup testing button.

Rebase

Dec 1 2023, 4:21 AM
michal updated the diff for D10054: [native] Implement native backup.

Rebase

Dec 1 2023, 3:35 AM
michal updated the diff for D9932: [native] Introduce Rust encryption functions.

Rebase

Dec 1 2023, 3:34 AM

Nov 29 2023

michal added inline comments to D10054: [native] Implement native backup.
Nov 29 2023, 7:15 AM
michal accepted D10070: [web/lib/keyserver] avoid out of sync `updatesCurrentAsOf` between client and keyserver.
Nov 29 2023, 5:19 AM
michal accepted D9058: [Identity] Use clap for argument parsing.

I'm starting to consider the global static CONFIG as an anti-pattern.

Nov 29 2023, 4:56 AM
michal accepted D10087: [flow] Convert all remaining Shape to $Partial.
Nov 29 2023, 4:26 AM
michal accepted D10085: [flow] Convert all remaining $Shape to $Partial.
Nov 29 2023, 4:18 AM
michal accepted D10084: [native] Add type params to setStateForContainer invocation in setRegisterState.
Nov 29 2023, 4:17 AM
michal accepted D10082: [lib] Make registerConfig take full Config instead of $Shape<Config>.
Nov 29 2023, 4:04 AM

Nov 28 2023

michal added inline comments to D10055: [native] Increase the number of threads available for rust.
Nov 28 2023, 9:07 AM
michal requested review of D10067: [native] Backup testing button.
Nov 28 2023, 7:46 AM
michal added inline comments to D9926: [native] Expose SecureStore to Rust.
Nov 28 2023, 7:31 AM
michal updated the diff for D10054: [native] Implement native backup.

Remove cryptoThread from restore function and return restored olm account information.

Nov 28 2023, 6:54 AM
michal accepted D9973: Expose major version of desktop code to the keyserver.
Nov 28 2023, 6:38 AM
michal accepted D9970: Fix MacOS app loosing device token in undeterministic manner.
Nov 28 2023, 6:38 AM
michal accepted D10057: Encrypt notifications for MacOS clients with code versions supporting notification decryption.
Nov 28 2023, 6:38 AM
michal added inline comments to D10054: [native] Implement native backup.
Nov 28 2023, 5:25 AM
michal requested review of D10055: [native] Increase the number of threads available for rust.
Nov 28 2023, 3:37 AM
michal added inline comments to D9973: Expose major version of desktop code to the keyserver.
Nov 28 2023, 3:25 AM
michal added a comment to D10057: Encrypt notifications for MacOS clients with code versions supporting notification decryption.

Overall LGTM, just a few questions

Nov 28 2023, 2:44 AM
michal accepted D10056: Rename IOS to APNs in function responsible for notifications encryption.
Nov 28 2023, 2:19 AM
michal requested changes to D9973: Expose major version of desktop code to the keyserver.
Nov 28 2023, 2:19 AM
michal requested changes to D9970: Fix MacOS app loosing device token in undeterministic manner.

There are a few issues with this (but they should be easily fixable):

  1. You are registering a callback on ipcMain everytime a window is loaded. This wouldn't be a problem in Windows but on macOS you can close the window without closing the app. Then if you would open a window again you would register another callback.
  2. The callbacks themselves use the main window variable which will stop being valid after the window is closed. So the previously registered callbacks will probably throw an error after re-opening the window.
Nov 28 2023, 2:05 AM

Nov 27 2023

michal updated the diff for D9452: [keyserver] Separate webapp and keyserver endpoints.

Update for flow 202

Nov 27 2023, 6:57 AM