Page MenuHomePhabricator
Feed Advanced Search

Feb 14 2024

tomek closed D10134: [keyserver] Create a blob while adding / editing an invite link.
Feb 14 2024, 7:58 AM
tomek committed rCOMM4d6183505a6d: [keyserver] Create a blob while adding / editing an invite link (authored by tomek).
[keyserver] Create a blob while adding / editing an invite link
Feb 14 2024, 7:58 AM
tomek closed D10131: [keyserver] Change blob upload functions to return more usable results.
Feb 14 2024, 7:58 AM
tomek committed rCOMM48441ea35eca: [keyserver] Change blob upload functions to return more usable results (authored by tomek).
[keyserver] Change blob upload functions to return more usable results
Feb 14 2024, 7:58 AM
tomek closed D10099: [keyserver] Introduce a util function that generates invite link blob hash.
Feb 14 2024, 7:58 AM
tomek closed D10098: [keyserver] Modify blob functions so that they take params object where both hash and holder are provided.
Feb 14 2024, 7:58 AM
tomek committed rCOMM49dacaa80f96: [keyserver] Introduce a util function that generates invite link blob hash (authored by tomek).
[keyserver] Introduce a util function that generates invite link blob hash
Feb 14 2024, 7:58 AM
tomek committed rCOMM619eea4efb61: [keyserver] Modify blob functions so that they take params object where both… (authored by tomek).
[keyserver] Modify blob functions so that they take params object where both…
Feb 14 2024, 7:58 AM
tomek closed D9972: [keyserver] Delete a holder after deleting a blob.
Feb 14 2024, 7:58 AM
tomek closed D9968: [keyserver] Fetch invite link blob holder.
Feb 14 2024, 7:58 AM
tomek committed rCOMM80a608e1b045: [keyserver] Delete a holder after deleting a blob (authored by tomek).
[keyserver] Delete a holder after deleting a blob
Feb 14 2024, 7:58 AM
tomek committed rCOMMf2fb42fd31c9: [keyserver] Fetch invite link blob holder (authored by tomek).
[keyserver] Fetch invite link blob holder
Feb 14 2024, 7:58 AM
tomek closed D9966: [keyserver] Add a function that deletes a blob.
Feb 14 2024, 7:58 AM
tomek committed rCOMM7053a0f8c5be: [keyserver] Add a function that deletes a blob (authored by tomek).
[keyserver] Add a function that deletes a blob
Feb 14 2024, 7:58 AM
tomek closed D9944: [keyserver] Block creating invite links for which an entry in Blob service already exists.
Feb 14 2024, 7:58 AM
tomek committed rCOMM649591495a52: [keyserver] Block creating invite links for which an entry in Blob service… (authored by tomek).
[keyserver] Block creating invite links for which an entry in Blob service…
Feb 14 2024, 7:58 AM
tomek requested review of D11076: [keyserver] Create invite link blobs in a migration.
Feb 14 2024, 7:21 AM
tomek added inline comments to D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().
Feb 14 2024, 6:51 AM
tomek updated the diff for D11051: [services] Move reserved_usernames to `shared`.

Use const

Feb 14 2024, 6:34 AM
tomek added a comment to D10992: [lib] Join a community on an overridden keyserver.
In D10992#318515, @inka wrote:

This code is quite complex in the case you were not able to test - when we connect to a different keyserver, and even mo so when we connect to a couple of keyservers. I can see that it would be hard to test now, but it would be great if you could create a linear task describing how this should be tested once it's possible, and set it as blocked by appropriate tasks.

Feb 14 2024, 4:12 AM
tomek updated the diff for D10131: [keyserver] Change blob upload functions to return more usable results.

Rebase

Feb 14 2024, 3:46 AM
tomek updated the test plan for D9972: [keyserver] Delete a holder after deleting a blob.
Feb 14 2024, 3:45 AM

Feb 13 2024

tomek requested review of D11051: [services] Move reserved_usernames to `shared`.
Feb 13 2024, 6:58 AM
tomek added inline comments to D11015: [blob] Block reserved and offensive links from being created.
Feb 13 2024, 6:54 AM

Feb 12 2024

tomek updated the diff for D11015: [blob] Block reserved and offensive links from being created.

Revert unnecessary changes

Feb 12 2024, 8:23 AM
tomek planned changes to D11015: [blob] Block reserved and offensive links from being created.
Feb 12 2024, 7:44 AM
tomek added inline comments to D11015: [blob] Block reserved and offensive links from being created.
Feb 12 2024, 6:59 AM
tomek updated the diff for D11015: [blob] Block reserved and offensive links from being created.

Check regexes and refactor

Feb 12 2024, 6:57 AM
tomek added inline comments to D10993: [lib][web][native] Add configurable authoritativeKeyserverID.
Feb 12 2024, 6:15 AM
tomek added inline comments to D11015: [blob] Block reserved and offensive links from being created.
Feb 12 2024, 5:29 AM
tomek updated the diff for D10992: [lib] Join a community on an overridden keyserver.

Use join data

Feb 12 2024, 5:12 AM
tomek updated the diff for D10992: [lib] Join a community on an overridden keyserver.

Clear the timeout on unmount

Feb 12 2024, 5:05 AM
tomek updated the diff for D10992: [lib] Join a community on an overridden keyserver.

Clear the timeout on unmount

Feb 12 2024, 5:03 AM
tomek updated the diff for D10992: [lib] Join a community on an overridden keyserver.

Fix a couple of bugs

Feb 12 2024, 3:59 AM
tomek accepted D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 12 2024, 3:17 AM
tomek requested changes to D11022: [web] dispatch setAccessTokenActionType after successful identity login on web.
Feb 12 2024, 1:33 AM
tomek added inline comments to D10992: [lib] Join a community on an overridden keyserver.
Feb 12 2024, 1:21 AM
tomek accepted D11011: [lib] Update genesis.id to use authoritativeKeyserverID.
Feb 12 2024, 1:19 AM
tomek accepted D11008: [web] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 12 2024, 1:18 AM
tomek accepted D11007: [native] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 12 2024, 1:13 AM
tomek requested changes to D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 12 2024, 1:12 AM
tomek accepted D10993: [lib][web][native] Add configurable authoritativeKeyserverID.
Feb 12 2024, 1:02 AM
tomek added inline comments to D11005: [native] use identity wallet login in fullscreen-siwe-panel.
Feb 12 2024, 12:36 AM

Feb 9 2024

tomek requested review of D11015: [blob] Block reserved and offensive links from being created.
Feb 9 2024, 9:47 AM
tomek added inline comments to D11005: [native] use identity wallet login in fullscreen-siwe-panel.
Feb 9 2024, 3:18 AM
tomek updated the diff for D10131: [keyserver] Change blob upload functions to return more usable results.

Fix Flow

Feb 9 2024, 2:48 AM

Feb 8 2024

tomek updated the diff for D10131: [keyserver] Change blob upload functions to return more usable results.

Rebase

Feb 8 2024, 6:34 AM
tomek updated the diff for D10098: [keyserver] Modify blob functions so that they take params object where both hash and holder are provided.

Rebase

Feb 8 2024, 6:33 AM
tomek added inline comments to D9966: [keyserver] Add a function that deletes a blob.
Feb 8 2024, 6:31 AM
tomek updated the diff for D9966: [keyserver] Add a function that deletes a blob.

Use auth headers

Feb 8 2024, 6:31 AM
tomek requested review of D10992: [lib] Join a community on an overridden keyserver.
Feb 8 2024, 6:27 AM
tomek requested review of D10991: [native][web][lib] Extract common invite link logic.
Feb 8 2024, 4:08 AM
tomek accepted D10990: [lib] Add `rolesWithoutSpecialRoleField` filter to `rawThreadInfoFromServerThreadInfo`.

We will patch the specialRole field back in to minimally encoded RawThreadInfos for future clients (where shouldMinimallyEncodePermissions AND includeSpecialRoleFieldInRoles are true).

Feb 8 2024, 2:27 AM
tomek accepted D10975: [lib] Add `shouldIncludeSpecialRoleFieldInRoles` to `RawThreadInfoOptions`.
Feb 8 2024, 2:24 AM
tomek accepted D10107: [keyserver] Update `fetchServerThreadInfos(filter?: FetchThreadInfosFilter)` to fetch special_role.
Feb 8 2024, 2:14 AM
tomek accepted D10970: [lib] Dispatch SET_NEW_SESSION when session recovery fails.
Feb 8 2024, 2:06 AM
tomek accepted D10972: [lib] Clear sessionRecoveryInProgress during auth / deauth.
Feb 8 2024, 1:48 AM

Feb 7 2024

tomek accepted D10972: [lib] Clear sessionRecoveryInProgress during auth / deauth.
Feb 7 2024, 6:37 AM
tomek accepted D10964: [crypto] unify one-time keys usage.
Feb 7 2024, 6:36 AM
tomek accepted D10954: [lib] Move CallKeyserverEndpoint session recovery to KeyserverConnectionHandler.
Feb 7 2024, 6:27 AM
tomek accepted D10961: [lib][native][web] useIdentityWalletLogIn() hook.
Feb 7 2024, 6:06 AM
tomek added inline comments to D10960: [web] factor out creation of DeviceKeyUpload.
Feb 7 2024, 3:41 AM

Feb 6 2024

tomek abandoned D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.

With the new approach we no longer need this

Feb 6 2024, 6:41 AM
tomek updated the diff for D10338: [web][native] Download invite link blob and use it as an override.

Simplify the approach

Feb 6 2024, 6:41 AM
tomek accepted D10952: [lib] Let keyserver session recovery code handle calling setNewSession.
Feb 6 2024, 4:47 AM
tomek accepted D10951: [lib] Disable keyserver session recovery when paramOverride is specified.
Feb 6 2024, 4:37 AM
tomek accepted D10949: [lib] Conclude sessionRecoveryInProgress when user cookie is received or session is invalidated.
Feb 6 2024, 3:28 AM
tomek accepted D10931: [lib][native] Pass CSAT to Reports endpoint.

I wonder if there's a more generic way we could handle this... I could imagine defining this similar to keyserver actions, where "Comm service actions" are defined as functions that take functions as input. The inner function would be something like callAuthenticatedCommService, and it would allow the "Comm service action" to abstract away the details of authentication. Then we would have a hook (eg. useCommServiceCall) that takes the "Comm service action" function as input, and binds in the callAuthenticatedCommService function.

Feb 6 2024, 1:44 AM
tomek accepted D10930: [lib] Add optional Authorization header to reports endpoint.
Feb 6 2024, 1:40 AM
tomek added inline comments to D10913: [native][web] Add AuthMetadata to Blob service upload actions.
Feb 6 2024, 1:39 AM
tomek accepted D10913: [native][web] Add AuthMetadata to Blob service upload actions.
Feb 6 2024, 1:37 AM
tomek accepted D10912: [web] Pass CSAT to Blob service when fetching multimedia.
Feb 6 2024, 1:28 AM
tomek accepted D10910: [native] Pass CSAT to Blob service when fetching multimedia.
Feb 6 2024, 1:23 AM
tomek requested changes to D10961: [lib][native][web] useIdentityWalletLogIn() hook.
Feb 6 2024, 1:10 AM
tomek accepted D10960: [web] factor out creation of DeviceKeyUpload.
Feb 6 2024, 1:00 AM
tomek accepted D10959: [native] rename siweServerCall.

It would be helpful if you linked a Linear task describing why we need to change that or explain what the plan is. I guess we're going to introduce a new, similar hook, but I can't be sure.

Feb 6 2024, 12:56 AM
tomek accepted D10115: [native] Update update-roles-and-permissions-test-data.js to include specialRole field.
Feb 6 2024, 12:52 AM
tomek added inline comments to D10115: [native] Update update-roles-and-permissions-test-data.js to include specialRole field.
Feb 6 2024, 12:52 AM
tomek added inline comments to D10114: [lib] Update thread-ops-utils.test.js to include specialRole field.
Feb 6 2024, 12:48 AM
tomek accepted D10114: [lib] Update thread-ops-utils.test.js to include specialRole field.
Feb 6 2024, 12:48 AM
tomek accepted D10113: [lib] Update validation.test.js to include specialRole field.
Feb 6 2024, 12:46 AM
tomek accepted D10112: [lib] Update minimally-encoded-thread-permissions-test-data.js to include specialRole field.
Feb 6 2024, 12:46 AM
tomek accepted D10111: [lib] Update minimally-encoded-thread-permissions.test.js to include specialRole field.
Feb 6 2024, 12:45 AM
tomek accepted D10110: [keyserver] Update responder-validators.test.js to include specialRole field.
Feb 6 2024, 12:44 AM

Feb 5 2024

tomek added inline comments to D10884: [lib] Cancel an auth every time dependencies change.
Feb 5 2024, 7:27 AM
tomek closed D10884: [lib] Cancel an auth every time dependencies change.
Feb 5 2024, 7:23 AM
tomek committed rCOMMdb6e4f32817d: [lib] Cancel an auth every time dependencies change (authored by tomek).
[lib] Cancel an auth every time dependencies change
Feb 5 2024, 7:23 AM
tomek closed D10844: [lib] Retry auth.
Feb 5 2024, 7:23 AM
tomek closed D10843: [lib] Clear connection issue on successful login.
Feb 5 2024, 7:23 AM
tomek committed rCOMMee45a9d54c10: [lib] Clear connection issue on successful login (authored by tomek).
[lib] Clear connection issue on successful login
Feb 5 2024, 7:23 AM
tomek committed rCOMM4111f6f08744: [lib] Retry auth (authored by tomek).
[lib] Retry auth
Feb 5 2024, 7:23 AM
tomek closed D10842: [lib] Don't automatically log out on connection issue when using CSAT.
Feb 5 2024, 7:23 AM
tomek closed D10834: [lib] Logout after failing to auth with Ashoat's keyserver.
Feb 5 2024, 7:23 AM
tomek committed rCOMM2223dde652af: [lib] Logout after failing to auth with Ashoat's keyserver (authored by tomek).
[lib] Logout after failing to auth with Ashoat's keyserver
Feb 5 2024, 7:23 AM
tomek committed rCOMM44debc42a70f: [lib] Don't automatically log out on connection issue when using CSAT (authored by tomek).
[lib] Don't automatically log out on connection issue when using CSAT
Feb 5 2024, 7:23 AM
tomek closed D10831: [lib] Run the keyserver auth only when it isn't running and a user isn't already authenticated.
Feb 5 2024, 7:23 AM
tomek committed rCOMMe2ac6ed1367a: [lib] Run the keyserver auth only when it isn't running and a user isn't… (authored by tomek).
[lib] Run the keyserver auth only when it isn't running and a user isn't…
Feb 5 2024, 7:23 AM
tomek added inline comments to D10884: [lib] Cancel an auth every time dependencies change.
Feb 5 2024, 7:01 AM
tomek updated the diff for D10884: [lib] Cancel an auth every time dependencies change.

Await more promises at once

Feb 5 2024, 7:00 AM
tomek added inline comments to D10834: [lib] Logout after failing to auth with Ashoat's keyserver.
Feb 5 2024, 6:56 AM