Page MenuHomePhorge
Feed Search

Feb 28 2024

ginsu updated the test plan for D11152: [sqlite] implement C++ community store ops.
Feb 28 2024, 3:30 AM
ginsu updated the diff for D11151: [sqlite] add methods to operate on communities table.

rebase before landing

Feb 28 2024, 3:19 AM
ginsu updated the diff for D11087: [sqlite] add communites table for community store data.

rebase before landing

Feb 28 2024, 3:17 AM

Feb 26 2024

ginsu requested review of D11159: [DO NOT LAND][web] add @neynar/nodejs-sdk dep.
Feb 26 2024, 10:24 PM
ginsu requested review of D11167: [lib] populate community store on user login.

will make sure ci passes before landing

Feb 26 2024, 9:13 AM
ginsu requested review of D11166: [lib] introduce community reducer.

will make sure ci passes before landing

Feb 26 2024, 9:13 AM
ginsu requested review of D11165: [lib] introduce addCommunityActionType.

will make sure ci passes before landing

Feb 26 2024, 9:08 AM
ginsu published D11164: [sqlite] implement processing community store ops on worker for review.

will make sure ci passes before landing

Feb 26 2024, 9:08 AM

Feb 24 2024

ginsu updated the diff for D11151: [sqlite] add methods to operate on communities table.

address feedback

Feb 24 2024, 1:16 AM

Feb 23 2024

ginsu requested review of D11153: [sqlite] implement c++ code to get communities.

will make sure ci passes before landing

Feb 23 2024, 8:43 AM
ginsu updated the diff for D11152: [sqlite] implement C++ community store ops.

update

Feb 23 2024, 8:33 AM
ginsu updated the summary of D11152: [sqlite] implement C++ community store ops.
Feb 23 2024, 8:27 AM
ginsu requested review of D11151: [sqlite] add methods to operate on communities table.
Feb 23 2024, 8:19 AM
ginsu requested review of D11152: [sqlite] implement C++ community store ops.
Feb 23 2024, 8:18 AM

Feb 22 2024

ginsu updated the diff for D11087: [sqlite] add communites table for community store data.

fix merge conflict with .wasm file

Feb 22 2024, 10:06 PM

Feb 21 2024

ginsu closed D10572: [web] introduce light mode to thread notifications modal.
Feb 21 2024, 7:11 AM
ginsu committed rCOMMee2fa75c836e: [web] introduce light mode to thread notifications modal.
Feb 21 2024, 7:11 AM
ginsu closed D10570: [web] introduce light mode to confirm leave thread modal.
Feb 21 2024, 7:11 AM
ginsu committed rCOMMd3f8d846c067: [web] introduce light mode to confirm leave thread modal.
Feb 21 2024, 7:11 AM
ginsu updated the diff for D10572: [web] introduce light mode to thread notifications modal.

rebase before landing

Feb 21 2024, 6:26 AM
ginsu added a comment to D10572: [web] introduce light mode to thread notifications modal.

Hm, radio button doesn't have much contrast when selected. Guessing that component will get updated later as part of this work?

Feb 21 2024, 6:26 AM
ginsu updated the diff for D10570: [web] introduce light mode to confirm leave thread modal.

rebase before landing

Feb 21 2024, 6:20 AM
ginsu added a comment to D10570: [web] introduce light mode to confirm leave thread modal.

Several things look weird about this modal:

  1. The "Are you sure" line isn't aligned, neither with the icon nor with the header text
  2. The spacing between the "Are you sure" line and the one above seems too light given the spacing elsewhere
  3. It doesn't have a separation between the button area and the text area. I thought Ted's most recent designs for modals introduced this, but I'm not sure if it was meant to apply universally or not

Not sure this diff is meant to address any of this. Feel free to land without addressing, but in that case please link a relevant Linear issue that explicitly mentions all of the above before landing

Feb 21 2024, 6:19 AM
ginsu abandoned D10571: [web] introduce light mode to sidebar promote modal.

D10276 makes this diff obsolete

Feb 21 2024, 5:11 AM

Feb 16 2024

ginsu added a comment to D11087: [sqlite] add communites table for community store data.

Looks good, two nits:

  1. The file from the test plan is not visible
  2. Can you also check if it works on the web? Logs on the worker are enough - here is how you can access them
Feb 16 2024, 8:40 PM
ginsu attached a referenced file: F1166566: Screenshot 2024-02-16 at 3.39.19 PM.png.
Feb 16 2024, 8:40 PM
ginsu updated the test plan for D11087: [sqlite] add communites table for community store data.
Feb 16 2024, 8:40 PM
ginsu attached a referenced file: F1164684: Screenshot 2024-02-15 at 5.04.59 PM.png.
Feb 16 2024, 8:30 PM

Feb 15 2024

ginsu requested review of D11087: [sqlite] add communites table for community store data.
Feb 15 2024, 10:28 PM
ginsu closed D11069: [web] cleanup members modal.
Feb 15 2024, 12:26 PM
ginsu committed rCOMM3e8dfacf7781: [web] cleanup members modal.
Feb 15 2024, 12:26 PM
ginsu closed D11067: [web] remove deprecated members modals code.
Feb 15 2024, 12:26 PM
ginsu closed D11068: [web] cleanup user list modals.
Feb 15 2024, 12:26 PM
ginsu closed D11066: [web] cleanup compose subchannel modal.
Feb 15 2024, 12:26 PM
ginsu committed rCOMM0b5afdd1f622: [web] cleanup user list modals.
Feb 15 2024, 12:26 PM
ginsu committed rCOMM8cc1ac138075: [web] remove deprecated members modals code.
Feb 15 2024, 12:26 PM
ginsu committed rCOMMb4d6a33e84b0: [web] cleanup compose subchannel modal.
Feb 15 2024, 12:26 PM
ginsu closed D11065: [web] use AddUsersList in SubchannelMembers.
Feb 15 2024, 12:26 PM
ginsu committed rCOMM81790dae5333: [web] use AddUsersList in SubchannelMembers.
Feb 15 2024, 12:26 PM
ginsu closed D10994: [web] cleanup change member role modal.
Feb 15 2024, 12:26 PM
ginsu closed D11064: [web] cleanup create roles modal.
Feb 15 2024, 12:26 PM
ginsu committed rCOMMdd294640b92d: [web] cleanup change member role modal.
Feb 15 2024, 12:26 PM
ginsu closed D11063: [web] cleanup enum option component when there is no icon.
Feb 15 2024, 12:26 PM
ginsu committed rCOMM8649bf6fd93a: [web] cleanup create roles modal.
Feb 15 2024, 12:26 PM
ginsu closed D11035: [web] reintroduce error message to thread settings modal.
Feb 15 2024, 12:26 PM
ginsu committed rCOMM5a837285d13d: [web] cleanup enum option component when there is no icon.
Feb 15 2024, 12:26 PM
ginsu closed D11034: [web] cleanup thread settings general + privacy tabs.
Feb 15 2024, 12:26 PM
ginsu committed rCOMMd8a26aec9621: [web] reintroduce error message to thread settings modal.
Feb 15 2024, 12:26 PM
ginsu committed rCOMMf6fc837d607e: [web] cleanup thread settings general + privacy tabs.
Feb 15 2024, 12:26 PM
ginsu closed D11033: [web] cleanup thread settings relationship tab.
Feb 15 2024, 12:26 PM
ginsu committed rCOMMe99258c6d643: [web] cleanup thread settings relationship tab.
Feb 15 2024, 12:26 PM
ginsu closed D11032: [web] cleanup thread settings modal delete tab.
Feb 15 2024, 12:26 PM
ginsu committed rCOMMdd4ec081e9c8: [web] cleanup thread settings modal delete tab.
Feb 15 2024, 12:26 PM
ginsu updated the diff for D11069: [web] cleanup members modal.

rebase before landing

Feb 15 2024, 12:23 PM
ginsu updated the diff for D11068: [web] cleanup user list modals.

rebase before landing

Feb 15 2024, 12:22 PM
ginsu updated the diff for D11067: [web] remove deprecated members modals code.

rebase before landing

Feb 15 2024, 12:22 PM
ginsu updated the diff for D11066: [web] cleanup compose subchannel modal.

rebase before landing

Feb 15 2024, 12:21 PM
ginsu added inline comments to D11066: [web] cleanup compose subchannel modal.
Feb 15 2024, 12:20 PM
ginsu updated the diff for D11065: [web] use AddUsersList in SubchannelMembers.

address feedback + rebase before landing

Feb 15 2024, 12:18 PM
ginsu updated the diff for D10994: [web] cleanup change member role modal.

address comments + rebase before landing

Feb 15 2024, 12:14 PM
ginsu added inline comments to D10994: [web] cleanup change member role modal.
Feb 15 2024, 12:11 PM
ginsu updated the diff for D11064: [web] cleanup create roles modal.

rebase before landing

Feb 15 2024, 12:10 PM
ginsu updated the diff for D11063: [web] cleanup enum option component when there is no icon.

address feedback + rebase before landing

Feb 15 2024, 12:09 PM
ginsu updated the diff for D11035: [web] reintroduce error message to thread settings modal.

rebase before landing

Feb 15 2024, 12:06 PM
ginsu updated the diff for D11034: [web] cleanup thread settings general + privacy tabs.

rebase before landing

Feb 15 2024, 12:05 PM
ginsu added a comment to D11034: [web] cleanup thread settings general + privacy tabs.

Can you make sure removing form doesn't affect functionality?

Feb 15 2024, 12:05 PM
ginsu updated the diff for D11033: [web] cleanup thread settings relationship tab.

rebase before landing

Feb 15 2024, 12:04 PM
ginsu updated the diff for D11032: [web] cleanup thread settings modal delete tab.

rebase before landing

Feb 15 2024, 12:03 PM
ginsu closed D11031: [web] introduce thread settings utils.
Feb 15 2024, 10:26 AM
ginsu closed D11029: [web] cleanup add keyserver modal.
Feb 15 2024, 10:26 AM
ginsu closed D11030: [web] cleanup keyserver selection modal.
Feb 15 2024, 10:26 AM
ginsu closed D11027: [web] clean up user profiles modal.
Feb 15 2024, 10:26 AM
ginsu committed rCOMMd56dd2348eea: [web] cleanup add keyserver modal.
Feb 15 2024, 10:26 AM
ginsu committed rCOMMbe7131a7038d: [web] cleanup keyserver selection modal.
Feb 15 2024, 10:26 AM
ginsu committed rCOMM225df0764774: [web] introduce thread settings utils.
Feb 15 2024, 10:26 AM
ginsu committed rCOMM98811f486ac3: [web] clean up user profiles modal.
Feb 15 2024, 10:26 AM
ginsu closed D11026: [web] cleanup alert modal.
Feb 15 2024, 10:26 AM
ginsu closed D11025: [web] cleanup UnsavedChangesModal.
Feb 15 2024, 10:26 AM
ginsu committed rCOMMa3df036fdb90: [web] cleanup UnsavedChangesModal.
Feb 15 2024, 10:26 AM
ginsu committed rCOMM3233d77828b0: [web] cleanup alert modal.
Feb 15 2024, 10:26 AM
ginsu closed D11024: [web] cleanup community creation members modal.
Feb 15 2024, 10:26 AM
ginsu committed rCOMMf231eeef1f7e: [web] cleanup community creation members modal.
Feb 15 2024, 10:26 AM
ginsu closed D11023: [web] cleanup add members modal.
Feb 15 2024, 10:26 AM
ginsu closed D10944: [web] lift primary button logic from AddMembersModalContent into AddMembersModal.
Feb 15 2024, 10:26 AM
ginsu committed rCOMM84492bc85a22: [web] cleanup add members modal.
Feb 15 2024, 10:26 AM
ginsu committed rCOMM0c107f1fb030: [web] lift primary button logic from AddMembersModalContent into AddMembersModal.
Feb 15 2024, 10:26 AM
ginsu closed D10943: [web] replace AddMembersListContent experience with AddUsersList.
Feb 15 2024, 10:26 AM
ginsu closed D10942: [web] introduce useAddMembersListUserInfos.
Feb 15 2024, 10:26 AM
ginsu committed rCOMMab7066dff625: [web] replace AddMembersListContent experience with AddUsersList.
Feb 15 2024, 10:26 AM
ginsu closed D10941: [web] remove old Label ui component from add members modal.
Feb 15 2024, 10:26 AM
ginsu committed rCOMM234af3cab3fd: [web] introduce useAddMembersListUserInfos.
Feb 15 2024, 10:26 AM
ginsu committed rCOMM5afa22f75834: [web] remove old Label ui component from add members modal.
Feb 15 2024, 10:26 AM
ginsu closed D10937: [web] introduce add users list provider.
Feb 15 2024, 10:26 AM
ginsu closed D10940: [web] make AddUsersList feature agnostic.
Feb 15 2024, 10:26 AM
ginsu committed rCOMMef55388b047c: [web] make AddUsersList feature agnostic.
Feb 15 2024, 10:26 AM
ginsu committed rCOMMbf2665f0adb8: [web] introduce add users list provider.
Feb 15 2024, 10:26 AM
ginsu closed D10936: [web] introduce useUserRelationshipUserInfos.
Feb 15 2024, 10:26 AM
ginsu committed rCOMMc04315722018: [web] introduce useUserRelationshipUserInfos.
Feb 15 2024, 10:26 AM
ginsu updated the diff for D11031: [web] introduce thread settings utils.

rebase before landing

Feb 15 2024, 10:17 AM
ginsu updated the diff for D11030: [web] cleanup keyserver selection modal.

rebase before landing

Feb 15 2024, 10:16 AM