rebase before landing
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feb 28 2024
rebase before landing
Feb 26 2024
will make sure ci passes before landing
will make sure ci passes before landing
will make sure ci passes before landing
will make sure ci passes before landing
Feb 24 2024
address feedback
Feb 23 2024
will make sure ci passes before landing
update
Feb 22 2024
fix merge conflict with .wasm file
Feb 21 2024
rebase before landing
Hm, radio button doesn't have much contrast when selected. Guessing that component will get updated later as part of this work?
rebase before landing
In D10570#305644, @ashoat wrote:Several things look weird about this modal:
- The "Are you sure" line isn't aligned, neither with the icon nor with the header text
- The spacing between the "Are you sure" line and the one above seems too light given the spacing elsewhere
- It doesn't have a separation between the button area and the text area. I thought Ted's most recent designs for modals introduced this, but I'm not sure if it was meant to apply universally or not
Not sure this diff is meant to address any of this. Feel free to land without addressing, but in that case please link a relevant Linear issue that explicitly mentions all of the above before landing
D10276 makes this diff obsolete
Feb 16 2024
In D11087#320698, @kamil wrote:Looks good, two nits:
- The file from the test plan is not visible
- Can you also check if it works on the web? Logs on the worker are enough - here is how you can access them
Feb 15 2024
rebase before landing
rebase before landing
rebase before landing
rebase before landing
address feedback + rebase before landing
address comments + rebase before landing
rebase before landing
address feedback + rebase before landing
rebase before landing
rebase before landing
Can you make sure removing form doesn't affect functionality?
rebase before landing
rebase before landing
rebase before landing
rebase before landing