will make sure the ci passes before landing
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Mar 29 2024
will make sure ci passes before landing
lgtm
Mar 28 2024
update
address feedback
address comments
address feedback
we ended up building our own neynar api client in house so we can abandon this
addd @babel/plugin-transform-private-methods to keysever/package.json
In D11427#329531, @ashoat wrote:We should include the new package in keyserver/package.json since it's used in keyserver/.babelrc.cjs. It doesn't cause any issues right now because the package isn't getting hoisted, but subtle changes to dependencies could change that.
Mar 27 2024
Mar 26 2024
Mar 25 2024
One question inline
Mar 14 2024
rebase before landing
Mar 13 2024
Mar 8 2024
Code LGTM, in ENG-6298 you mentioned,
Mar 6 2024
rubber stamping, one thing to note is that it looks like this diff is part of an unrelated stack
Mar 4 2024
rebase before landing
address comments + rebase before landing
was it tested on both the web and native?
Feb 28 2024
will make sure ci passes before landing
native migration not working correctly
Question inline about updating version field
In this diff, you are starting to process store ops on DB - and it looks like CommunityInfo has a field called enabledApps which I think we already have defined somewhere. Do we need some sort of migration or this is just a brand-new store and we'll start populating it after adding business logic/UI?
In D11166#323280, @tomek wrote:In D11166#323019, @atul wrote:Mostly looks good, but do we need to handle clearing the data on log out/delete account/etc?
In our current approach, we don't need to do anything: resetUserSpecificState should handle it. Only the fields from nonUserSpecificFieldsWeb and nonUserSpecificFieldsNative survive these actions. But please test it.
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
it will be nice to make the testing process more transparent
it would be great if you could respond and update the test plan