Page MenuHomePhorge
Feed Search

Mar 29 2024

ginsu closed D11442: [native] introduce ConnectFarcaster registration screen.
Mar 29 2024, 9:20 PM
ginsu committed rCOMMc29ed7da457a: [native] introduce ConnectFarcaster registration screen.
Mar 29 2024, 9:20 PM
ginsu closed D11441: [native] introduce FarcasterPrompt.
Mar 29 2024, 9:20 PM
ginsu committed rCOMMe2063fce5e81: [native] introduce FarcasterPrompt.
Mar 29 2024, 9:20 PM
ginsu closed D11479: [keyserver] add file-type dep.
Mar 29 2024, 8:58 PM
ginsu committed rCOMM194afd3f0228: [keyserver] add file-type dep.
Mar 29 2024, 8:58 PM
ginsu requested review of D11479: [keyserver] add file-type dep.
Mar 29 2024, 8:15 PM
ginsu requested review of D11463: [native] introduce already connected button to farcaster connect.

will make sure the ci passes before landing

Mar 29 2024, 5:09 AM
ginsu requested review of D11462: [native] implement onSuccess callback for ConnectFarcaster registration step.

will make sure ci passes before landing

Mar 29 2024, 4:47 AM
ginsu requested review of D11461: [native] add the connect farcaster step into the registration flow.
Mar 29 2024, 4:45 AM
ginsu accepted D11457: [lib] Fix `UpdateRelationshipMessageSpec.validator`.
Mar 29 2024, 3:43 AM
ginsu accepted D11455: [lib] Update `rawMessageInfoFromClientDB` to support `RawUpdateRelationshipMessageInfo`.
Mar 29 2024, 3:43 AM
ginsu accepted D11452: [lib] Partially update `UpdateRelationshipMessageSpec` to support updated `UpdateRelationship` message type.
Mar 29 2024, 3:32 AM
ginsu accepted D11443: [lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship`.
Mar 29 2024, 3:26 AM
ginsu accepted D11439: [lib] Update union types in `message-types` to include `UpdateRelationship` types.
Mar 29 2024, 3:25 AM
ginsu accepted D11438: [lib] Introduce bare minimum `messageTypes.UPDATE_RELATIONSHIP`.

lgtm

Mar 29 2024, 3:24 AM
ginsu accepted D11460: [lib] Hook everything together in FarcasterDataHandler.
Mar 29 2024, 3:21 AM

Mar 28 2024

ginsu added inline comments to D11442: [native] introduce ConnectFarcaster registration screen.
Mar 28 2024, 7:45 PM
ginsu updated the diff for D11442: [native] introduce ConnectFarcaster registration screen.

update

Mar 28 2024, 7:44 PM
ginsu closed D11434: [native] introduce FarcasterLogo.
Mar 28 2024, 5:58 PM
ginsu closed D11432: [landing/lib/native] introduce FarcasterWebView.
Mar 28 2024, 5:58 PM
ginsu committed rCOMM3941d90cb605: [native] introduce FarcasterLogo.
Mar 28 2024, 5:58 PM
ginsu committed rCOMMaabf91724a80: [landing/lib/native] introduce FarcasterWebView.
Mar 28 2024, 5:58 PM
ginsu closed D11429: [landing] introduce /connect-farcaster route.
Mar 28 2024, 5:58 PM
ginsu closed D11428: [landing] introduce ConnectFarcaster.
Mar 28 2024, 5:58 PM
ginsu committed rCOMM1aceccccbaf3: [landing] introduce /connect-farcaster route.
Mar 28 2024, 5:58 PM
ginsu committed rCOMMc48488d8c8cd: [landing] introduce ConnectFarcaster.
Mar 28 2024, 5:58 PM
ginsu closed D11427: [keyserver/landing] add @babel/plugin-transform-private-methods to list of plugins.
Mar 28 2024, 5:58 PM
ginsu committed rCOMM62b3601c95c9: [keyserver/landing] add @babel/plugin-transform-private-methods to list of….
Mar 28 2024, 5:58 PM
ginsu requested review of D11442: [native] introduce ConnectFarcaster registration screen.
Mar 28 2024, 5:06 PM
ginsu requested review of D11441: [native] introduce FarcasterPrompt.
Mar 28 2024, 4:42 PM
ginsu updated the diff for D11434: [native] introduce FarcasterLogo.

address feedback

Mar 28 2024, 4:23 PM
ginsu updated the diff for D11432: [landing/lib/native] introduce FarcasterWebView.

address comments

Mar 28 2024, 4:21 PM
ginsu updated the diff for D11428: [landing] introduce ConnectFarcaster.

address feedback

Mar 28 2024, 4:05 PM
ginsu abandoned D11159: [DO NOT LAND][web] add @neynar/nodejs-sdk dep.

we ended up building our own neynar api client in house so we can abandon this

Mar 28 2024, 4:00 PM
ginsu updated the diff for D11427: [keyserver/landing] add @babel/plugin-transform-private-methods to list of plugins.

addd @babel/plugin-transform-private-methods to keysever/package.json

Mar 28 2024, 3:58 PM
ginsu added a comment to D11427: [keyserver/landing] add @babel/plugin-transform-private-methods to list of plugins.

We should include the new package in keyserver/package.json since it's used in keyserver/.babelrc.cjs. It doesn't cause any issues right now because the package isn't getting hoisted, but subtle changes to dependencies could change that.

Mar 28 2024, 3:48 PM
ginsu closed D11426: [landing] add @farcaster/auth-kit dep.
Mar 28 2024, 3:47 PM
ginsu committed rCOMMe0cbdd005db5: [landing] add @farcaster/auth-kit dep.
Mar 28 2024, 3:47 PM
ginsu accepted D11436: [lib] Add "Legacy" to types in `update-relationship`.
Mar 28 2024, 3:42 PM
ginsu requested review of D11434: [native] introduce FarcasterLogo.
Mar 28 2024, 5:06 AM
ginsu requested review of D11432: [landing/lib/native] introduce FarcasterWebView.
Mar 28 2024, 4:44 AM
ginsu requested review of D11429: [landing] introduce /connect-farcaster route.
Mar 28 2024, 4:34 AM
ginsu requested review of D11428: [landing] introduce ConnectFarcaster.
Mar 28 2024, 4:30 AM
ginsu requested review of D11427: [keyserver/landing] add @babel/plugin-transform-private-methods to list of plugins.
Mar 28 2024, 4:16 AM
ginsu accepted D11425: [lib][native] FIDProvider.
Mar 28 2024, 3:43 AM
ginsu updated the summary of D11426: [landing] add @farcaster/auth-kit dep.
Mar 28 2024, 3:42 AM
ginsu updated the summary of D11426: [landing] add @farcaster/auth-kit dep.
Mar 28 2024, 3:42 AM
ginsu requested review of D11426: [landing] add @farcaster/auth-kit dep.
Mar 28 2024, 3:38 AM

Mar 27 2024

ginsu accepted D11389: [lib][native] Introduce NeynarClientProvider.
Mar 27 2024, 5:26 AM
ginsu accepted D11388: [lib] Initial NeynarClient with fetchFriendFIDs method.
Mar 27 2024, 5:25 AM
ginsu accepted D11387: [lib][native] Introduce FarcasterDataHandler.
Mar 27 2024, 5:23 AM

Mar 26 2024

ginsu accepted D11381: [CI] Include "Save NEYNAR_API_KEY to file" step in `[ios/android]_release` workflows.
Mar 26 2024, 7:16 PM

Mar 25 2024

ginsu accepted D11380: [native] Export `neynarKey` so it's accessible from `native`.

One question inline

Mar 25 2024, 8:25 PM

Mar 14 2024

ginsu closed D11316: [native] fix long keyserver names ui bug.
Mar 14 2024, 5:07 PM
ginsu committed rCOMM9af69c74ee2b: [native] fix long keyserver names ui bug.
Mar 14 2024, 5:07 PM
ginsu updated the diff for D11316: [native] fix long keyserver names ui bug.

rebase before landing

Mar 14 2024, 5:06 PM

Mar 13 2024

ginsu requested review of D11316: [native] fix long keyserver names ui bug.
Mar 13 2024, 8:18 PM

Mar 8 2024

ginsu accepted D11283: [lib][web][native] Use real admin username or id when adding a ks.

Code LGTM, in ENG-6298 you mentioned,

Mar 8 2024, 7:36 PM

Mar 6 2024

ginsu accepted D11262: [CommCoreModule] Add `#include <functional>` to `NotificationsCryptoModule`.
Mar 6 2024, 10:36 PM
ginsu published D11262: [CommCoreModule] Add `#include <functional>` to `NotificationsCryptoModule` for review.

rubber stamping, one thing to note is that it looks like this diff is part of an unrelated stack

Mar 6 2024, 10:36 PM

Mar 4 2024

ginsu closed D11190: [lib/native/web] read communites from sqlite on app start.
Mar 4 2024, 8:39 PM
ginsu committed rCOMMcace3a54d8b3: [lib/native/web] read communites from sqlite on app start.
Mar 4 2024, 8:39 PM
ginsu closed D11166: [lib] introduce community reducer.
Mar 4 2024, 8:39 PM
ginsu committed rCOMM6dd1be25ce84: [lib] introduce community reducer.
Mar 4 2024, 8:39 PM
ginsu updated the diff for D11190: [lib/native/web] read communites from sqlite on app start.

rebase before landing

Mar 4 2024, 8:35 PM
ginsu updated the diff for D11166: [lib] introduce community reducer.

address comments + rebase before landing

Mar 4 2024, 8:34 PM
ginsu added a comment to D11190: [lib/native/web] read communites from sqlite on app start.

was it tested on both the web and native?

Mar 4 2024, 8:07 PM
ginsu added inline comments to D11166: [lib] introduce community reducer.
Mar 4 2024, 8:05 PM

Feb 28 2024

ginsu requested review of D11192: [lib] introduce removeCommunityActionType.

will make sure ci passes before landing

Feb 28 2024, 2:22 PM
ginsu planned changes to D11191: DRAFT [lib/native/web] introduce migration to populate community store.

native migration not working correctly

Feb 28 2024, 8:29 AM
ginsu published D11191: DRAFT [lib/native/web] introduce migration to populate community store for review.
Feb 28 2024, 8:28 AM
ginsu updated the summary of D11167: [lib] populate community store on user login.
Feb 28 2024, 8:21 AM
ginsu requested review of D11190: [lib/native/web] read communites from sqlite on app start.
Feb 28 2024, 7:51 AM
ginsu requested changes to D11188: [web] Redux migration to patch in `specialRole` field.

Question inline about updating version field

Feb 28 2024, 7:44 AM
ginsu updated the summary of D11167: [lib] populate community store on user login.
Feb 28 2024, 7:37 AM
ginsu added inline comments to D11167: [lib] populate community store on user login.
Feb 28 2024, 4:53 AM
ginsu added a comment to D11166: [lib] introduce community reducer.

In this diff, you are starting to process store ops on DB - and it looks like CommunityInfo has a field called enabledApps which I think we already have defined somewhere. Do we need some sort of migration or this is just a brand-new store and we'll start populating it after adding business logic/UI?

Feb 28 2024, 4:48 AM
ginsu requested review of D11166: [lib] introduce community reducer.
In D11166#323019, @atul wrote:

Mostly looks good, but do we need to handle clearing the data on log out/delete account/etc?

In our current approach, we don't need to do anything: resetUserSpecificState should handle it. Only the fields from nonUserSpecificFieldsWeb and nonUserSpecificFieldsNative survive these actions. But please test it.

Feb 28 2024, 4:42 AM
ginsu closed D11165: [lib] introduce addCommunityActionType.
Feb 28 2024, 4:02 AM
ginsu committed rCOMM1ee876eefe7e: [lib] introduce addCommunityActionType.
Feb 28 2024, 4:02 AM
ginsu closed D11164: [sqlite] implement processing community store ops on worker.
Feb 28 2024, 4:02 AM
ginsu committed rCOMMbe85d5c7b530: [sqlite] implement processing community store ops on worker.
Feb 28 2024, 4:02 AM
ginsu closed D11153: [sqlite] implement c++ code to get communities.
Feb 28 2024, 4:02 AM
ginsu closed D11151: [sqlite] add methods to operate on communities table.
Feb 28 2024, 4:02 AM
ginsu committed rCOMMb1f35f4bd8e6: [sqlite] implement c++ code to get communities.
Feb 28 2024, 4:02 AM
ginsu closed D11152: [sqlite] implement C++ community store ops.
Feb 28 2024, 4:02 AM
ginsu committed rCOMM571ae32fcd45: [sqlite] implement C++ community store ops.
Feb 28 2024, 4:02 AM
ginsu committed rCOMM68a6672a3569: [sqlite] add methods to operate on communities table.
Feb 28 2024, 4:02 AM
ginsu closed D11087: [sqlite] add communites table for community store data.
Feb 28 2024, 4:02 AM
ginsu committed rCOMM5d3f1a74764f: [sqlite] add communites table for community store data.
Feb 28 2024, 4:02 AM
ginsu updated the diff for D11165: [lib] introduce addCommunityActionType.

rebase before landing

Feb 28 2024, 3:40 AM
ginsu updated the diff for D11164: [sqlite] implement processing community store ops on worker.

rebase before landing

Feb 28 2024, 3:39 AM
ginsu updated the diff for D11153: [sqlite] implement c++ code to get communities.

rebase before landing

Feb 28 2024, 3:38 AM
ginsu updated the diff for D11153: [sqlite] implement c++ code to get communities.

rebase before landing

Feb 28 2024, 3:37 AM
ginsu updated the diff for D11152: [sqlite] implement C++ community store ops.

rebase before landing

Feb 28 2024, 3:36 AM
ginsu added a comment to D11153: [sqlite] implement c++ code to get communities.

it will be nice to make the testing process more transparent

Feb 28 2024, 3:35 AM
ginsu updated the test plan for D11153: [sqlite] implement c++ code to get communities.
Feb 28 2024, 3:35 AM
ginsu added a comment to D11152: [sqlite] implement C++ community store ops.

it would be great if you could respond and update the test plan

Feb 28 2024, 3:30 AM
ginsu updated the test plan for D11152: [sqlite] implement C++ community store ops.
Feb 28 2024, 3:30 AM