Page MenuHomePhabricator
Feed Advanced Search

Jul 4 2024

marcin added inline comments to D12539: Utilise subscription from ThickMemberInfo when building a notif.
Jul 4 2024, 4:54 AM
marcin added inline comments to D12572: Add encryptedNotifUtilsAPI on client platforms with mock encryption..
Jul 4 2024, 3:37 AM

Jul 3 2024

marcin added inline comments to D12464: Implement notification texts generation on the client.
Jul 3 2024, 4:56 AM
marcin updated the diff for D12539: Utilise subscription from ThickMemberInfo when building a notif.

Extract parameters to object

Jul 3 2024, 3:37 AM
marcin updated the diff for D12477: Implement building encrypted notifications on the client.
  1. Extract parameters to object.
  2. Make sure await is the first keyword
Jul 3 2024, 3:36 AM
marcin updated the diff for D12476: Move groupping device by platform details and notif info generation promise to utils in lib/push.

Extract parameters to object

Jul 3 2024, 3:36 AM
marcin updated the diff for D12464: Implement notification texts generation on the client.

Extract parameters to object

Jul 3 2024, 3:35 AM
marcin updated the diff for D12463: Implement route from MessageData to MessageInfo on the client.

Extract parameters to object

Jul 3 2024, 3:34 AM
marcin updated the diff for D12429: Implement notification types, creation and encryption for APNs notifications.

Update type name in the invariant. Rename cookieID to cryptoID

Jul 3 2024, 3:34 AM
marcin updated the diff for D12428: Bump minimal native code version to 149.

Remove 'NONE' and its usages

Jul 3 2024, 3:32 AM
marcin added inline comments to D12464: Implement notification texts generation on the client.
Jul 3 2024, 3:31 AM
marcin added inline comments to D12477: Implement building encrypted notifications on the client.
Jul 3 2024, 2:55 AM

Jul 2 2024

marcin added inline comments to D12464: Implement notification texts generation on the client.
Jul 2 2024, 12:30 PM
marcin added inline comments to D12429: Implement notification types, creation and encryption for APNs notifications.
Jul 2 2024, 8:01 AM
marcin added a comment to D12396: Introduce EncryptedNotifUtilsAPI and implement it on the keyserver.

I would consider registering config for keyserver to be able to use encryptedNotifUtilsAPI directly - passing it as a param trough all these functions makes it messy. In the future, we'll also want sqliteAPI to be implemented on keyserver, but this is something we can discuss in the Linear follow-up task because right now Config type is designed specifically for web & native.

Jul 2 2024, 7:46 AM
marcin closed D12634: Bring badgeOnly property to Android notifs.
Jul 2 2024, 2:52 AM
marcin committed rCOMMeac27d1c8c6d: Bring badgeOnly property to Android notifs (authored by marcin).
Bring badgeOnly property to Android notifs
Jul 2 2024, 2:52 AM
marcin accepted D12616: [Tunnelbroker] implement sending APNs notifs by client.
Jul 2 2024, 2:11 AM
marcin accepted D12615: [Tunnelbroker][lib] add APNs notif message type.
Jul 2 2024, 2:10 AM
marcin accepted D12612: [Tunnelbroker] implement creating APNs headers.
Jul 2 2024, 2:05 AM

Jul 1 2024

marcin added inline comments to D12608: [Tunnelbroker] add notifs module and needed crates.
Jul 1 2024, 2:03 AM
marcin accepted D12608: [Tunnelbroker] add notifs module and needed crates.
Jul 1 2024, 2:02 AM

Jun 26 2024

marcin updated the diff for D12539: Utilise subscription from ThickMemberInfo when building a notif.

Fix a bug: notifsAllowed returned variable was assigned to wrong condition

Jun 26 2024, 9:47 AM
marcin updated the diff for D12397: Move notification creaction and encryption to lib except for APNs noifs..

Add type of encrypted message to encrypted notification (1 for text and 0 for prekey)

Jun 26 2024, 9:46 AM
marcin updated the diff for D12396: Introduce EncryptedNotifUtilsAPI and implement it on the keyserver.

Rebase

Jun 26 2024, 9:45 AM
marcin updated the diff for D12396: Introduce EncryptedNotifUtilsAPI and implement it on the keyserver.

Rebase

Jun 26 2024, 9:44 AM
marcin updated the diff for D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.

Fix a bug: wrong order of spreads caused notif to miss keyserverID

Jun 26 2024, 9:41 AM
marcin updated the diff for D12394: Move all notif types to lib except for APNs notifs.

Rebase

Jun 26 2024, 9:40 AM

Jun 25 2024

marcin requested review of D12572: Add encryptedNotifUtilsAPI on client platforms with mock encryption..
Jun 25 2024, 5:47 AM

Jun 24 2024

marcin accepted D12496: [lib] Fix up client ThreadStore validation.
Jun 24 2024, 10:20 AM
marcin accepted D12495: [lib] Introduce RawThickThreadInfo type.
Jun 24 2024, 10:18 AM
marcin accepted D12553: [lib] flip usingCommServicesAccessToken to true.
Jun 24 2024, 7:54 AM
marcin added a comment to D12501: [lib] mark prekeys as published after uploading to identity.

I have concern that marking prekeys as published after uploading to identity comes with the risk of delaying next prekey rotation in case app crashes after uploading but before marking as published. I am wondering if letting the prekeys to be in circulation for longer than expected is a security concern. Accepting to unblock identity release. If my reasoning is correct we can just change the order later.

Jun 24 2024, 6:55 AM
marcin accepted D12501: [lib] mark prekeys as published after uploading to identity.
Jun 24 2024, 6:52 AM
marcin closed D12552: Refrain from querying blob service from the NSE if CAST is missing.
Jun 24 2024, 4:41 AM
marcin committed rCOMM234060ad2c39: Refrain from querying blob service from the NSE if CAST is missing (authored by marcin).
Refrain from querying blob service from the NSE if CAST is missing
Jun 24 2024, 4:41 AM
marcin updated the diff for D12552: Refrain from querying blob service from the NSE if CAST is missing.

Update error message

Jun 24 2024, 4:38 AM
marcin requested review of D12552: Refrain from querying blob service from the NSE if CAST is missing.
Jun 24 2024, 3:33 AM

Jun 21 2024

marcin updated the diff for D12427: Move android rescinds and badge updates to lib.

Address Ashoat requests

Jun 21 2024, 5:48 AM
marcin added inline comments to D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.
Jun 21 2024, 4:46 AM
marcin updated the diff for D12539: Utilise subscription from ThickMemberInfo when building a notif.

Fix android bug

Jun 21 2024, 4:44 AM
marcin added inline comments to D12397: Move notification creaction and encryption to lib except for APNs noifs..
Jun 21 2024, 4:37 AM
marcin requested review of D12539: Utilise subscription from ThickMemberInfo when building a notif.
Jun 21 2024, 4:25 AM
marcin added inline comments to D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.
Jun 21 2024, 4:25 AM

Jun 20 2024

marcin added inline comments to D12495: [lib] Introduce RawThickThreadInfo type.
Jun 20 2024, 8:19 AM
marcin accepted D12494: [lib] Factor out defaultSubscription in createPendingThread.
Jun 20 2024, 8:17 AM
marcin accepted D12479: [web][native] olm api method to mark prekeys as published.
Jun 20 2024, 7:47 AM
marcin added inline comments to D12464: Implement notification texts generation on the client.
Jun 20 2024, 5:01 AM
marcin updated the diff for D12477: Implement building encrypted notifications on the client.

Rebase

Jun 20 2024, 5:00 AM
marcin added a comment to D12476: Move groupping device by platform details and notif info generation promise to utils in lib/push.

This diff is pure copy paste. No additional logic.

Jun 20 2024, 5:00 AM
marcin updated the diff for D12476: Move groupping device by platform details and notif info generation promise to utils in lib/push.

Rebacr

Jun 20 2024, 4:59 AM
marcin added inline comments to D12464: Implement notification texts generation on the client.
Jun 20 2024, 4:59 AM
marcin updated the diff for D12464: Implement notification texts generation on the client.

Refactor

Jun 20 2024, 4:56 AM
marcin updated the diff for D12463: Implement route from MessageData to MessageInfo on the client.

Fix eslint

Jun 20 2024, 4:56 AM
marcin updated the diff for D12429: Implement notification types, creation and encryption for APNs notifications.

Fix eslint

Jun 20 2024, 4:55 AM
marcin updated the diff for D12464: Implement notification texts generation on the client.

Rebase

Jun 20 2024, 4:51 AM
marcin added inline comments to D12463: Implement route from MessageData to MessageInfo on the client.
Jun 20 2024, 4:51 AM
marcin updated the diff for D12463: Implement route from MessageData to MessageInfo on the client.

Rebase

Jun 20 2024, 4:47 AM
marcin added inline comments to D12429: Implement notification types, creation and encryption for APNs notifications.
Jun 20 2024, 4:42 AM
marcin updated the diff for D12429: Implement notification types, creation and encryption for APNs notifications.

Rebase and move apns logic to separate file and make types elegant

Jun 20 2024, 4:38 AM
marcin added inline comments to D12427: Move android rescinds and badge updates to lib.
Jun 20 2024, 4:36 AM
marcin updated the diff for D12427: Move android rescinds and badge updates to lib.

rebase and fix types

Jun 20 2024, 4:34 AM
marcin updated the diff for D12398: Rename cookieID -> cryptoID and deviceToken -> deliveryID.

Rebase

Jun 20 2024, 4:33 AM
marcin added inline comments to D12397: Move notification creaction and encryption to lib except for APNs noifs..
Jun 20 2024, 4:32 AM
marcin added inline comments to D12397: Move notification creaction and encryption to lib except for APNs noifs..
Jun 20 2024, 4:20 AM
marcin updated the diff for D12397: Move notification creaction and encryption to lib except for APNs noifs..

Split notif creators for each platform to separate files.

Jun 20 2024, 4:20 AM
marcin updated the diff for D12396: Introduce EncryptedNotifUtilsAPI and implement it on the keyserver.

Rebase

Jun 20 2024, 4:19 AM
marcin updated the diff for D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.

Rebase

Jun 20 2024, 4:17 AM
marcin updated the diff for D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
  1. Use invariant instead of new const
  2. Rename to SenderDeviceDescriptor
  3. Make types elegant.
Jun 20 2024, 4:16 AM
marcin added inline comments to D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
Jun 20 2024, 4:15 AM
marcin added inline comments to D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
Jun 20 2024, 4:12 AM
marcin added a comment to D12398: Rename cookieID -> cryptoID and deviceToken -> deliveryID.

Probably you know it better so up to you but for me recipientID seems better than cryptoID

Jun 20 2024, 3:24 AM

Jun 19 2024

marcin requested review of D12477: Implement building encrypted notifications on the client.
Jun 19 2024, 1:39 PM
marcin requested review of D12476: Move groupping device by platform details and notif info generation promise to utils in lib/push.
Jun 19 2024, 1:33 PM
marcin accepted D12467: [web] mark otks as published before attempting to upload keys to identity.
Jun 19 2024, 6:09 AM

Jun 18 2024

marcin requested review of D12464: Implement notification texts generation on the client.
Jun 18 2024, 6:12 AM
marcin requested review of D12463: Implement route from MessageData to MessageInfo on the client.
Jun 18 2024, 6:12 AM

Jun 14 2024

marcin accepted D12439: [keyserver] Set thread links code version.
Jun 14 2024, 6:25 AM

Jun 13 2024

marcin resigned from D12348: [identity][terraform] Create DDB index for deviceID.

@will or @varun will do a better job reviewing this.

Jun 13 2024, 9:30 AM
marcin requested review of D12429: Implement notification types, creation and encryption for APNs notifications.
Jun 13 2024, 9:20 AM
marcin requested review of D12428: Bump minimal native code version to 149.
Jun 13 2024, 9:14 AM
marcin requested review of D12427: Move android rescinds and badge updates to lib.
Jun 13 2024, 9:07 AM

Jun 11 2024

marcin requested review of D12398: Rename cookieID -> cryptoID and deviceToken -> deliveryID.
Jun 11 2024, 11:02 AM
marcin requested review of D12397: Move notification creaction and encryption to lib except for APNs noifs..
Jun 11 2024, 10:56 AM
marcin requested review of D12396: Introduce EncryptedNotifUtilsAPI and implement it on the keyserver.
Jun 11 2024, 10:54 AM
marcin requested review of D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
Jun 11 2024, 10:44 AM
marcin requested review of D12394: Move all notif types to lib except for APNs notifs.
Jun 11 2024, 10:40 AM

Jun 7 2024

marcin accepted D12304: [identity] Add /inbound_keys HTTP handler.
Jun 7 2024, 10:09 AM

Jun 6 2024

marcin closed D12312: Synchronize platform details with identity on app start.
Jun 6 2024, 8:59 AM
marcin committed rCOMMfcb896100446: Synchronize platform details with identity on app start (authored by marcin).
Synchronize platform details with identity on app start
Jun 6 2024, 8:59 AM
marcin closed D12311: Expose syncing platform details to identity client context.
Jun 6 2024, 8:59 AM
marcin committed rCOMMdabebc1ca86f: Expose syncing platform details to identity client context (authored by marcin).
Expose syncing platform details to identity client context
Jun 6 2024, 8:59 AM
marcin closed D12310: Implement native wrapper for syncPlatformDetails RPC.
Jun 6 2024, 8:59 AM
marcin committed rCOMM54e4b16d2f01: Implement native wrapper for syncPlatformDetails RPC (authored by marcin).
Implement native wrapper for syncPlatformDetails RPC
Jun 6 2024, 8:59 AM
marcin closed D12308: Enable the client to fetch users platform details from identity RPC.
Jun 6 2024, 8:59 AM
marcin committed rCOMM89119a1098b9: Enable the client to fetch users platform details from identity RPC (authored by marcin).
Enable the client to fetch users platform details from identity RPC
Jun 6 2024, 8:59 AM
marcin closed D12307: Add identity platform details to aux user store.
Jun 6 2024, 8:59 AM
marcin committed rCOMMca08c62896e9: Add identity platform details to aux user store (authored by marcin).
Add identity platform details to aux user store
Jun 6 2024, 8:59 AM
marcin updated the diff for D12312: Synchronize platform details with identity on app start.

Rebase before landing

Jun 6 2024, 8:28 AM
marcin updated the diff for D12311: Expose syncing platform details to identity client context.

Rebase before landing

Jun 6 2024, 8:27 AM