Add error handling to CommCoreModule::isContentSessionInitialized
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jul 15 2024
Jul 15 2024
marcin removed a reviewer for D12677: Implement method to query identity service from the NSE: tomek. marcin added 1 blocking reviewer(s) for D12677: Implement method to query identity service from the NSE: bartek.
marcin removed a reviewer for D12728: Implement Android HTTP call to identity to get notifs inbound keys: tomek.
marcin added inline comments to D12750: Implement inbound notif session creation from the NSE with race condition handling.
marcin updated the diff for D12672: Implement utility functions to check if we have content or notif session with device.
Rename ...DataContent... -> ...Data... to remove confusion around Conent keyword when dealing with notifs sessions
marcin added inline comments to D12672: Implement utility functions to check if we have content or notif session with device.
Fix CORS issues with identity HTTP
Rebase before landing
Jul 12 2024
Jul 12 2024
rebase before landing
Address Varun's and Will's feedbacks
marcin added inline comments to D12673: Utilities to idempotently create content and notif sessions.
marcin added inline comments to D12668: Implement peer notifications session creation as outbound on native.
This function is supposed to be used exclusively with thick threads.
Jul 11 2024
Jul 11 2024
marcin requested review of D12728: Implement Android HTTP call to identity to get notifs inbound keys.
- Don't pass references to unique pointer between lambdas - a rookie mistake!. Pass shared pointers by copy.
- Switch to multi process mode on MMKV on Android
marcin committed rCOMM11e83317cd31: Make client handlers that call authenticated identity RPC's gated on CSAT (authored by marcin).
Make client handlers that call authenticated identity RPC's gated on CSAT
marcin added a comment to D12695: Make client handlers that call authenticated identity RPC's gated on CSAT.
In D12695#360306, @ashoat wrote:Hey @marcin, any reason this hasn't been landed yet?
marcin updated the diff for D12695: Make client handlers that call authenticated identity RPC's gated on CSAT.
Rebase before landing
Jul 10 2024
Jul 10 2024
Jul 9 2024
Jul 9 2024
marcin added inline comments to D12695: Make client handlers that call authenticated identity RPC's gated on CSAT.
Jul 8 2024
Jul 8 2024
marcin requested review of D12695: Make client handlers that call authenticated identity RPC's gated on CSAT.
Jul 5 2024
Jul 5 2024
Jul 4 2024
Jul 4 2024
I am afraid that there is a vulnerability in this diff. Basically it is possible that two createOlmSessionWithPeer promises will execute concurrently. This might lead to corrupted state. In order to mitigate that I think it is best expose this method as a context. The context would internally keep a map like [(userID, deviceID)] : Promise mapping from particular deviceID and userID to currently executing promise (if any).
marcin updated the test plan for D12668: Implement peer notifications session creation as outbound on native.
marcin requested review of D12668: Implement peer notifications session creation as outbound on native.
marcin committed rCOMM03ef6d981c88: Add encryptedNotifUtilsAPI on client platforms with mock encryption. (authored by marcin).
Add encryptedNotifUtilsAPI on client platforms with mock encryption.
marcin committed rCOMM29c17ba534bf: Utilise subscription from ThickMemberInfo when building a notif (authored by marcin).
Utilise subscription from ThickMemberInfo when building a notif
marcin committed rCOMMdf8bc22bea17: Implement building encrypted notifications on the client (authored by marcin).
Implement building encrypted notifications on the client
marcin committed rCOMM5447dc6182ef: Move groupping device by platform details and notif info generation promise to… (authored by marcin).
Move groupping device by platform details and notif info generation promise to…
marcin committed rCOMMd5ca587635b3: Implement notification texts generation on the client (authored by marcin).
Implement notification texts generation on the client
marcin committed rCOMM05f0430c81d8: Implement route from MessageData to MessageInfo on the client (authored by marcin).
Implement route from MessageData to MessageInfo on the client
Bump minimal native code version to 149
marcin committed rCOMM261f770b836e: Implement notification types, creation and encryption for APNs notifications (authored by marcin).
Implement notification types, creation and encryption for APNs notifications
marcin committed rCOMM5c88cab342ee: Move android rescinds and badge updates to lib (authored by marcin).
Move android rescinds and badge updates to lib
marcin committed rCOMMcce32d0c7e3e: Move notification creaction and encryption to lib except for APNs noifs. (authored by marcin).
Move notification creaction and encryption to lib except for APNs noifs.
marcin committed rCOMMd08452039fba: Rename cookieID -> cryptoID and deviceToken -> deliveryID (authored by marcin).
Rename cookieID -> cryptoID and deviceToken -> deliveryID
marcin committed rCOMMb5e45e410113: Enable encrypted notifications to have keyservevrID or senderDeviceID (authored by marcin).
Enable encrypted notifications to have keyservevrID or senderDeviceID
marcin committed rCOMM3ddad4e6437a: Introduce EncryptedNotifUtilsAPI and implement it on the keyserver (authored by marcin).
Introduce EncryptedNotifUtilsAPI and implement it on the keyserver
marcin committed rCOMM9ea0d0426470: Move all notif types to lib except for APNs notifs (authored by marcin).
Move all notif types to lib except for APNs notifs
marcin added inline comments to D12572: Add encryptedNotifUtilsAPI on client platforms with mock encryption..
marcin updated the diff for D12572: Add encryptedNotifUtilsAPI on client platforms with mock encryption..
- Return that size limit was violated if notificationPayloadValidator returns false
- Rebase before landing
marcin updated the diff for D12539: Utilise subscription from ThickMemberInfo when building a notif.
- Address nits regarding types
- Rebase before landing
Rebase before landing
marcin updated the diff for D12476: Move groupping device by platform details and notif info generation promise to utils in lib/push.
Rebase before landing
Rebase before landing
Rebase before landing
marcin updated the diff for D12429: Implement notification types, creation and encryption for APNs notifications.
rebase before landig
Rebase before landing
Rebase before landing
Rebase before landing
marcin updated the diff for D12397: Move notification creaction and encryption to lib except for APNs noifs..
Rebase before landing
marcin updated the diff for D12396: Introduce EncryptedNotifUtilsAPI and implement it on the keyserver.
Rebase before landing
marcin updated the diff for D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
Rebase before landing
Rebase before landing
marcin added inline comments to D12539: Utilise subscription from ThickMemberInfo when building a notif.