Accepting assuming landing without console logs
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Sep 25 2024
Sep 25 2024
will added a reviewer for D13455: [tunnelbroker] add errorType patterns for alarming on tunnelbroker for notifs: varun.
will retitled D13455: [tunnelbroker] add errorType patterns for alarming on tunnelbroker for notifs from [tunnelbroker] add errorType patterns for alarming on tunnelbroker
Sep 24 2024
Sep 24 2024
will updated the test plan for D13429: [terraform] sets up cpu and memory and utilization alarms for blob service.
Sep 23 2024
Sep 23 2024
will requested review of D13429: [terraform] sets up cpu and memory and utilization alarms for blob service.
Sep 22 2024
Sep 22 2024
Sep 20 2024
Sep 20 2024
Sep 18 2024
Sep 18 2024
Sep 17 2024
Sep 17 2024
will accepted D13362: [lib] Allow reacting and creating sidebars from failed messages in thick threads.
will added inline comments to D13362: [lib] Allow reacting and creating sidebars from failed messages in thick threads.
Sep 16 2024
Sep 16 2024
will added inline comments to D13339: [lib] Update entry reducer so thick entry infos are properly stored.
will added a comment to D13350: [native][web] use tunnelbroker for online status of thick threaded entries instead of keyserver.
In D13350#376127, @ashoat wrote:Seems like some copy-paste here that could be factored out
will updated the diff for D13354: [web] Disable thick thread entries from showing up in the history modal as history entries.
final rebase
remove unnecesssary Thick thread type import
will updated the diff for D13344: [lib][native][web] send encrypted dms on web and native when editing entries on thick threads.
rebase
keep op time field consistent in edit entry operation. rename lastUpdatedTo field to time
will updated the diff for D13345: [lib][native][web] send encrypted dms on web and native when deleting on thick threads.
update useDeleteEntry to await sending DM op
will updated the diff for D13344: [lib][native][web] send encrypted dms on web and native when editing entries on thick threads.
review feedback
will updated the diff for D13343: [lib][native][web] send encrypted dms on web and native for create entry.
review feedback
review feedback
rebase
will updated the summary of D13343: [lib][native][web] send encrypted dms on web and native for create entry.
Abandoning. Following discussion in https://linear.app/comm/issue/ENG-8745/create-dmoperations-for-restoreentrymessageinfo#comment-8eb5b44d, this is no longer necessary
will updated the diff for D13345: [lib][native][web] send encrypted dms on web and native when deleting on thick threads.
update lastUpdatedTime in delete entry op to be time
Requesting review. Timestamp check included in future diff and will prioritize landing this by organizing code in a future diff
Rerequesting review
In D13340#375962, @tomek wrote:It is a bit confusing to see all this info being sent while deleting an entry. It might be invalid when one user edits an entry while someone else deletes it.
The proper solution would require:
- Modifying the payload to contain just the ID of the deleted entry without too many details
- Introducing a util that provides all the entry infos
- Introducing a separate timestamp for deleted property
This will take some time, and we're short on it, so we should search for a simpler solution.
What we can do for now, is to keep the current approach and introduce a lastUpdatedTime timestamp check.