Page MenuHomePhorge
Feed Search

Search
Use Results
Hide Query

Feb 11 2025

ashoat requested review of D14340: [lib] Use notificationCollapseKey to dedup sidebarCreation notifs in multimediaMessageSpec.
Feb 11 2025, 9:50 AM
ashoat requested review of D14339: [lib] Fix DM push notifs code to fetch message from SQLite instead of Redux.
Feb 11 2025, 9:42 AM
ashoat requested review of D14338: [lib][web] Introduce threadIDIsThick.
Feb 11 2025, 9:32 AM
ashoat requested review of D14337: [keyserver] Only bump last_message_for_unread_check for certain message types.
Feb 11 2025, 9:23 AM
ashoat requested review of D14336: [keyserver] Refactor latest message determination logic.
Feb 11 2025, 9:14 AM
ashoat requested review of D14335: [keyserver][lib] Split generateNotifUserInfoPromise into two.
Feb 11 2025, 9:05 AM
ashoat requested review of D14333: [keyserver] Introduce latestMessageForUnreadCheck to LatestMessageInfo.
Feb 11 2025, 8:47 AM
ashoat requested review of D14332: [keyserver] Consider all new messages in determineLatestMessagesPerThread.
Feb 11 2025, 8:37 AM
ashoat updated the summary of D13828: [lib] Only show reactions to viewer's messages in MessagePreview.
Feb 11 2025, 8:34 AM
ashoat requested review of D14331: [keyserver] Unify LatestMessageInfo type.
Feb 11 2025, 8:28 AM
ashoat requested review of D14330: [keyserver] Update unread checks to use new last_message_for_unread_check column.
Feb 11 2025, 8:23 AM
ashoat requested review of D14329: [keyserver] Code for updating last_message_for_unread_check.
Feb 11 2025, 8:11 AM
ashoat requested review of D14328: [keyserver] Introduce new last_message_for_unread_check column.
Feb 11 2025, 8:09 AM
ashoat accepted D14326: [native] Navigate directly to the secondary device connection screen.
Feb 11 2025, 12:05 AM

Feb 6 2025

ashoat added inline comments to D13996: [native] community joiner modal.
Feb 6 2025, 2:11 AM
ashoat updated the diff for D13996: [native] community joiner modal.

CI

Feb 6 2025, 2:10 AM
ashoat updated the diff for D13919: [lib] Don't bump thin thread timestamp for membership robotext.

Rebase

Feb 6 2025, 2:09 AM
ashoat updated the diff for D13918: [lib] Reactions only bump thread timestamps when reacting to viewer.

Rebase

Feb 6 2025, 2:09 AM
ashoat updated the diff for D13829: [lib] Hide membership robotext from MessagePreview in thin threads.

Rebase

Feb 6 2025, 2:08 AM
ashoat updated the diff for D13828: [lib] Only show reactions to viewer's messages in MessagePreview.

Rebase

Feb 6 2025, 2:08 AM

Feb 5 2025

ashoat added a comment to D13996: [native] community joiner modal.

Keyserver Docker CI build failure is unrelated: ENG-10143: Keyserver Docker build failing on Buildkite CI

Feb 5 2025, 4:46 AM
ashoat updated the diff for D13919: [lib] Don't bump thin thread timestamp for membership robotext.

Rebase

Feb 5 2025, 4:38 AM
ashoat updated the diff for D13918: [lib] Reactions only bump thread timestamps when reacting to viewer.

Rebase

Feb 5 2025, 4:24 AM
ashoat updated the diff for D13829: [lib] Hide membership robotext from MessagePreview in thin threads.

Rebase

Feb 5 2025, 4:21 AM
ashoat updated the diff for D13828: [lib] Only show reactions to viewer's messages in MessagePreview.

Rebase

Feb 5 2025, 4:17 AM
ashoat updated the diff for D13996: [native] community joiner modal.

Review updates

Feb 5 2025, 3:35 AM
ashoat accepted D13996: [native] community joiner modal.

To avoid further review churn on the Flow types (given difference between AnimatedValue and AnimatedInterpolation), I went ahead and made the changes myself

Feb 5 2025, 3:33 AM
ashoat added inline comments to D13996: [native] community joiner modal.
Feb 5 2025, 3:31 AM
ashoat added inline comments to D14204: [native] fix avatars in directory.
Feb 5 2025, 3:06 AM
ashoat requested changes to D14288: [native] Listen for a hide keyboard event on iOS.
Feb 5 2025, 2:54 AM
ashoat added a comment to D14288: [native] Listen for a hide keyboard event on iOS.

This seems like a risky change, as it affects the KeyboardingAvoidingView used across the whole app. Can you expand on the test plan please? Would be good to see more testing done, as well as a deeper analysis of the code to explain why you think this change is safe, both on the level of UX and performance (extra rerenders).

Feb 5 2025, 2:52 AM

Feb 4 2025

ashoat accepted D14280: [proto] Add UserKeys backup fields to RestoreUserRequest.

In the rest of the codebase, if it's easy to rename let's do that too.

Feb 4 2025, 7:55 AM

Jan 31 2025

ashoat requested changes to D14280: [proto] Add UserKeys backup fields to RestoreUserRequest.
Jan 31 2025, 3:13 PM

Jan 30 2025

ashoat added inline comments to D13996: [native] community joiner modal.
Jan 30 2025, 7:02 PM
ashoat requested changes to D14280: [proto] Add UserKeys backup fields to RestoreUserRequest.

Just some questions and rename requests

Jan 30 2025, 7:00 PM
ashoat accepted D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.
Jan 30 2025, 6:56 PM
ashoat accepted D14205: rename fetchAllCommunityInfosWithNames -> fetchNativeDrawerAndDirectoryInfos.
Jan 30 2025, 6:55 PM
ashoat requested changes to D13996: [native] community joiner modal.
Jan 30 2025, 6:51 PM
ashoat requested changes to D14204: [native] fix avatars in directory.
Jan 30 2025, 6:38 PM

Jan 29 2025

ashoat added inline comments to D14273: [native_rust_library] create User Keys backup when restoring user.
Jan 29 2025, 4:41 PM
ashoat committed rCOMMade859e2eea0: [terraform] Bump keyserver image to 1.0.151.
Jan 29 2025, 1:21 AM
ashoat added a reverting change for rCOMMc8be19e7af9f: [lib] Temporarily flip usingRestoreFlow to true: rCOMM49e69023c557: Revert "[lib] Temporarily flip usingRestoreFlow to true".
Jan 29 2025, 12:46 AM
ashoat committed rCOMM49e69023c557: Revert "[lib] Temporarily flip usingRestoreFlow to true".
Jan 29 2025, 12:46 AM
ashoat committed rCOMMe5f4dcd998f0: Revert "[native] Temporary changes for staff release".
Jan 29 2025, 12:46 AM
ashoat added a reverting change for rCOMM085af25722f1: [native] Temporary changes for staff release: rCOMMe5f4dcd998f0: Revert "[native] Temporary changes for staff release".
Jan 29 2025, 12:46 AM
ashoat committed rCOMMa4a7c8d2092c: [native] codeVersion -> 458.
Jan 29 2025, 12:46 AM
ashoat committed rCOMM085af25722f1: [native] Temporary changes for staff release.
Jan 29 2025, 12:46 AM
ashoat committed rCOMMc8be19e7af9f: [lib] Temporarily flip usingRestoreFlow to true.
Jan 29 2025, 12:46 AM
ashoat committed rCOMMf4dfbb2fd6a1: [native] codeVersion -> 457.
Jan 29 2025, 12:46 AM
ashoat committed rCOMMd31a0903fb8e: [web][keyserver] codeVersion -> 151.
Jan 29 2025, 12:45 AM

Jan 28 2025

ashoat accepted D14261: [lib] Check if a community exists.
Jan 28 2025, 4:09 PM

Jan 27 2025

ashoat committed rCOMMc8f92d2f97a7: [terraform] Bump keyserver image to 1.0.150.
Jan 27 2025, 6:20 PM
ashoat added a reverting change for rCOMM5537ac0f061a: [lib] Temporarily flip usingRestoreFlow to true: rCOMMb720e1e22304: Revert "[lib] Temporarily flip usingRestoreFlow to true".
Jan 27 2025, 4:04 PM
ashoat committed rCOMMb720e1e22304: Revert "[lib] Temporarily flip usingRestoreFlow to true".
Jan 27 2025, 4:04 PM
ashoat committed rCOMMb5345885e5b9: Revert "[native] Temporary changes for staff release".
Jan 27 2025, 4:04 PM
ashoat added a reverting change for rCOMM6c71958b4a00: [native] Temporary changes for staff release: rCOMMb5345885e5b9: Revert "[native] Temporary changes for staff release".
Jan 27 2025, 4:04 PM
ashoat committed rCOMM6c71958b4a00: [native] Temporary changes for staff release.
Jan 27 2025, 4:04 PM
ashoat committed rCOMMfcacc647fa3e: [native] codeVersion -> 456.
Jan 27 2025, 4:04 PM
ashoat committed rCOMM5537ac0f061a: [lib] Temporarily flip usingRestoreFlow to true.
Jan 27 2025, 4:04 PM
ashoat committed rCOMMb3ad7870e784: [native] codeVersion -> 455.
Jan 27 2025, 4:04 PM
ashoat committed rCOMMc7bac3a23293: [web][keyserver] codeVersion -> 150.
Jan 27 2025, 4:04 PM
ashoat committed rCOMM2a6292fe5ffa: [native] Add specific commit hash for remote-redux-devtools to yarn.lock.
Jan 27 2025, 4:04 PM

Jan 24 2025

ashoat accepted D14250: [web] Update the login experience.
Jan 24 2025, 1:37 PM
ashoat added a comment to D14241: [native] Fix focus animation on devices with top notches in CameraModal.

Nice catch on this one!!

Jan 24 2025, 1:35 PM
ashoat added a comment to D14234: [native] Migrate focus animation in CameraModal to Reanimated V2 API.

Great work fixing this bug, @angelika!

Jan 24 2025, 1:33 PM
ashoat committed rCOMM693c06a1c5c0: [native] Fix types in CameraModal to be read-only.
Jan 24 2025, 1:26 PM

Jan 14 2025

ashoat added inline comments to D13987: [native] button in community drawer for exploring communities.
Jan 14 2025, 10:50 PM
ashoat added a comment to D14203: [native] Add Flow types for react-native-gesture-handler v2 basic gestures.

Just confirming – you ran prettier --write on this file, right?

Jan 14 2025, 10:49 PM

Jan 13 2025

ashoat accepted D14198: [protos] Add skipPasswordReset field to PrivilegedResetUserPassword.
Jan 13 2025, 4:02 PM
ashoat accepted D14196: [native] Fix SIWE panel size.
Jan 13 2025, 4:01 PM

Jan 10 2025

ashoat closed D14197: [keyserver][script] update script to return tuple of community ID and farcaster channel ID.
Jan 10 2025, 10:17 PM
ashoat committed rCOMM2c2d19399492: [keyserver][script] update script to return tuple of community ID and farcaster… (authored by varun).
Jan 10 2025, 10:17 PM
ashoat accepted D14197: [keyserver][script] update script to return tuple of community ID and farcaster channel ID.
Jan 10 2025, 10:16 PM
ashoat added inline comments to D14196: [native] Fix SIWE panel size.
Jan 10 2025, 8:02 PM
ashoat requested changes to D14196: [native] Fix SIWE panel size.

Some questions

Jan 10 2025, 8:01 PM
ashoat accepted D14194: [native] Handle the restore flow as a part of the registration flow.
Jan 10 2025, 7:55 PM
ashoat added a comment to D14194: [native] Handle the restore flow as a part of the registration flow.

Looks great!!

Jan 10 2025, 7:53 PM
ashoat added a comment to D14195: [native] Migrate VideoPlaybackModal to Reanimated V2 API.

However there are some problems with flow definitions and it’s not a quick fix so created a task for that: https://linear.app/comm/issue/ENG-10079/add-react-native-gesture-handler-v2-flow-definitions and for now I added FlowFixMe comment

Jan 10 2025, 7:37 PM
ashoat accepted D14191: [native] Fix video in VideoPlaybackModal displayed incorrectly.
Jan 10 2025, 7:35 PM

Jan 9 2025

ashoat added inline comments to D14184: [lib] Add timeout to useWaitForConnection() hook.
Jan 9 2025, 2:48 PM
ashoat added a comment to D14187: [native] Fix adding several friends at once.

Thanks for identifying and fixing this bug!

Jan 9 2025, 3:03 AM

Jan 7 2025

ashoat accepted D14181: [keyserver] filter out communities that viewer is a member of or that aren't public.
Jan 7 2025, 11:38 PM
ashoat added inline comments to D14184: [lib] Add timeout to useWaitForConnection() hook.
Jan 7 2025, 5:22 PM
ashoat committed rCOMM3932e8c510c5: [lib] Fix SIWESignatureRequestData union type.
Jan 7 2025, 5:21 PM
ashoat added inline comments to D14179: [lib] Refactor useLogOut to auto-detect logout flow.
Jan 7 2025, 5:18 PM

Dec 25 2024

ashoat added inline comments to D14180: [native] Fall back to v1 login when the user doesn't have a backup.
Dec 25 2024, 4:46 PM
ashoat added inline comments to D14179: [lib] Refactor useLogOut to auto-detect logout flow.
Dec 25 2024, 4:45 PM
ashoat committed rCOMM113111f95d0d: [lib] Remove "a" from "Retrieve a backup key".
Dec 25 2024, 4:44 PM
ashoat accepted D14178: [terraform] Bump staging Identity to 0.48.
Dec 25 2024, 4:44 PM
ashoat accepted D14177: [terraform] Bump prod Identity to 0.47.
Dec 25 2024, 4:43 PM

Dec 24 2024

ashoat committed rCOMMeb31a84bb78a: [landing] Remove Will from team list.
Dec 24 2024, 7:53 PM
ashoat accepted D14181: [keyserver] filter out communities that viewer is a member of or that aren't public.
Dec 24 2024, 6:18 PM

Dec 23 2024

ashoat added inline comments to D13994: [native] community list item component.
Dec 23 2024, 4:20 PM
ashoat accepted D13994: [native] community list item component.
Dec 23 2024, 4:19 PM

Dec 21 2024

ashoat committed rCOMMde65669e2e44: [terraform] Bump keyserver image to 1.0.149.
Dec 21 2024, 8:10 PM
ashoat committed rCOMMcd2b9afc1ccc: Revert "[native] Temporary changes for staff release".
Dec 21 2024, 5:45 PM
ashoat added a reverting change for rCOMMec8443e9e70d: [native] Temporary changes for staff release: rCOMMcd2b9afc1ccc: Revert "[native] Temporary changes for staff release".
Dec 21 2024, 5:45 PM
ashoat committed rCOMM725f61f3d048: [native] codeVersion -> 454.
Dec 21 2024, 5:45 PM
ashoat committed rCOMMec8443e9e70d: [native] Temporary changes for staff release.
Dec 21 2024, 5:45 PM
ashoat committed rCOMM61284c683669: [native] codeVersion -> 453.
Dec 21 2024, 5:45 PM
First
Prev
Next