After running yarn arcpatch D7197, I noticed that the commit before this one is D7155. Does this work depend on D7155? If so, can you specify the stack on Phabricator?
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 27 2023
Mar 27 2023
• jon added a comment to D7201: [web][keyserver] Webpack config and client logic to access opaque-ke2 WASM bindings.
Nothing looks super surprising here, thanks!
ashoat added inline comments to D7201: [web][keyserver] Webpack config and client logic to access opaque-ke2 WASM bindings.
lgtm!
nice this is very helpful
atul published D7203: [keyserver] Update `fetchKnownUserInfos` to include `avatar` field in `UserInfo`s for review.
Fixes after in work in the subsequent diff
rebase before landing
When you're modifying SQLite database on native you should do two things:
- Update create_schema - this code is running on a fresh install/logout user (you did it properly)
- Add new migration which will update this table when existing users will update the app to a newer version. We were adding NOT EXISTS everywhere because of multiple crashes at that time, but I think it should work without this constraint (a lot of refactors were done to avoid problems). If you really want to make this code resistant you can use PRAGMA table_info() to check if the column exists and then execute ALTER TABLE.
atul committed rCOMMc47a3162493b: Bump openssl from 0.10.44 to 0.10.48 in /services/commtest (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMMca10b4527b7d: Bump openssl from 0.10.42 to 0.10.48 in /services/tunnelbroker (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Is this diff still in [draft] state? Or is it ready to review?
Is this diff still in [draft] state? Or is it ready to review?
address atuls comments
ginsu updated the diff for D7137: [native] render thread avatars for parent/child threads in thread settings.
rebase before landing/updated order in stack so I can unblock landing this diff
ginsu updated the summary of D7137: [native] render thread avatars for parent/child threads in thread settings.
ginsu added a comment to D7137: [native] render thread avatars for parent/child threads in thread settings.
Accepting to unblock but the pattern of copy-paste is concerning
Thanks for submitting!! I am clueless in Rust and this appears mostly Rust, so I will resign
• jon added inline comments to D7155: [Native] Migrate native_rust_library to use identity client stubs.
• jon added inline comments to D7155: [Native] Migrate native_rust_library to use identity client stubs.
• kuba added inline comments to D7141: [keyserver] Display edited message in the sidebar if the source message is edited.
Rebase to master
Set id to readonly
ginsu updated the diff for D7135: [native] render thread avatar in CHANNEL AVATAR thread settings section.
rebase before landing
rebase before landing
Rebase
• kuba updated the diff for D7127: [lib][keyserver] Introduce new threadPermissions types for editing messages.
Rebase
marcin updated the diff for D7125: Use new notifications permission API to modify push notifs settings alerts on Android 13.
Rebase before landing
marcin updated the diff for D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
Rebase before landing
marcin updated the diff for D7106: Native Java code to request notifications permissions from JS on Android 13.
Rebase before landing
Rebase before landing
marcin requested review of D7193: Save message instantly to redux for both foregrounded and backgrounded app.
Clarify that it's in the timezone of the keyserver
Requesting changes for inline comment, and for the discussion previously in D7076
marcin updated the diff for D7125: Use new notifications permission API to modify push notifs settings alerts on Android 13.
Rebase before landing
marcin updated the diff for D7106: Native Java code to request notifications permissions from JS on Android 13.
Rebase before landing
Rebase before landing