Although it's worth noting that the stemmer will remove the s from it's anyway, since it's treating it as a modifying suffix.
So after applying Intl.Segmenter.segment and natural.PorterStemmer.stem we get

['hello', 'test', "it'", 'work', '😄', 'test']

Answering to comments on D7076:

natural.PorterStemmer.tokenizeAndStem uses AggressiveTokenizer by default (PorterStemmer gets this function from Stemmer that it extendes, and Stemmer uses AggressiveTokenizer).

Added invariant & removed redundant error catching.

Removed redundant error payload & moved redux types to the end of the file

Rebase before landing

Sleep to ensure logged out model disappears before the prompt launches. Rebase before landing

Rebase before landing

Rebase before landing

Added keys to the components list to prevent key error

In the test plan for the Confirm migration for new clients already with the column works

I'm not entirely sure if we really even need to consider a case where a new client will already have the column besides me in development work, so I can also just remove that check entirely and just add the column. I ran into this inconsistency while working off of my modified schema and running a migration on top of that

Changed the way of displaying new content of edited message in the sidebar

Removed accidentally added empty line

Removed 'Edited' label from the pending thread to match D7141 changes

Change do-while to a while(true), make messages constant

Removed redundant code

Rebase, move creating PRIMARY KEY

In D7065#212932, @ashoat wrote:

In D7065#212101, @ashoat wrote:

Will this affect the height of the item? Have you made the necessary changes to the height determination code (textMessageItemHeight)?

Requesting changes for my question above

Added messageHeight of edited messages

Looks good generally, but would be great if @atul could review the redux-persist migration since it's all client DB stuff and is based on a migration he previously wrote

Hmm it seems like we'll need to refactor this after getAvatarForUser gets converted to a hook (see my chat message)

rebase and land

This was easier than I realized!! Thanks for renaming everything. Will leave the diff on others' queues to get some other perspectives

It seems like this diff does some moving/refactoring and also introduces some new stuff, which makes it hard to review. More context: https://www.notion.so/commapp/Moving-code-around-bbb551c4350b4d5cb553c6751be44314?pvs=4

The logic seems good to me

rebase before landing

Address feedback and add_pinned_count_column_to_threads after speaking with @kamil offline