This has literally no effect
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 10 2023
May 10 2023
May 9 2023
May 9 2023
could you link the figma?
lgtm thanks for fixing this!
May 8 2023
May 8 2023
ginsu committed rCOMMe32fedf8b34d: [lib/native] add more icons to comm icon pack (authored by ginsu).
[lib/native] add more icons to comm icon pack
The code looks good, but I actually pitched this idea to @ashoat initially and we talked about finding another solution. Thinking out lout right now, but wouldn't it be possible to decouple this cycle by moving defaultNotificationPayloadValidator out of account-types and possibly into validation-utils? I think this would also be better since there are no other validators in account-utils and account-utils should exclusively just be for types
Does the sizing look right? Can't really tell from the images from the Test Plan, but as long as things looked right during your testing.
I actually just double checked using the inspector tool, and noticed that these new icons are actually a tad bit smaller, will have ted fix this and send me some new icons
May 6 2023
May 6 2023
May 2 2023
May 2 2023
May 1 2023
May 1 2023
patched in the changes and played around with the views and everything looks good, no more bounds being overflown. Thanks for fixing this
ginsu committed rCOMM0cdcd32df3be: [native] change useUploadSelectedMedia callback return type from void to mixed (authored by ginsu).
[native] change useUploadSelectedMedia callback return type from void to mixed
Apr 30 2023
Apr 30 2023
ginsu committed rCOMM083b8d82f0a1: [native] improve user experience for remvoing an avatar (authored by ginsu).
[native] improve user experience for remvoing an avatar
ginsu committed rCOMM3bb311aac241: [native] hardcode avatar feature flag to true (authored by ginsu).
[native] hardcode avatar feature flag to true
ginsu committed rCOMM6f746f5b1126: [native] introduce thread avatar camera modal (authored by ginsu).
[native] introduce thread avatar camera modal
ginsu committed rCOMM6309c77470c9: [native] improve factoring out redundant logic for saving an image thread avatar (authored by ginsu).
[native] improve factoring out redundant logic for saving an image thread avatar
ginsu committed rCOMMf65bfddfcd95: [native] move navigate to emoji thread avatar creation function to be within… (authored by ginsu).
[native] move navigate to emoji thread avatar creation function to be within…
ginsu committed rCOMMc29df39551af: [native] have upload thread avatar processing/uploading loader only appear for… (authored by ginsu).
[native] have upload thread avatar processing/uploading loader only appear for…
ginsu committed rCOMMbb875e7f83b4: [native] move selectFromGalleryAndUpdateThreadAvatar to edit thread avatar… (authored by ginsu).
[native] move selectFromGalleryAndUpdateThreadAvatar to edit thread avatar…
rebase before landing
rebase before landing
rebase before landing
ginsu updated the diff for D7645: [native] improve factoring out redundant logic for saving an image thread avatar.
rebase before landing
ginsu updated the diff for D7644: [native] move navigate to emoji thread avatar creation function to be within edit thread avatar.
rebase before landing
ginsu updated the diff for D7643: [native] have upload thread avatar processing/uploading loader only appear for thread being updated.
rebase before landing
ginsu updated the diff for D7684: [native] move selectFromGalleryAndUpdateThreadAvatar to edit thread avatar provider.
rebase before landing
address comments
ginsu updated the diff for D7643: [native] have upload thread avatar processing/uploading loader only appear for thread being updated.
address comments
Apr 28 2023
Apr 28 2023
ginsu updated the summary of D7645: [native] improve factoring out redundant logic for saving an image thread avatar.
ginsu updated the diff for D7645: [native] improve factoring out redundant logic for saving an image thread avatar.
rebase
ginsu updated the diff for D7644: [native] move navigate to emoji thread avatar creation function to be within edit thread avatar.
rebase
ginsu retitled D7643: [native] have upload thread avatar processing/uploading loader only appear for thread being updated from [native] move selecting from gallery logic from avatar hooks to edit thread avatar to [native] have upload thread avatar processing/uploading loader only appear for thread being updated.
ginsu updated the diff for D7643: [native] have upload thread avatar processing/uploading loader only appear for thread being updated.
split diff into two (this is part 2 and part 1 is handeled by D7684)
ginsu committed rCOMMd3224971ec9e: [native] have saving thread avatar loaders only appear for thread being updated (authored by ginsu).
[native] have saving thread avatar loaders only appear for thread being updated
ginsu updated the diff for D7679: [native] have saving thread avatar loaders only appear for thread being updated.
one more rebase before landing
ginsu committed rCOMMfc5e55e7e858: [native] introduce edit thread avatar provider (authored by ginsu).
[native] introduce edit thread avatar provider
one more rebase
ginsu updated the diff for D7679: [native] have saving thread avatar loaders only appear for thread being updated.
rebase before landing
rebase before landing
Apr 27 2023
Apr 27 2023
simplify callback
split diff (this is the first part)
[native] introduce user avatar camera modal
ginsu committed rCOMM87e0e3e2ddd4: [native] make handlePhotoCapture return mixed instead of void (authored by ginsu).
[native] make handlePhotoCapture return mixed instead of void
ginsu committed rCOMMc8ae0af5dff1: [native] improve factoring out redundant logic for saving an image user avatar (authored by ginsu).
[native] improve factoring out redundant logic for saving an image user avatar
address comments
ginsu added a comment to D7628: [native] improve factoring out redundant logic for saving an image user avatar.
It would be good to explain the reason for the changes here. Are these changes being made because you're going to reuse the factored-out code in a later diff in the stack, so it makes sense to factor out the shared logic here?
ginsu updated the diff for D7628: [native] improve factoring out redundant logic for saving an image user avatar.
address comments/rebase before landing
[web] turn off dummy avatar feature flag
ginsu committed rCOMMc045a051665e: [web] fix image avatar image being stretched (authored by ginsu).
[web] fix image avatar image being stretched
rebase before landing
rebase before landing
ginsu committed rCOMMa73447d07684: [native] move navigate to emoji user avatar creation function to be within edit… (authored by ginsu).
[native] move navigate to emoji user avatar creation function to be within edit…
ginsu committed rCOMMa7a94f7b5f57: [native] move selecting from gallery logic from avatar hooks to edit user… (authored by ginsu).
[native] move selecting from gallery logic from avatar hooks to edit user…
ginsu updated the diff for D7622: [native] move navigate to emoji user avatar creation function to be within edit user avatar.
rebase before landing
ginsu updated the diff for D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.
rebase before landing