Accepting since comments are all addressed, but it looks like we'll have to revise this after we adjust all encryption to occur on a single blob, instead of being field-by-field. Might be a good idea to re-request review after that

(Accepting since comments are all addressed, but it looks like we'll have to revise this after we adjust all encryption to occur on a single blob, instead of being field-by-field. Might be a good idea to re-request review after that)

Passing to your queue

Confused why we're ignoring thumbnailURI for encrypted videos

Love a red diff!

Passing back to your queue, in part for feedback above, but mostly for the changes I requested in D7771

You mentioned in D7774 that I should not call something else from an effect.
I don't really understand how I could change this effect to a callback. If I do it like in ex useEditMessage, and return a return React.useCallback, it will still have to be called inside of an effect in the calling code, because I need to fetch messages whenever query or threadID or cursor change.

Ah dang, good thing ' didn't work...

The whole point of using ' is so that we're using the apostrophe character, not the single-quote character. Please use ’

Back to your queue for one question

Generally looks good, but confused about some of the changes to existing modals...

1. Pass address in as well. This can be concluded from the message, but processing that seems wasteful since we have the data in SIWEPanel
2. Now that we have 3 strings, I'm using an object instead of a list of params

Good find @michal! It seems like simply adding the focus-trap-react NPM package, and then wrapping web/modals/modal.react.js in a <FocusTrap> component would make all of our modals "trap focus". This is probably a good thing to do for all modals, and I think it would solve the problem here.

(I think we should do this in a callback rather than an effect, but I think I mentioned that in another diff where I requested changes)

Thanks for iterating on the types so much! Some small comments inline; please address before landing

Mostly questions

Confused about the most recent revision

I should have been more specific

All other icons are filled in.

I can see that on figma that all buttons are outlines and there's a bar between reactions and the rest of the buttons. Not sure if it will be handled on some other occasion or if there's some more context on this, but I feel like they should be at least consistent.

It's true that diffs should be small, but that is just an "instrumental goal". The real goal is to make diffs readable and clear to reviewers, and usually small diffs are more readable and clear. But that's not always the case... often, splitting a diff into two can make it harder to review, especially if the two parts depend closely on each other. In this case I agree with @michal that it would be easier to review if D7824 and this diff were merged.