Page MenuHomePhorge
Feed Search

Jan 11 2024

tomek updated the diff for D10584: [lib][native][web] Expose identity API by using a context.

Rebase

Jan 11 2024, 2:17 PM
tomek added inline comments to D10584: [lib][native][web] Expose identity API by using a context.
Jan 11 2024, 2:09 PM
tomek added inline comments to D10584: [lib][native][web] Expose identity API by using a context.
Jan 11 2024, 2:07 PM
tomek updated the diff for D10584: [lib][native][web] Expose identity API by using a context.

Readonly

Jan 11 2024, 10:25 AM
tomek updated the diff for D10584: [lib][native][web] Expose identity API by using a context.

Rever import ordering change

Jan 11 2024, 10:24 AM
tomek updated the diff for D10584: [lib][native][web] Expose identity API by using a context.

Address review

Jan 11 2024, 10:14 AM
tomek added a comment to D10584: [lib][native][web] Expose identity API by using a context.

It's unfortunate how different native and web are, but I think it makes sense given the technical decisions we've made

Jan 11 2024, 9:34 AM
tomek accepted D10598: [lib][native] Move all the Redux-binding code out of action-utils.js.
Jan 11 2024, 9:27 AM
tomek accepted D10597: [lib] Move keyserver session recovery utils to recovery-utils.js.
Jan 11 2024, 9:21 AM
tomek accepted D10593: [lib][native][web] Move DispatchActionPromise to a separate file.
Jan 11 2024, 8:45 AM
tomek accepted D10599: [lib][web][native] rename changeUserPassword -> changeKeyserverUserPassword.
Jan 11 2024, 8:39 AM
tomek accepted D10592: [web] make sure all tabs and worker are operating on the same web version.

When we receive the version we compare it, if it's different this tab is old, we refresh it - download the newest web app version, and connect to the new worker.

Are there any risks here? Can the refresh fail, or be stopped by a user?

Jan 11 2024, 8:35 AM

Jan 10 2024

tomek added inline comments to D10584: [lib][native][web] Expose identity API by using a context.
Jan 10 2024, 5:11 PM
tomek planned changes to D10584: [lib][native][web] Expose identity API by using a context.
Jan 10 2024, 3:57 PM
tomek updated the diff for D10584: [lib][native][web] Expose identity API by using a context.

Rebase

Jan 10 2024, 3:56 PM
tomek updated the diff for D10449: [native] Expose get keyserver keys Identity RPC.

Format

Jan 10 2024, 3:34 PM
tomek updated the diff for D10449: [native] Expose get keyserver keys Identity RPC.

Rebase

Jan 10 2024, 3:32 PM
tomek updated the diff for D10403: [web] Expose get keyserver keys Identity RPC.

Rebase

Jan 10 2024, 3:24 PM
tomek added a reviewer for D10584: [lib][native][web] Expose identity API by using a context: marcin.
Jan 10 2024, 3:05 PM
tomek updated the diff for D10585: [lib] Get keyserver keys in a handler.

Improve error handling

Jan 10 2024, 2:35 PM
tomek updated the diff for D10584: [lib][native][web] Expose identity API by using a context.

Use event emitter

Jan 10 2024, 2:16 PM
tomek requested review of D10585: [lib] Get keyserver keys in a handler.
Jan 10 2024, 9:54 AM
tomek added inline comments to D10584: [lib][native][web] Expose identity API by using a context.
Jan 10 2024, 9:13 AM

Jan 9 2024

tomek updated the summary of D10584: [lib][native][web] Expose identity API by using a context.
Jan 9 2024, 5:18 PM
tomek updated the diff for D10584: [lib][native][web] Expose identity API by using a context.

Fix Flow

Jan 9 2024, 5:02 PM
tomek added 1 blocking reviewer(s) for D10584: [lib][native][web] Expose identity API by using a context: varun.
Jan 9 2024, 4:58 PM
tomek accepted D10583: [lib][native][web] Move some types and basic functions out of action-utils.js.
Jan 9 2024, 4:57 PM
tomek accepted D10579: [lib] Separate out keyserver utils in action-utils.js into a separate file.
Jan 9 2024, 4:40 PM
tomek requested review of D10584: [lib][native][web] Expose identity API by using a context.
Jan 9 2024, 4:21 PM
tomek added inline comments to D10352: [web] dispatch deleteIdentityAction.
Jan 9 2024, 11:33 AM
tomek accepted D10352: [web] dispatch deleteIdentityAction.
Jan 9 2024, 10:59 AM

Jan 8 2024

tomek added inline comments to D10202: [lib] scaffolding for delete identity account.
Jan 8 2024, 3:15 PM
tomek updated the diff for D10449: [native] Expose get keyserver keys Identity RPC.

Fix error handling and capturing

Jan 8 2024, 1:33 PM
tomek updated the diff for D10403: [web] Expose get keyserver keys Identity RPC.

Rebase

Jan 8 2024, 1:23 PM
tomek requested changes to D10352: [web] dispatch deleteIdentityAction.
Jan 8 2024, 11:44 AM
tomek accepted D10202: [lib] scaffolding for delete identity account.
Jan 8 2024, 11:29 AM
tomek added inline comments to D10484: [lib][web][native] Create defaultKeyserverInfo.
Jan 8 2024, 7:46 AM

Dec 22 2023

tomek updated the test plan for D10403: [web] Expose get keyserver keys Identity RPC.
Dec 22 2023, 4:01 PM
tomek updated the diff for D10403: [web] Expose get keyserver keys Identity RPC.

Modify function signature

Dec 22 2023, 4:01 PM
tomek requested review of D10449: [native] Expose get keyserver keys Identity RPC.
Dec 22 2023, 3:34 PM
tomek planned changes to D10403: [web] Expose get keyserver keys Identity RPC.
Dec 22 2023, 2:20 PM
tomek added a comment to D10440: [lib] rename register -> keyserver register.

Wondering about the consequences of this rename. It feels like it could break the compatibility of our reports - an older report could contain one of registerActionTypes actions that can't be recognized by the more recent code.

Dec 22 2023, 1:26 PM
tomek accepted D10439: [web] avoid initializing already initialized WASM module.
Dec 22 2023, 11:03 AM
tomek added a comment to D10434: [lib] Move `socketPreferredEndpoints` to `httpPreferredEndpoints`.

Wondering about the impact on the keyserver - if all the clients use HTTP, it might result in a lot of open HTTP connections. Also, from the client's point of view, it might result in a lot of open connections (probably more than a browser allows). So I think we should move only some requests to HTTP, but I might be wrong.

Dec 22 2023, 9:56 AM

Dec 21 2023

tomek added a comment to D10403: [web] Expose get keyserver keys Identity RPC.

Debugged it a bit and figured out what's going on. It seems like the Identity service doesn't recognize ashoatKeyserverID to be an ID of Ashoat's user. Instead, in identity-users table there's an entry for the user whose value is some UUID (different for staging and prod). After using the ID from the table, this code works correctly.

Dec 21 2023, 11:03 AM
tomek added a comment to D10403: [web] Expose get keyserver keys Identity RPC.

what's not working?

Dec 21 2023, 10:31 AM
tomek requested changes to D10202: [lib] scaffolding for delete identity account.
Dec 21 2023, 9:14 AM
tomek added inline comments to D10357: [web] introduce calculateNavigationSidebarTooltipSize.
Dec 21 2023, 8:58 AM
tomek planned changes to D10338: [web][native] Download invite link blob and use it as an override.
Dec 21 2023, 8:45 AM

Dec 20 2023

tomek accepted D10332: [lib][web][native] Stop logging out from the Socket.
Dec 20 2023, 12:27 PM
tomek accepted D10287: [lib] Add connectionIssue field.
Dec 20 2023, 12:11 PM

Dec 19 2023

tomek requested review of D10403: [web] Expose get keyserver keys Identity RPC.
Dec 19 2023, 3:32 PM
tomek accepted D10331: [lib] Call logout when connectionIssue is set.
Dec 19 2023, 2:35 PM
tomek accepted D10396: [WASM] improve error logging.
Dec 19 2023, 2:23 PM
tomek accepted D10395: [web] don't log out user when processing draft store ops fails.

I would guess that failing to process the reports also shouldn't cause clearing the db - if we fail the operation, we won't save a report, and by clearing the db we're making things a little worse.

Dec 19 2023, 2:21 PM

Dec 15 2023

tomek added inline comments to D10202: [lib] scaffolding for delete identity account.
Dec 15 2023, 4:49 PM
tomek accepted D10305: [web] improve error handling when setting/getting userID.
Dec 15 2023, 2:25 PM
tomek planned changes to D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.

This diff still has an issue: when calling a new keyserver, it returns sessionChange which causes setNewSession to be dispatched - this results in the keyserver being added to a store in an incorrect way and breaks more things down the line.

Dec 15 2023, 12:35 PM
tomek resigned from D10341: [emscripten] Switch Emscripten CI job to autoscaling runners.
Dec 15 2023, 12:27 PM
tomek accepted D10202: [lib] scaffolding for delete identity account.
Dec 15 2023, 12:25 PM
tomek accepted D10353: [terraform] Bump Blob service to 1.1.0 on prod.
Dec 15 2023, 12:06 PM
tomek requested changes to D10352: [web] dispatch deleteIdentityAction.
Dec 15 2023, 12:05 PM
tomek added a comment to D10157: [lib] Fix Logout not working and state difference after invalid session downgrade.
In D10157#299660, @inka wrote:

I wanted to move reducing loading statuses to web and native reducers altogether, but I couldn't overcome a flow problem:
I don't want to copy the reduceLoadingStatuses reducer to web and native, so it is located in lib. It takes an action: BaseAction. I was unable to type it in a way that wouldn't cause errors. If I make the action be an inexact BaseAction, like flow docs suggest: action: {...BaseAction, ...}, then I get errors about read-only properties, as the action I'm passing into the function has nested read-only fields, and the action that is being taken by the reducer was stripped of all read-only.
This works, because setNewSessionActionType, logOutActionTypes and deleteAccountActionTypes are in BaseAction
I know this is not ideal, but it fixes the issue, and is way less hacky than the previous solution.

Dec 15 2023, 10:24 AM
tomek accepted D10157: [lib] Fix Logout not working and state difference after invalid session downgrade.

Looks a lot cleaner!

Dec 15 2023, 10:23 AM

Dec 14 2023

tomek requested review of D10338: [web][native] Download invite link blob and use it as an override.
Dec 14 2023, 3:45 PM

Dec 13 2023

tomek accepted D10326: Don't add nullish id field to badgeonly notification payload.
Dec 13 2023, 5:46 PM
tomek updated the diff for D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.

Probably fix the override. This still requires a lot of testing and thinking about
memoization, but it isn't broken in an obvious way.

Dec 13 2023, 2:33 PM
tomek accepted D10306: [web] avoid race condition while deleting database.
Dec 13 2023, 1:01 PM
tomek requested changes to D10305: [web] improve error handling when setting/getting userID.
Dec 13 2023, 12:59 PM
tomek accepted D10300: [web] avoid calling worker with empty store ops.
Dec 13 2023, 12:52 PM
tomek accepted D10309: [web/native/lib] Combine openSocketSelector from web and native.
Dec 13 2023, 12:51 PM
tomek accepted D10310: [native] Fix failing base64 decode for thumbhash.
Dec 13 2023, 12:47 PM
tomek accepted D10244: [web] add gRPC client wrapper.
Dec 13 2023, 12:44 PM

Dec 12 2023

tomek planned changes to D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.
Dec 12 2023, 2:15 PM
tomek updated the diff for D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.

Use optional

Dec 12 2023, 1:30 PM
tomek requested review of D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.
Dec 12 2023, 1:04 PM
tomek requested review of D10308: [keyserver] Modify link verification so that it works with users that aren't logged in to a keyserver.
Dec 12 2023, 11:25 AM
tomek requested review of D10307: [lib] Do not provide overrides when we already know a keyserver.
Dec 12 2023, 11:00 AM
tomek updated the diff for D10290: [lib] Modify link verification to call the proper keyserver.

Use the correct key in overrides. Tested it by specifying keyserver override in web link
handler.

const validateLink = useVerifyInviteLink({
  keyserverID: ashoatKeyserverID,
  keyserverURL: 'http://localhost:3000/keyserver',
});

This calls the proper endpoint, but causes some other issues - e.g. invite link
verification assumes that a user is logged in, which isn't always true when using an invite
link. Going to fix this in the next diffs.

Dec 12 2023, 9:23 AM
tomek accepted D10262: Don't overwrite original notification with error message notification.
Dec 12 2023, 8:55 AM
tomek accepted D10253: [web] Update AddUsersList to call useUserSearchIndex.
Dec 12 2023, 8:31 AM
tomek accepted D10292: [lib][web][native] Simplify logout call.
Dec 12 2023, 8:22 AM

Dec 11 2023

tomek requested review of D10290: [lib] Modify link verification to call the proper keyserver.
Dec 11 2023, 5:37 PM

Dec 8 2023

tomek closed D10248: [lib] Introduce keyserver connection handler.
Dec 8 2023, 3:24 PM
tomek committed rCOMM37a9dfc0bb1d: [lib] Introduce keyserver connection handler.
Dec 8 2023, 3:24 PM
tomek requested review of D10248: [lib] Introduce keyserver connection handler.
Dec 8 2023, 1:33 PM
tomek accepted D10222: [web] add missing `userID` param.
Dec 8 2023, 12:43 PM
tomek requested changes to D10244: [web] add gRPC client wrapper.
Dec 8 2023, 12:35 PM

Dec 7 2023

tomek accepted D10211: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync-spec`.
Dec 7 2023, 2:53 PM
tomek accepted D10204: [web] remove `CommQueryExecutor` code.
Dec 7 2023, 10:52 AM
tomek accepted D10203: [web] rename `WorkerConnectionProxy` file to match convention.
Dec 7 2023, 10:45 AM
tomek added inline comments to D10202: [lib] scaffolding for delete identity account.
Dec 7 2023, 10:42 AM

Dec 6 2023

tomek requested review of D10206: [keyserver] Set a job that synchronizes links with blobs.
Dec 6 2023, 3:17 PM
tomek requested review of D10205: [keyserver] Add a function that synchronizes keyserver's invite links with blobs.
Dec 6 2023, 2:31 PM
tomek planned changes to D10134: [keyserver] Create a blob while adding / editing an invite link.

I'm going to check the option of using MariaDB transactions to minimize the number of possible race conditions

Dec 6 2023, 9:44 AM

Dec 5 2023

tomek accepted D10191: [web] make database errors more descriptive.
Dec 5 2023, 1:54 PM
tomek requested changes to D10157: [lib] Fix Logout not working and state difference after invalid session downgrade.

This solution is hacky - we're discarding loading statuses of requests that will be resolved later. Instead, we should reduce loading statuses before we check invalidSessionDowngrade.

Dec 5 2023, 1:41 PM
tomek accepted D10189: [keyserver] Fix error when changing thread description.
Dec 5 2023, 1:20 PM
tomek accepted D10174: [native] Remove async IIFE in CommunityDrawerContent effect.

I don't think there was a good reason behind this await

Dec 5 2023, 1:13 PM
tomek accepted D10163: [web] Return dispatchCreateSubchannel directly in Stepper.Item nextProps.
Dec 5 2023, 1:07 PM