Page MenuHomePhabricator
Feed Advanced Search

Sep 2 2024

varun closed D13203: [terraform] add PITR to dynamodb tables.
Sep 2 2024, 6:59 PM
varun committed rCOMM30e894ea8f04: [terraform] add PITR to dynamodb tables (authored by varun).
[terraform] add PITR to dynamodb tables
Sep 2 2024, 6:59 PM
varun added inline comments to D13203: [terraform] add PITR to dynamodb tables.
Sep 2 2024, 6:59 PM
varun added a comment to D13209: [keyserver] add migration type to migrations.

if a dev is introducing a new migration how will they know which migrationType variant to use? can we instead introduce an optional field in Migration to override the default behavior?

Sep 2 2024, 6:50 PM
varun accepted D13208: [keyserver] convert migrations from map of tuples to list of objects.
Sep 2 2024, 6:46 PM
varun resigned from D13172: [keyserver] run a temporary express health check server during migration for AWS load balancer health checks.

i don't know flow too well, unfortunately

Sep 2 2024, 6:44 PM

Aug 28 2024

varun requested review of D13203: [terraform] add PITR to dynamodb tables.
Aug 28 2024, 9:30 AM

Aug 23 2024

varun closed D13139: [lib] address feedback from D13098.
Aug 23 2024, 9:50 AM
varun committed rCOMMec66fa63d98a: [lib] address feedback from D13098 (authored by varun).
[lib] address feedback from D13098
Aug 23 2024, 9:50 AM

Aug 22 2024

varun accepted D13143: [native][web] Fix crash due to getConfig being called before ready.
Aug 22 2024, 1:05 PM
varun requested review of D13139: [lib] address feedback from D13098.
Aug 22 2024, 10:28 AM
varun added inline comments to D13098: [lib] modify FC cache to store username and pfp url.
Aug 22 2024, 10:08 AM
varun closed D13098: [lib] modify FC cache to store username and pfp url.
Aug 22 2024, 10:04 AM
varun closed D13097: [lib] getFarcasterUsernamess -> getFarcasterUsers.
Aug 22 2024, 10:04 AM
varun committed rCOMMbd07096b3e65: [lib] modify FC cache to store username and pfp url (authored by varun).
[lib] modify FC cache to store username and pfp url
Aug 22 2024, 10:04 AM
varun committed rCOMMa12edb902185: [lib] getFarcasterUsernamess -> getFarcasterUsers (authored by varun).
[lib] getFarcasterUsernamess -> getFarcasterUsers
Aug 22 2024, 10:04 AM
varun closed D13086: [lib] useENSResolvedAvatar -> useResolvedAvatar.
Aug 22 2024, 10:04 AM
varun committed rCOMMc237fde2261d: [lib] useENSResolvedAvatar -> useResolvedAvatar (authored by varun).
[lib] useENSResolvedAvatar -> useResolvedAvatar
Aug 22 2024, 10:04 AM
varun closed D13038: [lib] rename PrimaryDeviceLogout -> DeviceLogout.
Aug 22 2024, 9:24 AM
varun closed D13037: [native] empty bottom sheet for linked devices.
Aug 22 2024, 9:24 AM
varun committed rCOMM8b5a8fe5aad0: [lib] rename PrimaryDeviceLogout -> DeviceLogout (authored by varun).
[lib] rename PrimaryDeviceLogout -> DeviceLogout
Aug 22 2024, 9:24 AM
varun committed rCOMMd2ec3efd9b1d: [native] empty bottom sheet for linked devices (authored by varun).
[native] empty bottom sheet for linked devices
Aug 22 2024, 9:24 AM
varun closed D12907: [native] linked devices component.
Aug 22 2024, 9:24 AM
varun closed D12884: [native] replace keyserver using qr code auth.
Aug 22 2024, 9:24 AM
varun committed rCOMMd56065181724: [native] linked devices component (authored by varun).
[native] linked devices component
Aug 22 2024, 9:24 AM
varun closed D13035: [lib] rename getForeignPeerDevices -> getForeignPeerDeviceIDs.
Aug 22 2024, 9:24 AM
varun committed rCOMMe4c818e7ef76: [native] replace keyserver using qr code auth (authored by varun).
[native] replace keyserver using qr code auth
Aug 22 2024, 9:24 AM
varun closed D12809: [lib] add new selector and function to get own user's keyserver device ID.
Aug 22 2024, 9:24 AM
varun committed rCOMM4679fd50c9c8: [lib] rename getForeignPeerDevices -> getForeignPeerDeviceIDs (authored by varun).
[lib] rename getForeignPeerDevices -> getForeignPeerDeviceIDs
Aug 22 2024, 9:24 AM
varun closed D12805: [lib] introduce new device list function to replace keyserver device.
Aug 22 2024, 9:24 AM
varun committed rCOMMd433919a538e: [lib] add new selector and function to get own user's keyserver device ID (authored by varun).
[lib] add new selector and function to get own user's keyserver device ID
Aug 22 2024, 9:24 AM
varun committed rCOMMc65be4f84cff: [lib] introduce new device list function to replace keyserver device (authored by varun).
[lib] introduce new device list function to replace keyserver device
Aug 22 2024, 9:24 AM
varun closed D12734: [lib] add device type to qr code URL.
Aug 22 2024, 9:24 AM
varun committed rCOMMc2b7851036f3: [lib] add device type to qr code URL (authored by varun).
[lib] add device type to qr code URL
Aug 22 2024, 9:24 AM
varun added a comment to D13038: [lib] rename PrimaryDeviceLogout -> DeviceLogout.

Good point. I guess you're right: we're not using this code in prod yet: its existing usage for primary device logout is hidden behind the isDev flag.

Aug 22 2024, 9:15 AM
varun accepted D13126: [lib] Introduce UserIdentityCache.
Aug 22 2024, 8:24 AM

Aug 21 2024

varun accepted D13117: [lib] Make FarcasterDataHandler go through useFindUserIdentities.
Aug 21 2024, 7:43 AM
varun accepted D13130: [identity] Query reserved usernames in concurrent batches.
Aug 21 2024, 7:38 AM
varun accepted D13129: [comm-lib] Add util to split vec into n chunks.
Aug 21 2024, 7:28 AM

Aug 19 2024

varun added reviewers for D13102: [native] get farcaster avatar selection working from profile: ashoat, tomek.
Aug 19 2024, 7:37 AM
varun updated the test plan for D13100: [native] add farcaster avatar URL to registration workflow.
Aug 19 2024, 7:36 AM
varun updated the test plan for D13098: [lib] modify FC cache to store username and pfp url.
Aug 19 2024, 7:35 AM
varun added reviewers for D13097: [lib] getFarcasterUsernamess -> getFarcasterUsers: ashoat, tomek.
Aug 19 2024, 7:35 AM
varun updated the test plan for D13097: [lib] getFarcasterUsernamess -> getFarcasterUsers.
Aug 19 2024, 7:25 AM
varun updated the summary of D13102: [native] get farcaster avatar selection working from profile.
Aug 19 2024, 7:24 AM
varun published D13102: [native] get farcaster avatar selection working from profile for review.
Aug 19 2024, 7:23 AM
varun published D13100: [native] add farcaster avatar URL to registration workflow for review.
Aug 19 2024, 7:19 AM
varun published D13098: [lib] modify FC cache to store username and pfp url for review.
Aug 19 2024, 7:18 AM
varun closed D13036: [native] make SecondaryDeviceQRCodeScanner dismissible.
Aug 19 2024, 7:17 AM
varun committed rCOMM06326715f289: [native] make SecondaryDeviceQRCodeScanner dismissible (authored by varun).
[native] make SecondaryDeviceQRCodeScanner dismissible
Aug 19 2024, 7:17 AM
varun published D13097: [lib] getFarcasterUsernamess -> getFarcasterUsers for review.
Aug 19 2024, 7:17 AM

Aug 16 2024

varun accepted D13095: [terraform] remove unnecessary redeploy.
Aug 16 2024, 12:06 PM
varun added a comment to D13096: [terraform] include keyserver logs on keyserver init for qr code for self-host aws-deploy script.

I think it's fine, was just curious

Aug 16 2024, 12:00 PM

Aug 15 2024

varun accepted D13096: [terraform] include keyserver logs on keyserver init for qr code for self-host aws-deploy script.

how'd you decide on --since 1d?

Aug 15 2024, 10:50 PM
varun accepted D13094: [terraform] increase max time for curl.
Aug 15 2024, 10:47 PM
varun accepted D13093: [terraform] fix indents.
Aug 15 2024, 10:46 PM

Aug 14 2024

varun requested review of D13086: [lib] useENSResolvedAvatar -> useResolvedAvatar.
Aug 14 2024, 11:08 AM

Aug 12 2024

varun closed D13022: [tunnelbroker] disallow windows device tokens that don't contain the correct domain.
Aug 12 2024, 8:12 AM
varun committed rCOMM7001e487e341: [tunnelbroker] disallow windows device tokens that don't contain the correct… (authored by varun).
[tunnelbroker] disallow windows device tokens that don't contain the correct…
Aug 12 2024, 8:12 AM
varun accepted D13045: [terraform] add terraform apply to aws-deploy script.
Aug 12 2024, 8:00 AM

Aug 9 2024

varun accepted D12960: [terraform] configure personal ip address through script and not allowed_ips var.
Aug 9 2024, 2:04 PM
varun requested review of D13038: [lib] rename PrimaryDeviceLogout -> DeviceLogout.
Aug 9 2024, 1:18 PM
varun requested review of D13037: [native] empty bottom sheet for linked devices.
Aug 9 2024, 1:06 PM
varun added inline comments to D12907: [native] linked devices component.
Aug 9 2024, 12:45 PM
varun attached a referenced file: F2427184: IMG_5272.PNG.
Aug 9 2024, 12:44 PM
varun added a comment to D12884: [native] replace keyserver using qr code auth.

IMG_5272.PNG (2×1 px, 3 MB)

Aug 9 2024, 12:44 PM
varun updated the diff for D12884: [native] replace keyserver using qr code auth.

address feedback

Aug 9 2024, 12:42 PM
varun requested review of D13036: [native] make SecondaryDeviceQRCodeScanner dismissible.
Aug 9 2024, 12:36 PM
varun requested review of D13035: [lib] rename getForeignPeerDevices -> getForeignPeerDeviceIDs.
Aug 9 2024, 11:49 AM
varun updated the diff for D12734: [lib] add device type to qr code URL.

address feedback

Aug 9 2024, 11:28 AM
varun added inline comments to D12734: [lib] add device type to qr code URL.
Aug 9 2024, 11:26 AM

Aug 8 2024

varun added inline comments to D12809: [lib] add new selector and function to get own user's keyserver device ID.
Aug 8 2024, 7:10 PM
varun closed D13020: [tunnelbroker] invalidate bad wns device tokens.
Aug 8 2024, 5:59 PM
varun committed rCOMM3f814c0b29f7: [tunnelbroker] invalidate bad wns device tokens (authored by varun).
[tunnelbroker] invalidate bad wns device tokens
Aug 8 2024, 5:59 PM
varun added a comment to D13022: [tunnelbroker] disallow windows device tokens that don't contain the correct domain.

Additionally, when Tunnelbroker informs us about the fact the token is not correct we should reset the localToken, otherwise client will continuously try to upload the token without refreshing this using electron API.

Aug 8 2024, 4:48 PM
varun updated the diff for D13022: [tunnelbroker] disallow windows device tokens that don't contain the correct domain.

address feedback

Aug 8 2024, 4:41 PM
varun added a comment to D13022: [tunnelbroker] disallow windows device tokens that don't contain the correct domain.

But since this is explicit in WNS docs we probably should make sure this is done on the keyserver too and at least create a follow-up task?

Aug 8 2024, 8:34 AM
varun added inline comments to D13022: [tunnelbroker] disallow windows device tokens that don't contain the correct domain.
Aug 8 2024, 12:17 AM
varun updated the diff for D13022: [tunnelbroker] disallow windows device tokens that don't contain the correct domain.

add debug logs

Aug 8 2024, 12:15 AM

Aug 7 2024

varun updated the test plan for D13020: [tunnelbroker] invalidate bad wns device tokens.
Aug 7 2024, 11:29 PM
varun added a comment to D13022: [tunnelbroker] disallow windows device tokens that don't contain the correct domain.

@kamil I wonder if we should do something similar for other platforms, too

Aug 7 2024, 10:55 PM
varun requested changes to D12960: [terraform] configure personal ip address through script and not allowed_ips var.
Aug 7 2024, 4:16 PM
varun added inline comments to D12960: [terraform] configure personal ip address through script and not allowed_ips var.
Aug 7 2024, 4:15 PM
varun published D13022: [tunnelbroker] disallow windows device tokens that don't contain the correct domain for review.
Aug 7 2024, 4:09 PM
varun requested review of D13020: [tunnelbroker] invalidate bad wns device tokens.
Aug 7 2024, 3:45 PM
varun closed D12935: [Tunnelbroker] send push notifs to windows devices.
Aug 7 2024, 2:41 PM
varun committed rCOMM5f3de4311fbb: [Tunnelbroker] send push notifs to windows devices (authored by varun).
[Tunnelbroker] send push notifs to windows devices
Aug 7 2024, 2:41 PM
varun updated the diff for D12935: [Tunnelbroker] send push notifs to windows devices.

address feedback

Aug 7 2024, 2:29 PM
varun updated the diff for D12935: [Tunnelbroker] send push notifs to windows devices.

address feedback

Aug 7 2024, 1:33 PM
varun closed D13012: remove nan@2.17.0 from yarn.lock.
Aug 7 2024, 10:39 AM
varun committed rCOMM261ef8666355: remove nan@2.17.0 from yarn.lock (authored by varun).
remove nan@2.17.0 from yarn.lock
Aug 7 2024, 10:39 AM
varun added inline comments to D13004: [windows] override C++20 and upgrade nan package.
Aug 7 2024, 10:19 AM
varun added inline comments to D12934: [Tunnelbroker] Implement client method to get WNS token.
Aug 7 2024, 9:59 AM
varun closed D12934: [Tunnelbroker] Implement client method to get WNS token.
Aug 7 2024, 9:58 AM
varun committed rCOMMfd73c26a8a93: [Tunnelbroker] Implement client method to get WNS token (authored by varun).
[Tunnelbroker] Implement client method to get WNS token
Aug 7 2024, 9:58 AM

Aug 6 2024

varun updated the diff for D12935: [Tunnelbroker] send push notifs to windows devices.

update revision

Aug 6 2024, 9:50 PM
varun closed D12933: [Tunnelbroker] implement WNS client.
Aug 6 2024, 9:45 PM
varun closed D12932: [Tunnelbroker] implement WNS config.
Aug 6 2024, 9:45 PM
varun committed rCOMMc4d0d470342e: [Tunnelbroker] implement WNS client (authored by varun).
[Tunnelbroker] implement WNS client
Aug 6 2024, 9:45 PM
varun committed rCOMMc9330c34d549: [Tunnelbroker] implement WNS config (authored by varun).
[Tunnelbroker] implement WNS config
Aug 6 2024, 9:45 PM