- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 11 2024
lint
rebase before landing
use olmSessionErrors instead of hardcoded string
move olmSessionErrors from errors.js to olm-utils.js
rebase
introduce setter & getter
rebase
In D11577#334170, @marcin wrote:In D11577#333862, @ashoat wrote:We should implement it for notifs while working on DMs - now there is no need to I guess.
Is there a task for this?
I think it is https://linear.app/comm/issue/ENG-7658/add-olm-session-versioning-for-notifs - is that correct @kamil ?
rename to add_version_column_to_olm_persist_sessions_table
Apr 10 2024
In D11577#333755, @marcin wrote:
Not familiar with this project so letting others review, persistWhitelist looks good
Apr 9 2024
Apr 5 2024
Could you extend the test plan to
- Add an unknown user to the friend list
- Block user
- Using two clients change the avatar on one and check if it gets synced on the other
Refreshing app multiple time between steps
Apr 4 2024
Looks good
Apr 3 2024
LGTM but leaving final review to native speaker
Apr 2 2024
In D11481#331389, @marcin wrote:Accepting but I am of strong opinion that it would be better to create two new structs: NonSyncedKeyserverInfo and SyncedKeyserverInfo that would look exactly the same as original KeyserverInfo. In SQLiteQueryExecutor methods we would just create instances of each class and could rely on simple SQL queries without named parameters. The code would be easier to understand and maintain. It would be two small classes doing simple logic instead of one bigger doing complex logic.
rebase before landing
remove const
Just for clarity - could you link diff where keyservers is added to the backup blacklist?
Mar 29 2024
Mar 28 2024
LGTM - requesting changes to address this blacklist comment because this is important