remove viewer.cookieID check

Okay sounds good i'll have an update out shortly with a cleaner syntax

Ehhh I'd really prefer if we stayed away from these syntax tricks. I think spreading and destructuring can already get a little tricky on occasion (eg nested restructuring, reassigning names, etc) and I can see this just further confusing things.. especially for new devs

Eh, I don't love it but I won't veto. @atul what do you think?

remove if then and just return

Awesome, let's land this thing!!

Address feedback

Remove stream from update RPC, remove deviceEd25519 fields

Still need to delete all instances of deviceEd25519PublicKey

jon’s suggestion makes sense to me

address feedback

opaqueServerResponse -> opaqueLoginResponse

Going to merge into D7022

Rebase on master

Simplify. Turns out the second problem can be fixed with even less code (thank you @michal)

rebase and land

Have prekey refresh only pass prekeys and not onetime keys

rebase and land

address feedback

address feedback

This revision should be closed since this bug was fixed in D6851 and D6845

Aligned 'Delivery failed' notice to the message label. Only for the right side, because we can't get delivery failed on the left side.

I'm not sure if it is the case. For now, displaying both 'delivery failed' and the label ('Edited') at the same time is impossible.

That looks correct!

I'm going to leave both for now.

I'm not sure if it is the case. For now, displaying both 'delivery failed' and the label ('Edited') at the same time is impossible.

Oh yeah, that makes sense, sorry!

In D6963#209536, @tomek wrote:

The proper way of testing older clients involves running an older client in prod mode (so that it won't get hot reloaded when we update the code version), then checking out the newest code, and running the server with this code. In this case we can consider a simplified approach: the thing which interests us the most is if the server sends an original message or the shimmed version. To test that we can run a client and set code version in the condition on the keyserver. If the client's version is higher than server's, we should receive an original message. Otherwise, it should be the shimmed one.

Changed minCodeVersion for messageShimming

In D6963#209487, @kuba wrote:

I don't know how to test message shimming yet, so for now it isn't tested.

I don't know how to test message shimming yet, so for now it isn't tested.

Added shimming message info, changed content to JSON format.

Looks good! Thanks for linking to the Linear issue and jotting down detailed notes there.

Nice, glad we could cut code and make it simpler with the combined initializer

Regarding all naming issues (applies to the whole stack), I've created a Notion doc that clarifies the names

Sweet, thanks for addressing those comments

Thanks for including these tests!

yeah let's de-dupe and remove deviceEd25519PublicKey. one other nit inline

Use username or wallet ID for looking up keyserver info

Got no response to this one, requesting changes again

Use userID to find KeyserverInfo

Cool! My feedback now is that deviceEd25519PublicKey should be removed to dedup, but I think @jon is waiting on @varun to confirm before making that change