Page MenuHomePhabricator
Feed All Stories

Jul 15 2024

marcin accepted D12739: [native] Introduce getRelatedMessages to CommCoreModule.
Jul 15 2024, 2:58 AM
marcin accepted D12738: [web] Introduce getRelatedMessages to shared worker.
Jul 15 2024, 2:53 AM
marcin accepted D12737: [SQLite] Introduce getRelatedMessages.
Jul 15 2024, 2:52 AM
marcin updated the diff for D12719: Fix CORS issues with identity HTTP.

Rebase before landing

Jul 15 2024, 2:43 AM
tomek accepted D12736: [web] add std::optional (C++) <-> undefined (JS) marshalling.

It's great to see these bindings! At some point, we should delete NullableString and NullableInt.

Jul 15 2024, 1:46 AM
tomek accepted D12735: [native] Introduce MessageEntity type alias in more places.
Jul 15 2024, 1:39 AM
tomek added inline comments to D12673: Utilities to idempotently create content and notif sessions.
Jul 15 2024, 1:14 AM

Jul 14 2024

ashoat requested review of D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.
Jul 14 2024, 7:55 PM
ashoat requested review of D12740: [lib] Introduce getRelatedMessages to SQLiteAPI.
Jul 14 2024, 6:38 PM
ashoat requested review of D12739: [native] Introduce getRelatedMessages to CommCoreModule.
Jul 14 2024, 6:34 PM
ashoat requested review of D12738: [web] Introduce getRelatedMessages to shared worker.
Jul 14 2024, 6:28 PM
ashoat requested review of D12737: [SQLite] Introduce getRelatedMessages.
Jul 14 2024, 6:24 PM
ashoat requested review of D12736: [web] add std::optional (C++) <-> undefined (JS) marshalling.
Jul 14 2024, 6:24 PM
ashoat requested review of D12735: [native] Introduce MessageEntity type alias in more places.
Jul 14 2024, 6:22 PM

Jul 13 2024

ashoat accepted D12734: [lib] add device type to qr code URL.
Jul 13 2024, 4:25 PM

Jul 12 2024

ginsu closed D12716: [lib/native] lift auto join community handler to lib.
Jul 12 2024, 5:48 PM
ginsu closed D12717: [web] introduce AutoJoinCommunityHandler to web.
Jul 12 2024, 5:48 PM
ginsu committed rCOMM41181031c715: [web] introduce AutoJoinCommunityHandler to web (authored by ginsu).
[web] introduce AutoJoinCommunityHandler to web
Jul 12 2024, 5:48 PM
ginsu committed rCOMM6df10a6241b5: [lib/native] lift auto join community handler to lib (authored by ginsu).
[lib/native] lift auto join community handler to lib
Jul 12 2024, 5:48 PM
ginsu closed D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.
Jul 12 2024, 5:48 PM
ginsu committed rCOMM41570ee3f402: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook (authored by ginsu).
[native] update AutoJoinCommunityHandler to use useJoinCommunity hook
Jul 12 2024, 5:48 PM
ginsu updated the diff for D12717: [web] introduce AutoJoinCommunityHandler to web.

rebase before landing

Jul 12 2024, 5:47 PM
ginsu added inline comments to D12717: [web] introduce AutoJoinCommunityHandler to web.
Jul 12 2024, 5:46 PM
ginsu updated the diff for D12716: [lib/native] lift auto join community handler to lib.

rebase before landing

Jul 12 2024, 5:18 PM
ginsu updated the diff for D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

address comments + rebase before landing

Jul 12 2024, 4:59 PM
ashoat added a reverting change for rCOMMd6874aa491bc: [native] Temporary changes for staff release: rCOMM871066737eb0: Revert "[native] Temporary changes for staff release".
Jul 12 2024, 3:26 PM
ashoat committed rCOMM871066737eb0: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Jul 12 2024, 3:26 PM
ashoat committed rCOMMe21784ea26f4: [native] codeVersion -> 372 (authored by ashoat).
[native] codeVersion -> 372
Jul 12 2024, 3:26 PM
ashoat committed rCOMMd6874aa491bc: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Jul 12 2024, 3:26 PM
ashoat added a reverting change for rCOMM42ffe20479f2: [lib] Temporarily flip usingCommServicesAccessToken to false: rCOMM34ab898eb201: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false".
Jul 12 2024, 3:26 PM
ashoat committed rCOMM34ab898eb201: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false" (authored by ashoat).
Revert "[lib] Temporarily flip usingCommServicesAccessToken to false"
Jul 12 2024, 3:26 PM
ashoat committed rCOMM22ab51c08362: [native] codeVersion -> 371 (authored by ashoat).
[native] codeVersion -> 371
Jul 12 2024, 3:26 PM
ashoat committed rCOMM8bad8a14ede0: [web][keyserver] codeVersion -> 98 (authored by ashoat).
[web][keyserver] codeVersion -> 98
Jul 12 2024, 3:26 PM
ashoat committed rCOMM42ffe20479f2: [lib] Temporarily flip usingCommServicesAccessToken to false (authored by ashoat).
[lib] Temporarily flip usingCommServicesAccessToken to false
Jul 12 2024, 3:26 PM
varun closed D12732: [terraform] bump prod identity to 0.29.
Jul 12 2024, 2:08 PM
varun committed rCOMM05fa3c592f34: [terraform] bump prod identity to 0.29 (authored by varun).
[terraform] bump prod identity to 0.29
Jul 12 2024, 2:08 PM
varun requested review of D12734: [lib] add device type to qr code URL.
Jul 12 2024, 12:34 PM
varun closed D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Jul 12 2024, 12:19 PM
varun committed rCOMM63899045a319: [native] modify SecondaryDeviceQRCodeScanner to support emulator (authored by varun).
[native] modify SecondaryDeviceQRCodeScanner to support emulator
Jul 12 2024, 12:19 PM
will updated the summary of D12529: [terraform] Allow all ip addresses to access self-host internet gateway.
Jul 12 2024, 11:12 AM
will abandoned D12528: [terraform] run mariadb in public db group.

No longer needed. Included in prior diff

Jul 12 2024, 11:10 AM
ashoat added inline comments to D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Jul 12 2024, 10:47 AM
varun added inline comments to D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Jul 12 2024, 10:37 AM
will updated the diff for D12339: [terraform] Use default vpc, subnets, and internet gateway for self-host.

Add option for user created vpc to avoid migration of prod aws rds instance to new vpc

Jul 12 2024, 10:26 AM
will accepted D12719: Fix CORS issues with identity HTTP.

Looks good!

Jul 12 2024, 8:01 AM
ashoat added a comment to D12693: [native][web] Add fts5 extension to SQLite.

Should I make a new release of @commapp/sqlcipher-amalgamation now? We should do that before landing, so we don't need to commit the patch

Jul 12 2024, 7:26 AM
ashoat accepted D12727: [keyserver] Fix keyserver allowing adding unauthorized users to chats.
Jul 12 2024, 7:25 AM
ashoat added inline comments to D12671: Implement notification encryption on web.
Jul 12 2024, 7:23 AM
ashoat requested changes to D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.

Requesting changes for ESLint

Jul 12 2024, 7:22 AM
ashoat added inline comments to D12708: [keyserver] configure separation of primary secondary logic.
Jul 12 2024, 7:21 AM
ashoat added inline comments to D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Jul 12 2024, 7:19 AM
ashoat accepted D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

I updated communitiesToAutoJoin into an object so that when we call setCommunitiesToAutoJoin inside of the JoinHandler component, we would not need to use the .find() method to locate the correct community to update in communitiesToAutoJoin. I thought this would be a bit more performant

Jul 12 2024, 7:10 AM
marcin updated the diff for D12719: Fix CORS issues with identity HTTP.

rebase before landing

Jul 12 2024, 5:15 AM
marcin updated the diff for D12719: Fix CORS issues with identity HTTP.

Address Varun's and Will's feedbacks

Jul 12 2024, 3:13 AM
marcin accepted D12693: [native][web] Add fts5 extension to SQLite.
Jul 12 2024, 3:12 AM
marcin added inline comments to D12719: Fix CORS issues with identity HTTP.
Jul 12 2024, 3:08 AM
inka updated the diff for D12693: [native][web] Add fts5 extension to SQLite.

Remove manual changes in XCode. I had to rever the changes in native/ios/Comm.xcodeproj/project.pbxproj for all of them to disappear.
I ran yarn cleaninstall and install pods and checked that removing and reinstalling the iOS app still doesn't throw

Jul 12 2024, 2:59 AM
marcin added inline comments to D12719: Fix CORS issues with identity HTTP.
Jul 12 2024, 2:42 AM
inka closed D12726: [web] Allow creating subchannels with no other users.
Jul 12 2024, 2:31 AM
inka committed rCOMMbc6eb2904fbe: [web] Allow creating subchannels with no other users (authored by inka).
[web] Allow creating subchannels with no other users
Jul 12 2024, 2:31 AM
marcin added inline comments to D12673: Utilities to idempotently create content and notif sessions.
Jul 12 2024, 2:31 AM
inka updated the diff for D12727: [keyserver] Fix keyserver allowing adding unauthorized users to chats.

Don't call determineThreadAncestry twice

Jul 12 2024, 2:28 AM
marcin added inline comments to D12668: Implement peer notifications session creation as outbound on native.
Jul 12 2024, 2:24 AM
marcin added inline comments to D12669: Implement peer notifications session creation as outbound on web and add notifs outbound session creator to OlmAPI.
Jul 12 2024, 2:22 AM
inka added inline comments to D12727: [keyserver] Fix keyserver allowing adding unauthorized users to chats.
Jul 12 2024, 2:21 AM
marcin added inline comments to D12671: Implement notification encryption on web.
Jul 12 2024, 2:17 AM
kamil accepted D12686: [lib] remove integrity store assertion and use sqlite.
In D12686#359268, @will wrote:

@kamil does anything need to be done to remove redux persist integrityStore data besides adding to the persistBlacklist? On initial startup, I get a hydrated keys not expected integrityStore which doesn't appear on subsequent app opens in debug iOS Simulator

Jul 12 2024, 2:17 AM
marcin accepted D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.

This function is supposed to be used exclusively with thick threads.

Jul 12 2024, 2:09 AM
varun closed D12619: [keyserver] display copyable url for qr code auth.
Jul 12 2024, 12:18 AM
varun closed D12618: [keyserver] don't display the QR code if keyserver is already logged in.
Jul 12 2024, 12:18 AM
varun committed rCOMM816b07e456a8: [keyserver] display copyable url for qr code auth (authored by varun).
[keyserver] display copyable url for qr code auth
Jul 12 2024, 12:18 AM
varun committed rCOMM314adf5b2f47: [keyserver] don't display the QR code if keyserver is already logged in (authored by varun).
[keyserver] don't display the QR code if keyserver is already logged in
Jul 12 2024, 12:18 AM
varun closed D12213: [keyserver] finish secondary login via qr code.
Jul 12 2024, 12:18 AM
varun committed rCOMMc7755c1d0935: [keyserver] finish secondary login via qr code (authored by varun).
[keyserver] finish secondary login via qr code
Jul 12 2024, 12:18 AM
varun added inline comments to D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Jul 12 2024, 12:15 AM

Jul 11 2024

ginsu closed D12718: [native] fix farcaster prompt being displayed to users with fid on login.
Jul 11 2024, 11:58 PM
ginsu committed rCOMMdb7542de41c8: [native] fix farcaster prompt being displayed to users with fid on login (authored by ginsu).
[native] fix farcaster prompt being displayed to users with fid on login
Jul 11 2024, 11:58 PM
ginsu updated the diff for D12718: [native] fix farcaster prompt being displayed to users with fid on login.

rebase before landing

Jul 11 2024, 11:56 PM
ginsu attached a referenced file: F2247320: Screenshot 2024-07-12 at 12.23.44 AM.png.
Jul 11 2024, 11:38 PM
ginsu requested review of D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

It's not clear why you turned this into an object. You don't seem to be using the keys below in joinHandlers, and that seems to be the only place you communitiesToAutoJoin. Why did you update this to an object?

Jul 11 2024, 11:38 PM
ashoat accepted D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Jul 11 2024, 9:19 PM
ginsu closed D12713: [lib] make useJoinCommunity compatible with the auto join community handler.
Jul 11 2024, 9:01 PM
ginsu committed rCOMMc28089f95107: [lib] make useJoinCommunity compatible with the auto join community handler (authored by ginsu).
[lib] make useJoinCommunity compatible with the auto join community handler
Jul 11 2024, 9:01 PM
ginsu closed D12706: [lib] introduce useJoinCommunity.
Jul 11 2024, 9:01 PM
ginsu committed rCOMM8e487bb3cb67: [lib] introduce useJoinCommunity (authored by ginsu).
[lib] introduce useJoinCommunity
Jul 11 2024, 9:01 PM
ashoat added a comment to D12730: [terraform] Ensure that the primary service is running before deploying secondary service.

@will mentioned a concern I had raised in a 1:1 here. Not sure if we want to address that here, but broadly I'm worried that the health check might not work if we're doing it after bringing the load balancer publicly online with only a single node (the primary) accessible

Jul 11 2024, 9:00 PM
ashoat added inline comments to D12730: [terraform] Ensure that the primary service is running before deploying secondary service.
Jul 11 2024, 8:58 PM
ginsu updated the diff for D12713: [lib] make useJoinCommunity compatible with the auto join community handler.

rebase before landing

Jul 11 2024, 8:56 PM
ashoat added inline comments to D12703: Transfer CSAT to IndexedDB from service worker and implement call to identity to query for inbound keys.
Jul 11 2024, 8:56 PM
ginsu updated the diff for D12706: [lib] introduce useJoinCommunity.

rebase before landing

Jul 11 2024, 8:54 PM
ashoat accepted D12727: [keyserver] Fix keyserver allowing adding unauthorized users to chats.

I'd like to avoid querying determineThreadAncestry twice

Jul 11 2024, 8:53 PM
ashoat added inline comments to D12650: Update extractKeyserverIDFromID so that it returns null for DMs.
Jul 11 2024, 8:28 PM
ashoat accepted D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

Please re-request review if either of the following is true:

Jul 11 2024, 5:57 PM
ashoat accepted D12732: [terraform] bump prod identity to 0.29.

Let's do it tomorrow as you suggested

Jul 11 2024, 5:32 PM
ashoat added a comment to D12688: [terraform] make aws rds instance class configurable for self-hosting.

If you could remind me to make sure I set db.m6g.large when we set up my keyserver, that would be great!

Jul 11 2024, 5:29 PM
ashoat accepted D12718: [native] fix farcaster prompt being displayed to users with fid on login.

Great work!!

Jul 11 2024, 5:27 PM
ashoat requested changes to D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.

Just two questions:

Jul 11 2024, 5:20 PM
ashoat added a comment to D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.

Also, there appear to be ESLint issues here that would need to be resolved prior to landing

Jul 11 2024, 5:18 PM
ashoat resigned from D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.

Gonna leave this one for @marcin to confirm:

Jul 11 2024, 5:16 PM
varun added inline comments to D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Jul 11 2024, 3:19 PM