should pass

After making changes in C++ files without committing generated files it failed, executed Clean on failure and Emscripten build which executed clean command also failed, seems fine.

this should fail

review comments

I don't remember all the places where we need to add a new permission. Wondering if you modelled this on another diff that introduced a different permission – if so, would be helpful to share a link to that diff.

Make handleMigrationFailure mandatory

Enqueue operations directly

Remove extraneous confirmations

Update WASM

Rebase

Rename index

Good idea not unshimming in a migration

In D14460#401548, @kamil wrote:

It might be good to test it on staging before publishing it to prod:

• trigger PrekeysHandler to test client
• trigger cron job on keyserver

A test both correct and malformed keys

It might be good to test it on staging before publishing it to prod:

• trigger PrekeysHandler to test client
• trigger cron job on keyserver

In D14444#401325, @varun wrote:

Feels like there are probably ways to dismiss the modal without setting the fid to null here. Ideally we can catch all methods of closing the modal, but if that's really hard, one alternative would just be to set the fid to null as soon as we show the modal.

the onClosed callback gets called by BottomSheet's onChange callback:

const onChange = React.useCallback(
  (index: number) => {
    if (index === -1) {
      onClosed();
    }
  },
  [onClosed],
);

i think this should handle all methods of closing the modal

Feels like there are probably ways to dismiss the modal without setting the fid to null here. Ideally we can catch all methods of closing the modal, but if that's really hard, one alternative would just be to set the fid to null as soon as we show the modal.