Add serde rename directive
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 24 2025
Mar 24 2025
ashoat requested review of D14494: [lib] Only use threadInfo.creationTime for lastUpdatedTime if no messages.
bartek published D14492: [protos][identity] Remove primary device info from GetKeyserverKeys for review.
Harbormaster failed remote builds in B33816: Diff 47527 for D14467: [backup] Return keyserver device ID in latest backup info endpoint!
bartek updated the diff for D14467: [backup] Return keyserver device ID in latest backup info endpoint.
bartek added inline comments to D14467: [backup] Return keyserver device ID in latest backup info endpoint.
bartek published D14467: [backup] Return keyserver device ID in latest backup info endpoint for review.
Looks much cleaner now
Requesting changes because of these null checks which might lead to crash
Mar 23 2025
Mar 23 2025
the hardware back button on android does close the bottom sheet, but doesn't trigger the component's onChange callback
address feedback
Mar 21 2025
Mar 21 2025
One more comment update
Update comment
- don't we need to document it somewhere in some README?
ashoat added inline comments to D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.
Wondering how much smaller our binaries will be without ffmpeg 😀
Nice work!
If we want to be sure that it works before landing we can try making a PR to gh and run actions on the PR?
Looking at this diff, the thing you did with format seems right
LGTM, but:
- don't we need to document it somewhere in some README?
- as far as I understand to update the version you bump the version in version.mjs first, then run the script, can't we automate the first step too?
- you can also automate making commits too later?
Mar 20 2025
Mar 20 2025
fix typos
angelika published D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg for review.
angelika published D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg for review.
angelika published D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg for review.
Publishing this a potential fix for ENG-10380