Page MenuHomePhorge
Feed All Stories

Mar 24 2025

tomek accepted D14495: [lib] Fix highestTimestamp assignment in useGetLastUpdatedTimes.
Mar 24 2025, 4:16 PM
tomek accepted D14494: [lib] Only use threadInfo.creationTime for lastUpdatedTime if no messages.
Mar 24 2025, 4:09 PM
tomek accepted D14493: [lib] Fix bug in ChatThreadItemLoaderCache for simultaneous loadMostRecent calls.
Mar 24 2025, 4:02 PM
ashoat requested review of D14495: [lib] Fix highestTimestamp assignment in useGetLastUpdatedTimes.
Mar 24 2025, 3:38 PM
ashoat requested review of D14494: [lib] Only use threadInfo.creationTime for lastUpdatedTime if no messages.
Mar 24 2025, 3:29 PM
ashoat requested review of D14493: [lib] Fix bug in ChatThreadItemLoaderCache for simultaneous loadMostRecent calls.
Mar 24 2025, 2:43 PM
bartek closed D14489: [lib][native] Add keyserverDeviceID to LatestBackupInfo.
Mar 24 2025, 1:55 PM
bartek committed rCOMM598630cb095b: [lib][native] Add keyserverDeviceID to LatestBackupInfo.
Mar 24 2025, 1:55 PM
bartek closed D14467: [backup] Return keyserver device ID in latest backup info endpoint.
Mar 24 2025, 1:55 PM
bartek closed D14466: [grpc-clients] Add helpers for services grpc client.
Mar 24 2025, 1:55 PM
bartek committed rCOMMbefb888d494e: [backup] Return keyserver device ID in latest backup info endpoint.
Mar 24 2025, 1:55 PM
bartek committed rCOMM17fde856cadc: [grpc-clients] Add helpers for services grpc client.
Mar 24 2025, 1:55 PM
bartek closed D14465: [identity] Support service-to-service token in auth RPCs.
Mar 24 2025, 1:55 PM
bartek committed rCOMMa241d420bbb6: [identity] Support service-to-service token in auth RPCs.
Mar 24 2025, 1:55 PM
bartek published D14492: [protos][identity] Remove primary device info from GetKeyserverKeys for review.
Mar 24 2025, 1:32 PM
Harbormaster failed remote builds in B33816: Diff 47527 for D14467: [backup] Return keyserver device ID in latest backup info endpoint!
Mar 24 2025, 1:20 PM
bartek updated the diff for D14467: [backup] Return keyserver device ID in latest backup info endpoint.

Add serde rename directive

Mar 24 2025, 1:08 PM
bartek added inline comments to D14467: [backup] Return keyserver device ID in latest backup info endpoint.
Mar 24 2025, 1:07 PM
bartek added inline comments to D14465: [identity] Support service-to-service token in auth RPCs.
Mar 24 2025, 1:04 PM
bartek published D14490: [identity] Support tuples in device list verification for review.
Mar 24 2025, 11:53 AM
bartek published D14491: [native] Add keyserver to device list during restore for review.
Mar 24 2025, 11:42 AM
kamil accepted D14489: [lib][native] Add keyserverDeviceID to LatestBackupInfo.
Mar 24 2025, 10:59 AM
kamil accepted D14467: [backup] Return keyserver device ID in latest backup info endpoint.
Mar 24 2025, 10:56 AM
kamil accepted D14466: [grpc-clients] Add helpers for services grpc client.
Mar 24 2025, 10:47 AM
bartek published D14489: [lib][native] Add keyserverDeviceID to LatestBackupInfo for review.
Mar 24 2025, 10:41 AM
kamil accepted D14465: [identity] Support service-to-service token in auth RPCs.
Mar 24 2025, 10:13 AM
bartek added inline comments to D14481: [native] Remove ffmpeg dependency.
Mar 24 2025, 6:55 AM
bartek published D14467: [backup] Return keyserver device ID in latest backup info endpoint for review.
Mar 24 2025, 6:51 AM
bartek published D14466: [grpc-clients] Add helpers for services grpc client for review.
Mar 24 2025, 6:48 AM
bartek published D14465: [identity] Support service-to-service token in auth RPCs for review.
Mar 24 2025, 6:48 AM
bartek accepted D14470: [ios] Implement getVideoInfo() function on iOS.
Mar 24 2025, 6:48 AM
bartek accepted D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.

Looks much cleaner now

Mar 24 2025, 6:45 AM
bartek requested changes to D14478: [android] Implement transcodeVideo() function on Android.

Requesting changes because of these null checks which might lead to crash

Mar 24 2025, 6:40 AM

Mar 23 2025

varun published D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed for review.
Mar 23 2025, 4:25 PM
varun added a comment to D14444: [lib] launch connect farcaster prompt.

the hardware back button on android does close the bottom sheet, but doesn't trigger the component's onChange callback

Mar 23 2025, 3:23 PM
ashoat accepted D14444: [lib] launch connect farcaster prompt.
Mar 23 2025, 3:23 PM
varun updated the diff for D14444: [lib] launch connect farcaster prompt.

address feedback

Mar 23 2025, 3:18 PM

Mar 21 2025

ashoat closed D14486: [native] Script to bump native version.
Mar 21 2025, 11:20 PM
ashoat committed rCOMM06bd90759920: [native] Script to bump native version.
Mar 21 2025, 11:20 PM
ashoat added inline comments to D14481: [native] Remove ffmpeg dependency.
Mar 21 2025, 11:13 PM
ashoat updated the diff for D14486: [native] Script to bump native version.

One more comment update

Mar 21 2025, 11:01 PM
ashoat updated the diff for D14486: [native] Script to bump native version.

Update comment

Mar 21 2025, 10:59 PM
ashoat added a comment to D14486: [native] Script to bump native version.
  • don't we need to document it somewhere in some README?
Mar 21 2025, 10:59 PM
ashoat added inline comments to D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.
Mar 21 2025, 5:08 PM
bartek accepted D14481: [native] Remove ffmpeg dependency.

Wondering how much smaller our binaries will be without ffmpeg 😀

Mar 21 2025, 3:57 PM
bartek accepted D14479: [ios] Implement transcodeVideo() function on iOS.

Nice work!

Mar 21 2025, 3:52 PM
bartek accepted D14487: [ci] Update mac runner image in github workflows.

If we want to be sure that it works before landing we can try making a PR to gh and run actions on the PR?

Mar 21 2025, 3:32 PM
angelika requested review of D14487: [ci] Update mac runner image in github workflows.
Mar 21 2025, 12:28 PM
tomek accepted D14486: [native] Script to bump native version.
Mar 21 2025, 11:20 AM
bartek added inline comments to D14478: [android] Implement transcodeVideo() function on Android.
Mar 21 2025, 9:19 AM
bartek accepted D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg.
Mar 21 2025, 9:00 AM
bartek accepted D14476: [ios] Implement generateThumbnail() function on iOS.
Mar 21 2025, 8:57 AM
bartek accepted D14475: [android] Implement generateThumbnail() function on Android.
Mar 21 2025, 8:56 AM
bartek accepted D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg.
Mar 21 2025, 8:53 AM
bartek accepted D14473: [ios] Implement hasMultipleFrames() function on iOS.
Mar 21 2025, 8:52 AM
bartek accepted D14472: [android] Implement hasMultipleFrames() function on Android.
Mar 21 2025, 8:51 AM
bartek accepted D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.

Looking at this diff, the thing you did with format seems right

Mar 21 2025, 8:50 AM
bartek added inline comments to D14470: [ios] Implement getVideoInfo() function on iOS.
Mar 21 2025, 8:48 AM
bartek accepted D14469: [android] Implement getVideoInfo() function on Android.
Mar 21 2025, 8:42 AM
bartek accepted D14468: [native] Add MediaModule expo module.
Mar 21 2025, 8:40 AM
angelika accepted D14486: [native] Script to bump native version.

LGTM, but:

  • don't we need to document it somewhere in some README?
  • as far as I understand to update the version you bump the version in version.mjs first, then run the script, can't we automate the first step too?
  • you can also automate making commits too later?
Mar 21 2025, 7:32 AM
ashoat requested review of D14486: [native] Script to bump native version.
Mar 21 2025, 4:08 AM
ashoat committed rCOMMc1e6a12cab9e: Podfile updates for ffmpeg-kit-min-ios changes.
Mar 21 2025, 3:57 AM
ashoat committed rCOMM61e73cd47c25: [terraform] Bump keyserver image to 1.0.158.
Mar 21 2025, 3:25 AM
ashoat committed rCOMM5c3ef7ff9a58: Revert "[native] Temporary changes for staff release".
Mar 21 2025, 2:38 AM
ashoat added a reverting change for rCOMMb558664e2a98: [native] Temporary changes for staff release: rCOMM5c3ef7ff9a58: Revert "[native] Temporary changes for staff release".
Mar 21 2025, 2:38 AM
ashoat committed rCOMM1544209a3f33: [native] codeVersion -> 472.
Mar 21 2025, 2:38 AM
ashoat committed rCOMMb558664e2a98: [native] Temporary changes for staff release.
Mar 21 2025, 2:38 AM
ashoat committed rCOMM66dd9528c6b0: [native] codeVersion -> 471.
Mar 21 2025, 2:38 AM
ashoat committed rCOMM4487b875a5af: [web][keyserver] codeVersion -> 158.
Mar 21 2025, 2:38 AM
ashoat committed rCOMM5a8d986f80ec: CLAUDE.md config for Claude Code.
Mar 21 2025, 2:23 AM

Mar 20 2025

kamil closed D11243: [CI] Clean on failure for Emscripten pipeline.
Mar 20 2025, 1:24 PM
kamil committed rCOMM18922ade93a1: [CI] Clean on failure for Emscripten pipeline.
Mar 20 2025, 1:24 PM
kamil closed D14483: [web] clear old Olm session before creating new one.
Mar 20 2025, 1:21 PM
kamil closed D14482: [web] clear old `cryptoStore` before creating new one.
Mar 20 2025, 1:21 PM
kamil committed rCOMM04a40fae36f0: [web] clear old Olm session before creating new one.
Mar 20 2025, 1:21 PM
kamil committed rCOMM941b4e92c37c: [web] clear old `cryptoStore` before creating new one.
Mar 20 2025, 1:21 PM
kamil closed D14485: [web][keyserver] log Olm memory usage changes.
Mar 20 2025, 1:21 PM
kamil closed D14464: [keyserver] call `free()` on Olm objects in finally block.
Mar 20 2025, 1:21 PM
kamil committed rCOMM993689cd4a3d: [web][keyserver] log Olm memory usage changes.
Mar 20 2025, 1:21 PM
kamil committed rCOMM4765e9c616eb: [keyserver] call `free()` on Olm objects in finally block.
Mar 20 2025, 1:21 PM
kamil closed D14484: [dependencies] bump Olm version to `0.2.3`.
Mar 20 2025, 1:21 PM
kamil committed rCOMMab05ac387435: [dependencies] bump Olm version to `0.2.3`.
Mar 20 2025, 1:21 PM
kamil added inline comments to D11243: [CI] Clean on failure for Emscripten pipeline.
Mar 20 2025, 1:01 PM
ashoat accepted D11243: [CI] Clean on failure for Emscripten pipeline.
Mar 20 2025, 12:59 PM
kamil updated the diff for D14485: [web][keyserver] log Olm memory usage changes.

fix typos

Mar 20 2025, 12:59 PM
angelika published D14481: [native] Remove ffmpeg dependency for review.
Mar 20 2025, 12:57 PM
angelika published D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg for review.
Mar 20 2025, 12:57 PM
angelika published D14479: [ios] Implement transcodeVideo() function on iOS for review.
Mar 20 2025, 12:57 PM
angelika published D14478: [android] Implement transcodeVideo() function on Android for review.
Mar 20 2025, 12:57 PM
angelika published D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg for review.
Mar 20 2025, 12:57 PM
angelika published D14476: [ios] Implement generateThumbnail() function on iOS for review.
Mar 20 2025, 12:56 PM
angelika published D14475: [android] Implement generateThumbnail() function on Android for review.
Mar 20 2025, 12:56 PM
kamil added reviewers for D11243: [CI] Clean on failure for Emscripten pipeline: tomek, bartek.
Mar 20 2025, 12:56 PM
angelika published D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg for review.
Mar 20 2025, 12:56 PM
kamil added a comment to D11243: [CI] Clean on failure for Emscripten pipeline.

Publishing this a potential fix for ENG-10380

Mar 20 2025, 12:56 PM
angelika published D14473: [ios] Implement hasMultipleFrames() function on iOS for review.
Mar 20 2025, 12:56 PM
angelika published D14472: [android] Implement hasMultipleFrames() function on Android for review.
Mar 20 2025, 12:56 PM
angelika published D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg for review.
Mar 20 2025, 12:55 PM
angelika published D14470: [ios] Implement getVideoInfo() function on iOS for review.
Mar 20 2025, 12:55 PM