Page MenuHomePhorge
Feed All Stories

Mar 27 2025

bartek published D14508: [identity] Enable strict device list checks for review.
Mar 27 2025, 12:25 PM
bartek closed D14506: [lib][native] Keep keyserver in device list after primary logout.
Mar 27 2025, 12:23 PM
bartek closed D14507: [lib] Don't send logout message to keyserver.
Mar 27 2025, 12:23 PM
bartek committed rCOMMca2408bcde4e: [lib] Don't send logout message to keyserver.
Mar 27 2025, 12:23 PM
bartek committed rCOMMfc01ada1f576: [lib][native] Keep keyserver in device list after primary logout.
Mar 27 2025, 12:23 PM
bartek closed D14491: [native] Add keyserver to device list during restore.
Mar 27 2025, 12:23 PM
bartek committed rCOMM1cb201403ab0: [native] Add keyserver to device list during restore.
Mar 27 2025, 12:23 PM
bartek closed D14503: [terraform] Bump staging Identity and Backup.
Mar 27 2025, 10:48 AM
bartek committed rCOMM168db9273acc: [terraform] Bump staging Identity and Backup.
Mar 27 2025, 10:48 AM
bartek closed D14504: [identity] Skip keyserver during privileged password reset.
Mar 27 2025, 10:48 AM
bartek committed rCOMMd7762e5395a0: [identity] Skip keyserver during privileged password reset.
Mar 27 2025, 10:48 AM
kamil accepted D14507: [lib] Don't send logout message to keyserver.
Mar 27 2025, 10:38 AM
kamil accepted D14506: [lib][native] Keep keyserver in device list after primary logout.
Mar 27 2025, 10:37 AM
kamil accepted D14504: [identity] Skip keyserver during privileged password reset.
Mar 27 2025, 10:18 AM
bartek published D14507: [lib] Don't send logout message to keyserver for review.
Mar 27 2025, 10:15 AM
bartek published D14506: [lib][native] Keep keyserver in device list after primary logout for review.
Mar 27 2025, 10:15 AM
kamil accepted D14503: [terraform] Bump staging Identity and Backup.
Mar 27 2025, 10:12 AM
bartek retitled D14503: [terraform] Bump staging Identity and Backup from [terraform] Bump staging Identity to 0.52.0
Mar 27 2025, 9:49 AM
bartek updated the diff for D14503: [terraform] Bump staging Identity and Backup.

Bump Backup too

Mar 27 2025, 9:48 AM
bartek published D14503: [terraform] Bump staging Identity and Backup for review.
Mar 27 2025, 9:39 AM
ashoat requested changes to D14505: [lib] Migrate delete message permissions on clients.

Great work figuring this out! I have a lot of comments, but none of them are about core logic... mostly asking for more code comments, some renames, and some refactors

Mar 27 2025, 4:34 AM
ashoat added a comment to D14462: [lib] Introduce delete message permissions.

There is one place I'm not sure of: threadPermissionsRemovedForGenesisMembers - we include threadPermissions.EDIT_MESSAGE there, but I'm not sure why. In the most recent revision I didn't add the new permissions there.

Mar 27 2025, 4:10 AM
ashoat requested changes to D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed.

Your test plan is super incomplete. Can you please update the test plan to go one-by-one through every scenario we've had to contemplate while working on this? Eg. fresh registration, log in of existing user with Farcaster connection, log in of existing user with no Farcaster connection, existing log-in that hasn't logged out since before the new registration flow (never got prompted to connect Farcaster), etc.

Mar 27 2025, 3:51 AM
varun updated the diff for D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed.
  1. use coldStartCount to make sure we don't display connect farcaster alert right after NUX
  2. use connectFarcasterAlertInfo in DisplayCommunityDirectoryPromptHandler to make sure we don't display community directory prompt until a day after connect farcaster prompt
Mar 27 2025, 2:55 AM

Mar 26 2025

tomek requested review of D14505: [lib] Migrate delete message permissions on clients.
Mar 26 2025, 7:49 PM
Harbormaster failed remote builds in B33846: Diff 47574 for D14462: [lib] Introduce delete message permissions!
Mar 26 2025, 7:00 PM
tomek added inline comments to D14463: [lib] Add a migration that adds message delete permissions.
Mar 26 2025, 6:57 PM
tomek updated the diff for D14463: [lib] Add a migration that adds message delete permissions.

Updated permissions filtering logic

Mar 26 2025, 6:56 PM
tomek added a comment to D14462: [lib] Introduce delete message permissions.

I don't remember all the places where we need to add a new permission. Wondering if you modelled this on another diff that introduced a different permission – if so, would be helpful to share a link to that diff.

Mar 26 2025, 6:52 PM
tomek updated the diff for D14462: [lib] Introduce delete message permissions.

Fix typo and stop filtering out the permission

Mar 26 2025, 6:52 PM
bartek closed D14502: [terraform] Bump prod Identity to 0.51.2.
Mar 26 2025, 3:31 PM
bartek committed rCOMM8a9385222c2c: [terraform] Bump prod Identity to 0.51.2.
Mar 26 2025, 3:31 PM
bartek published D14504: [identity] Skip keyserver during privileged password reset for review.
Mar 26 2025, 3:29 PM
ashoat accepted D14502: [terraform] Bump prod Identity to 0.51.2.
Mar 26 2025, 3:25 PM
bartek published D14502: [terraform] Bump prod Identity to 0.51.2 for review.
Mar 26 2025, 3:23 PM
bartek closed D14492: [protos][identity] Remove primary device info from GetKeyserverKeys.
Mar 26 2025, 3:01 PM
bartek committed rCOMMd62e2ca88a20: [protos][identity] Remove primary device info from GetKeyserverKeys.
Mar 26 2025, 3:01 PM
bartek added inline comments to D14492: [protos][identity] Remove primary device info from GetKeyserverKeys.
Mar 26 2025, 3:00 PM
bartek closed D14501: [identity] Skip keyserver during primary logout and restore.
Mar 26 2025, 2:55 PM
bartek closed D14500: [identity] Refactor devices data deletion to allow filtering.
Mar 26 2025, 2:55 PM
bartek committed rCOMM0a82eb871ff8: [identity] Skip keyserver during primary logout and restore.
Mar 26 2025, 2:55 PM
bartek committed rCOMMca6dc08b6f22: [identity] Refactor devices data deletion to allow filtering.
Mar 26 2025, 2:55 PM
bartek closed D14499: [identity] Fix OTK removal in clean_up_devices_data.
Mar 26 2025, 2:55 PM
bartek closed D14498: [identity] Split OTK deletion into smaller functions.
Mar 26 2025, 2:55 PM
bartek committed rCOMMcdc293df59ec: [identity] Split OTK deletion into smaller functions.
Mar 26 2025, 2:55 PM
bartek committed rCOMMdf5ae533da28: [identity] Fix OTK removal in clean_up_devices_data.
Mar 26 2025, 2:55 PM
bartek closed D14496: [identity] Make function names more accurate.
Mar 26 2025, 2:55 PM
bartek closed D14497: [identity] Allow excluding devices in CSAT deletion func.
Mar 26 2025, 2:55 PM
bartek committed rCOMM572f0e728323: [identity] Allow excluding devices in CSAT deletion func.
Mar 26 2025, 2:55 PM
bartek committed rCOMMdf6f222f0287: [identity] Make function names more accurate.
Mar 26 2025, 2:55 PM
bartek closed D14490: [identity] Support tuples in device list verification.
Mar 26 2025, 2:55 PM
bartek committed rCOMM691efa2c3585: [identity] Support tuples in device list verification.
Mar 26 2025, 2:55 PM
ashoat accepted D14492: [protos][identity] Remove primary device info from GetKeyserverKeys.
Mar 26 2025, 2:55 PM
bartek added inline comments to D14490: [identity] Support tuples in device list verification.
Mar 26 2025, 2:50 PM
angelika closed D14487: [ci] Update mac runner image in github workflows.
Mar 26 2025, 12:52 PM
angelika committed rCOMM9828750c0be2: [ci] Update mac runner image in github workflows.
Mar 26 2025, 12:52 PM
Harbormaster failed remote builds in B33840: Diff 47558 for D14490: [identity] Support tuples in device list verification!
Mar 26 2025, 10:56 AM
bartek updated the diff for D14501: [identity] Skip keyserver during primary logout and restore.

Use alternative syntax

Mar 26 2025, 10:48 AM
bartek updated the diff for D14499: [identity] Fix OTK removal in clean_up_devices_data.

Fix typo

Mar 26 2025, 10:47 AM
bartek updated the diff for D14490: [identity] Support tuples in device list verification.

Add comment about singleton/tuple, fix log message

Mar 26 2025, 10:47 AM
bartek accepted D14478: [android] Implement transcodeVideo() function on Android.
Mar 26 2025, 10:08 AM
angelika added inline comments to D14481: [native] Remove ffmpeg dependency.
Mar 26 2025, 5:21 AM
Harbormaster failed remote builds in B33828: Diff 47546 for D14470: [ios] Implement getVideoInfo() function on iOS!
Mar 26 2025, 5:15 AM
angelika added inline comments to D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.
Mar 26 2025, 5:12 AM
angelika added inline comments to D14470: [ios] Implement getVideoInfo() function on iOS.
Mar 26 2025, 5:10 AM
angelika updated the diff for D14481: [native] Remove ffmpeg dependency.

Rebase

Mar 26 2025, 5:07 AM
angelika updated the diff for D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.

Rebase

Mar 26 2025, 5:06 AM
angelika updated the diff for D14479: [ios] Implement transcodeVideo() function on iOS.

Rebase & fix

Mar 26 2025, 5:05 AM
angelika updated the diff for D14478: [android] Implement transcodeVideo() function on Android.

Rebase & review changes

Mar 26 2025, 5:05 AM
angelika updated the diff for D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg.

Rebase

Mar 26 2025, 5:04 AM
angelika updated the diff for D14476: [ios] Implement generateThumbnail() function on iOS.

Rebase

Mar 26 2025, 5:04 AM
angelika updated the diff for D14475: [android] Implement generateThumbnail() function on Android.

Rebase & fix

Mar 26 2025, 5:03 AM
angelika updated the diff for D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg.

Rebase

Mar 26 2025, 5:03 AM
angelika updated the diff for D14473: [ios] Implement hasMultipleFrames() function on iOS.

Rebase

Mar 26 2025, 5:02 AM
angelika updated the diff for D14472: [android] Implement hasMultipleFrames() function on Android.

Rebase

Mar 26 2025, 5:02 AM
angelika updated the diff for D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.

Rebase

Mar 26 2025, 5:01 AM
angelika updated the diff for D14470: [ios] Implement getVideoInfo() function on iOS.

Rebase

Mar 26 2025, 5:01 AM
angelika updated the diff for D14469: [android] Implement getVideoInfo() function on Android.

Rebase

Mar 26 2025, 4:59 AM
angelika updated the diff for D14468: [native] Add MediaModule expo module.

Rebase

Mar 26 2025, 4:59 AM

Mar 25 2025

kamil accepted D14501: [identity] Skip keyserver during primary logout and restore.
Mar 25 2025, 6:56 PM
kamil accepted D14500: [identity] Refactor devices data deletion to allow filtering.
Mar 25 2025, 6:49 PM
kamil accepted D14499: [identity] Fix OTK removal in clean_up_devices_data.
Mar 25 2025, 6:45 PM
kamil accepted D14498: [identity] Split OTK deletion into smaller functions.
Mar 25 2025, 6:44 PM
kamil accepted D14497: [identity] Allow excluding devices in CSAT deletion func.
Mar 25 2025, 6:38 PM
kamil accepted D14496: [identity] Make function names more accurate.
Mar 25 2025, 6:32 PM
ashoat closed D14495: [lib] Fix highestTimestamp assignment in useGetLastUpdatedTimes.
Mar 25 2025, 2:50 PM
ashoat closed D14494: [lib] Only use threadInfo.creationTime for lastUpdatedTime if no messages.
Mar 25 2025, 2:50 PM
ashoat committed rCOMM481c30533aa3: [lib] Fix highestTimestamp assignment in useGetLastUpdatedTimes.
Mar 25 2025, 2:50 PM
ashoat committed rCOMM79d733cfa348: [lib] Only use threadInfo.creationTime for lastUpdatedTime if no messages.
Mar 25 2025, 2:50 PM
ashoat closed D14493: [lib] Fix bug in ChatThreadItemLoaderCache for simultaneous loadMostRecent calls.
Mar 25 2025, 2:50 PM
ashoat committed rCOMMed79202ca6ba: [lib] Fix bug in ChatThreadItemLoaderCache for simultaneous loadMostRecent calls.
Mar 25 2025, 2:50 PM
bartek published D14501: [identity] Skip keyserver during primary logout and restore for review.
Mar 25 2025, 2:45 PM
bartek published D14500: [identity] Refactor devices data deletion to allow filtering for review.
Mar 25 2025, 2:44 PM
bartek published D14499: [identity] Fix OTK removal in clean_up_devices_data for review.
Mar 25 2025, 2:43 PM
bartek published D14498: [identity] Split OTK deletion into smaller functions for review.
Mar 25 2025, 2:43 PM
bartek published D14497: [identity] Allow excluding devices in CSAT deletion func for review.
Mar 25 2025, 2:43 PM
bartek published D14496: [identity] Make function names more accurate for review.
Mar 25 2025, 2:41 PM
kamil accepted D14492: [protos][identity] Remove primary device info from GetKeyserverKeys.
Mar 25 2025, 9:44 AM
kamil accepted D14491: [native] Add keyserver to device list during restore.
Mar 25 2025, 9:41 AM
kamil accepted D14490: [identity] Support tuples in device list verification.
Mar 25 2025, 9:41 AM