Bump Backup too
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
All Stories
Mar 27 2025
Great work figuring this out! I have a lot of comments, but none of them are about core logic... mostly asking for more code comments, some renames, and some refactors
In D14462#402560, @tomek wrote:There is one place I'm not sure of: threadPermissionsRemovedForGenesisMembers - we include threadPermissions.EDIT_MESSAGE there, but I'm not sure why. In the most recent revision I didn't add the new permissions there.
Your test plan is super incomplete. Can you please update the test plan to go one-by-one through every scenario we've had to contemplate while working on this? Eg. fresh registration, log in of existing user with Farcaster connection, log in of existing user with no Farcaster connection, existing log-in that hasn't logged out since before the new registration flow (never got prompted to connect Farcaster), etc.
- use coldStartCount to make sure we don't display connect farcaster alert right after NUX
- use connectFarcasterAlertInfo in DisplayCommunityDirectoryPromptHandler to make sure we don't display community directory prompt until a day after connect farcaster prompt
Mar 26 2025
Updated permissions filtering logic
In D14462#401685, @ashoat wrote:I don't remember all the places where we need to add a new permission. Wondering if you modelled this on another diff that introduced a different permission – if so, would be helpful to share a link to that diff.
Fix typo and stop filtering out the permission
Use alternative syntax
Fix typo
Add comment about singleton/tuple, fix log message
Rebase
Rebase & fix
Rebase & review changes
Rebase
Rebase
Rebase & fix
Rebase
Rebase
Rebase
Rebase
Rebase
Rebase
Rebase