Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Apr 3 2025

kamil published D14526: [web] remove `BackupTestRestoreModal` for review.

Apr 3 2025, 10:54 AM

kamil published D14525: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI for review.

Apr 3 2025, 10:53 AM

kamil published D14524: [lib][native] remove `performBackupRestore` from `SecondaryDeviceQRAuthContextProvider` for review.

Apr 3 2025, 10:53 AM

kamil published D14523: [lib][web][native] implement shared function to execute User Data restore for review.

Apr 3 2025, 10:53 AM

bartek accepted D14520: [lib] add logging to `createMissingSession`.

Apr 3 2025, 10:52 AM

kamil published D14522: [native] extract constants from `persist.js` for review.

Apr 3 2025, 10:52 AM

kamil published D14521: [lib][native] refactor login/restore hooks to return `IdentityAuthResult` for review.

Apr 3 2025, 10:52 AM

bartek accepted D14519: [SQLite] copy tables during restore instead of replacing entire database.

Apr 3 2025, 10:51 AM

bartek accepted D14518: [SQLite] unify `restoreFromMainCompaction` on platforms.

Apr 3 2025, 10:50 AM

bartek added a comment to D14517: [SQLite] implement method to copy table between databases.

Don't we want this method to take a vector of tables to copy? Looking at D14519, I see you're running this in a loop, so the ATTACH DATABASE ..., DETACH statements are repeated for each table

Apr 3 2025, 10:50 AM

kamil updated the summary of D14520: [lib] add logging to `createMissingSession`.

Apr 3 2025, 10:50 AM

kamil published D14520: [lib] add logging to `createMissingSession` for review.

Apr 3 2025, 10:49 AM

bartek accepted D14516: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach.

Apr 3 2025, 10:27 AM

bartek accepted D14515: [SQLite] add logging to `handleSQLiteError`.

Apr 3 2025, 10:20 AM

kamil published D14519: [SQLite] copy tables during restore instead of replacing entire database for review.

Apr 3 2025, 10:13 AM

kamil published D14518: [SQLite] unify `restoreFromMainCompaction` on platforms for review.

Apr 3 2025, 10:12 AM

kamil published D14517: [SQLite] implement method to copy table between databases for review.

Apr 3 2025, 10:10 AM

kamil published D14516: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach for review.

Apr 3 2025, 10:05 AM

kamil published D14515: [SQLite] add logging to `handleSQLiteError` for review.

Apr 3 2025, 10:03 AM

bartek closed D14513: [identity] Fix retrying OTK upload transaction.

Apr 3 2025, 7:51 AM

bartek committed rCOMM8b0b50263e18: [identity] Fix retrying OTK upload transaction.

Apr 3 2025, 7:51 AM

bartek accepted D14512: [native] Fix reading video files for processing.

Apr 3 2025, 7:47 AM

bartek accepted D14514: [native] Handle exif data orientation when returning video size in getVideoInfo on iOS.

Apr 3 2025, 7:46 AM

Apr 2 2025

ashoat added a comment to D14514: [native] Handle exif data orientation when returning video size in getVideoInfo on iOS.

Looking at getVideoProcessingPlan more closely, it doesn't seem to mention rotating of the video... not sure how this was handled in the old system, but I guess it was internal to FFmpeg. Sorry for the misdirection!

Apr 2 2025, 3:42 PM

ashoat accepted D14512: [native] Fix reading video files for processing.

Thanks for looking into that! I think at least we can now remove uri from the return of fetchFileInfo – can you make that change before landing?

Apr 2 2025, 3:38 PM

ashoat added a comment to D14514: [native] Handle exif data orientation when returning video size in getVideoInfo on iOS.

Two questions:

Apr 2 2025, 3:24 PM

angelika requested review of D14514: [native] Handle exif data orientation when returning video size in getVideoInfo on iOS.

Apr 2 2025, 2:45 PM

kamil accepted D14513: [identity] Fix retrying OTK upload transaction.

Apr 2 2025, 2:31 PM

bartek published D14513: [identity] Fix retrying OTK upload transaction for review.

Apr 2 2025, 2:28 PM

angelika added a comment to D14512: [native] Fix reading video files for processing.

However, I think we can go deeper in removing the file:// URIs, since it doesn't seem like they're needed anymore.

Apr 2 2025, 2:22 PM

angelika updated the diff for D14512: [native] Fix reading video files for processing.

Review changes

Apr 2 2025, 2:18 PM

Apr 1 2025

ashoat requested changes to D14512: [native] Fix reading video files for processing.

Nice find! I tested it and it resolves the issue for me. However, I think we can go deeper in removing the file:// URIs, since it doesn't seem like they're needed anymore.

Apr 1 2025, 5:37 PM

angelika published D14512: [native] Fix reading video files for processing for review.

Apr 1 2025, 2:14 PM

Mar 31 2025

Harbormaster failed remote builds in B33865: Diff 47614 for D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed!

Mar 31 2025, 10:50 PM

varun planned changes to D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed.

need to finish testing this

Mar 31 2025, 10:42 PM

varun updated the diff for D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed.

make cold start count a per-alert type count instead of a global count, migrations, stagger the connect farcaster and community directory prompts

Mar 31 2025, 10:42 PM

bartek closed D14509: [protos] Update comment with NEXT_CODE_VERSION.

Mar 31 2025, 12:59 PM

bartek committed rCOMM826d7be44b93: [protos] Update comment with NEXT_CODE_VERSION.

Mar 31 2025, 12:59 PM

bartek closed D14508: [identity] Enable strict device list checks.

Mar 31 2025, 12:59 PM

bartek committed rCOMM021147207d4f: [identity] Enable strict device list checks.

Mar 31 2025, 12:59 PM

Mar 28 2025

Harbormaster failed remote builds in B33864: Diff 47611 for D14510: [lib] Introduce delete message type!

Mar 28 2025, 1:55 PM

tomek updated the diff for D14510: [lib] Introduce delete message type.

Expand MessageData

Mar 28 2025, 1:46 PM

ashoat accepted D14511: [lib] Introduce delete message spec.

Mar 28 2025, 1:45 PM

ashoat accepted D14510: [lib] Introduce delete message type.

Can you retitle all of the diffs in this stack to explicitly reference message deletion? Just realized that they're just generically titled.

Mar 28 2025, 1:42 PM

ashoat committed rCOMM4bcc208fde11: [terraform] Bump keyserver image to 1.0.159.

Mar 28 2025, 1:30 PM

tomek requested review of D14511: [lib] Introduce delete message spec.

Mar 28 2025, 1:04 PM

tomek added inline comments to D14510: [lib] Introduce delete message type.

Mar 28 2025, 11:46 AM

tomek updated the diff for D14510: [lib] Introduce delete message type.

Modify some more types, test the validator

Mar 28 2025, 11:44 AM

tomek requested review of D14510: [lib] Introduce delete message type.

Mar 28 2025, 11:29 AM

ashoat committed rCOMM5bc75944dfc5: Revert "[native] Temporary changes for staff release".

Mar 28 2025, 4:41 AM

ashoat added a reverting change for rCOMM4e575d9d27de: [native] Temporary changes for staff release: rCOMM5bc75944dfc5: Revert "[native] Temporary changes for staff release".

Mar 28 2025, 4:41 AM

ashoat committed rCOMM39e43b678844: [native] codeVersion -> 476.

Mar 28 2025, 4:41 AM

ashoat committed rCOMM4e575d9d27de: [native] Temporary changes for staff release.

Mar 28 2025, 4:41 AM

ashoat committed rCOMM15f5d7212c96: [native] codeVersion -> 475.

Mar 28 2025, 4:41 AM

ashoat committed rCOMM06968dfa4d9d: [native] Fix "hermes contains bitcode" error.

Mar 28 2025, 4:41 AM

ashoat committed rCOMM532e9e695e50: Revert "[native] Temporary changes for staff release".

Mar 28 2025, 3:44 AM

ashoat added a reverting change for rCOMM7418f636e632: [native] Temporary changes for staff release: rCOMM532e9e695e50: Revert "[native] Temporary changes for staff release".

Mar 28 2025, 3:44 AM

ashoat committed rCOMMfa3bc470d858: [native] codeVersion -> 474.

Mar 28 2025, 3:44 AM

ashoat committed rCOMM7418f636e632: [native] Temporary changes for staff release.

Mar 28 2025, 3:44 AM

ashoat committed rCOMM80f96e10c99b: [native] codeVersion -> 473.

Mar 28 2025, 3:44 AM

ashoat committed rCOMMe1c3d06d976a: [web][keyserver] codeVersion -> 159.

Mar 28 2025, 3:44 AM

Mar 27 2025

angelika closed D14481: [native] Remove ffmpeg dependency.

Mar 27 2025, 7:21 PM

angelika closed D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.

Mar 27 2025, 7:21 PM

angelika closed D14479: [ios] Implement transcodeVideo() function on iOS.

Mar 27 2025, 7:21 PM

angelika committed rCOMM085ad9283c28: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.

Mar 27 2025, 7:21 PM

angelika committed rCOMM2fb795a199b7: [native] Remove ffmpeg dependency.

Mar 27 2025, 7:21 PM

angelika committed rCOMMf0d2a66750c1: [ios] Implement transcodeVideo() function on iOS.

Mar 27 2025, 7:21 PM

angelika closed D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg.

Mar 27 2025, 7:21 PM

angelika closed D14478: [android] Implement transcodeVideo() function on Android.

Mar 27 2025, 7:21 PM

angelika closed D14476: [ios] Implement generateThumbnail() function on iOS.

Mar 27 2025, 7:21 PM

angelika committed rCOMM99354f3d9c3a: [android] Implement transcodeVideo() function on Android.

Mar 27 2025, 7:21 PM

angelika committed rCOMMfb17f097913d: [ios] Implement generateThumbnail() function on iOS.

Mar 27 2025, 7:21 PM

angelika committed rCOMM822d231b91d0: [native] Use generateThumbnail() from MediaModule instead of ffmpeg.

Mar 27 2025, 7:21 PM

angelika closed D14475: [android] Implement generateThumbnail() function on Android.

Mar 27 2025, 7:21 PM

angelika closed D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg.

Mar 27 2025, 7:21 PM

angelika closed D14473: [ios] Implement hasMultipleFrames() function on iOS.

Mar 27 2025, 7:21 PM

angelika committed rCOMMa21fb87bf067: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg.

Mar 27 2025, 7:21 PM

angelika committed rCOMMc7db39914da1: [android] Implement generateThumbnail() function on Android.

Mar 27 2025, 7:21 PM

angelika committed rCOMMa6bdf5a306c7: [ios] Implement hasMultipleFrames() function on iOS.

Mar 27 2025, 7:21 PM

angelika closed D14472: [android] Implement hasMultipleFrames() function on Android.

Mar 27 2025, 7:21 PM

angelika closed D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.

Mar 27 2025, 7:21 PM

angelika committed rCOMM7636a8a76a81: [android] Implement hasMultipleFrames() function on Android.

Mar 27 2025, 7:21 PM

angelika committed rCOMMe75c93028829: [native] Use getVideoInfo from MediaModule instead of ffmpeg.

Mar 27 2025, 7:21 PM

angelika closed D14470: [ios] Implement getVideoInfo() function on iOS.

Mar 27 2025, 7:21 PM

angelika closed D14469: [android] Implement getVideoInfo() function on Android.

Mar 27 2025, 7:21 PM

angelika committed rCOMM1775e7d6d37f: [android] Implement getVideoInfo() function on Android.

Mar 27 2025, 7:21 PM

angelika committed rCOMM7f1a59810cb8: [ios] Implement getVideoInfo() function on iOS.

Mar 27 2025, 7:21 PM

angelika closed D14468: [native] Add MediaModule expo module.

Mar 27 2025, 7:21 PM

angelika committed rCOMM7be92c55a5d9: [native] Add MediaModule expo module.

Mar 27 2025, 7:21 PM

kamil accepted D14508: [identity] Enable strict device list checks.

Mar 27 2025, 4:36 PM

Harbormaster failed remote builds in B33859: Diff 47592 for D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg!

Mar 27 2025, 4:17 PM

tomek updated the diff for D14505: [lib] Migrate delete message permissions on clients.

Fix typos, reference a task, use a shorthand

Mar 27 2025, 4:16 PM

angelika updated the diff for D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.

Set bitrate to 4000 kb/s

Mar 27 2025, 4:08 PM

ashoat accepted D14505: [lib] Migrate delete message permissions on clients.

Mar 27 2025, 3:58 PM

ashoat accepted D14509: [protos] Update comment with NEXT_CODE_VERSION.

Mar 27 2025, 3:50 PM

tomek added inline comments to D14505: [lib] Migrate delete message permissions on clients.

Mar 27 2025, 2:59 PM

tomek updated the diff for D14505: [lib] Migrate delete message permissions on clients.

Address review

Mar 27 2025, 2:59 PM

Harbormaster failed remote builds in B33857: Diff 47590 for D14479: [ios] Implement transcodeVideo() function on iOS!

Mar 27 2025, 2:37 PM

angelika updated the diff for D14479: [ios] Implement transcodeVideo() function on iOS.

Fix rotation issue on android video

Mar 27 2025, 2:28 PM

bartek published D14509: [protos] Update comment with NEXT_CODE_VERSION for review.

Mar 27 2025, 12:26 PM