Fix nit

prepareWebNotification now takes a bag of parameters

address feedback

Oh actually, it sounds like you can just try this:

Does D6632 need to be updated so that getEmojiKeyboardPosition no longer looks at emojiKeyboard.getBoundingClientRect()?

In D6865#205681, @ashoat wrote:

Hey @rohan, you seem to have partially landed your stack. Just wanted to get some clarification – what is the current state of master after your partial land? I want to make sure we aren't in a bad state where we are blocked from deploys. (If so, we should revert)

Hey @rohan, you seem to have partially landed your stack. Just wanted to get some clarification – what is the current state of master after your partial land? I want to make sure we aren't in a bad state where we are blocked from deploys. (If so, we should revert)

1. The rename would've been best in a separate diff
2. Does D6632 need to be updated so that getEmojiKeyboardPosition no longer looks at emojiKeyboard.getBoundingClientRect()?
3. It's not clear to me which change is causing the issue here. I think you should investigate:
   • If getting rid of the useEffect is what caused the issue, then you could potentially bring back the useEffect. You would be able to address my "coupling" concern, but not my "set state in effect" concern. Still, that's better than nothing.
   • It's possible that immediately calling getEmojiKeyboardPosition from the ref function is causing the problem, and you could potentially undo that by moving back to storing the node itself as state, and computing getEmojiKeyboardPosition in a useMemo that takes the node as input

I think it would've been good to separate this into two diffs: one that moves the code around, and the other than changes things (eg. the interceptor that you added). More details here

mostly looks good.

It looks like this is handled by D6780 now, and @marcin confirmed that it does not break XCode tests (which I assume includes CryptoTests?)

I attempted to address the feedback above, but still running into one issue where the node passed through the ref still has a height and width of zero. (I saw this by logging node.getBoundingClientRect() in emojiKeyboardRef

address feedback

could we just do exactly what we do for RegisterUser today with an additional check that the accessToken is valid? i understand wanting to make the code DRY and decoupling the parts a bit, but I'd rather we backlog that work and just get this out and working

Rerun CI

REtrigger CI

Rebase before landing

Rebase before landing

Extract platformDetails variable

Rebase before landing

Rebase before landing

Rebase before landing

Rebase before landing

Rebase before landing

Rebase before landing

Rebase before landing

Rebase before landing

Rebase before landing

Rebase before landing

I can confirm that XCode tests succeeded on physical iOS device.

Fix typo.
The types aren't readonly because either:

• they are class methods and can't be made readonly
• the NotificationEvents type isn't actually ever instantiated or exported, it's just a holder that maps event string name to the callback type

Add comment, tasks: ENG-3173, ENG-3174

Extract platformDetails variables.

Type the json from the web push API. The PushMessageData is taken from the official web api types so I think it's better to keep them in sync and only later type them as our own type.

Rebase