Page MenuHomePhorge
Feed All Stories

Feb 28 2023

michal updated the diff for D6817: [keyserver] Send web push notification.

Move WebNotification type to lib so we can use it to type the push message in the service worker.

Feb 28 2023, 5:13 PM
inka updated the diff for D6733: [web] Change the Apps tab to be a + button.

Address review

Feb 28 2023, 5:13 PM
michal updated the diff for D6833: [web] Allow users to enable push notifs.

Update import

Feb 28 2023, 4:55 PM
michal updated the diff for D6820: [web] Add notification permission modal.

Change to export default

Feb 28 2023, 4:52 PM
michal updated the diff for D6817: [keyserver] Send web push notification.

Fix types

Feb 28 2023, 3:51 PM
varun closed D6904: [identity] GetSessionInitializationInfo RPC.
Feb 28 2023, 3:23 PM
varun closed D6910: [identity] add session initialization info to RegisterUser and LoginUser RPCs.
Feb 28 2023, 3:23 PM
varun committed rCOMM72229cb20a14: [identity] add session initialization info to RegisterUser and LoginUser RPCs.
Feb 28 2023, 3:23 PM
varun committed rCOMMcb7ce2c434a0: [identity] GetSessionInitializationInfo RPC.
Feb 28 2023, 3:23 PM
varun closed D6899: [identity] db client method to get session initialization info.
Feb 28 2023, 3:23 PM
varun committed rCOMM24e4d190406e: [identity] db client method to get session initialization info.
Feb 28 2023, 3:23 PM
tomek closed D6862: [services][feature-flags] Connect http service with database.
Feb 28 2023, 2:26 PM
tomek closed D6861: [services][feature-flags] Introduce `features` endpoint.
Feb 28 2023, 2:26 PM
tomek committed rCOMM32a543909f8f: [services][feature-flags] Connect http service with database.
Feb 28 2023, 2:26 PM
tomek closed D6860: [services][feature-flags] Add hello world http server.
Feb 28 2023, 2:26 PM
tomek closed D6859: [services][feature-flags] Add configuration for http server.
Feb 28 2023, 2:26 PM
tomek committed rCOMM3af2a21095c5: [services][feature-flags] Introduce `features` endpoint.
Feb 28 2023, 2:26 PM
tomek committed rCOMMd00c6f858ba2: [services][feature-flags] Add hello world http server.
Feb 28 2023, 2:26 PM
tomek committed rCOMM584ead41422b: [services][feature-flags] Add configuration for http server.
Feb 28 2023, 2:26 PM
tomek closed D6857: [services][feature-flags] Query the db.
Feb 28 2023, 2:26 PM
tomek closed D6858: [services][feature-flags] Determine enabled features set.
Feb 28 2023, 2:26 PM
tomek committed rCOMMc2bb76aec775: [services][feature-flags] Determine enabled features set.
Feb 28 2023, 2:26 PM
tomek closed D6856: [services][feature-flags] Parse feature flags response from DynamoDB.
Feb 28 2023, 2:26 PM
tomek committed rCOMMbfc7bdb5917f: [services][feature-flags] Query the db.
Feb 28 2023, 2:26 PM
tomek closed D6855: [services][feature-flags] Introduce map and i32 parsing.
Feb 28 2023, 2:26 PM
tomek committed rCOMM3684fe489698: [services][feature-flags] Parse feature flags response from DynamoDB.
Feb 28 2023, 2:26 PM
tomek committed rCOMM96d9a7b0315c: [services][feature-flags] Introduce map and i32 parsing.
Feb 28 2023, 2:26 PM
tomek closed D6854: [services] Extract common database code to a separate lib.
Feb 28 2023, 2:26 PM
tomek closed D6853: [services][feature-flags] Describe feature flags table in terraform.
Feb 28 2023, 2:26 PM
tomek committed rCOMM56c4f5d86838: [services] Extract common database code to a separate lib.
Feb 28 2023, 2:26 PM
tomek committed rCOMM3038a207ff3c: [services][feature-flags] Describe feature flags table in terraform.
Feb 28 2023, 2:26 PM
tomek closed D6852: [services][feature-flags] Introduce constants for accessing DynamoDB table.
Feb 28 2023, 2:26 PM
tomek committed rCOMM5dfc5ca68576: [services][feature-flags] Introduce constants for accessing DynamoDB table.
Feb 28 2023, 2:26 PM
ashoat added inline comments to D6894: [desktop] Handle macos notifications.
Feb 28 2023, 2:12 PM
ashoat added a comment to D6172: [CommCoreModule] Remove `userID` argument from `initializeCryptoAccount(...)`.

We still need to do this, don't we?

Feb 28 2023, 2:09 PM
ashoat added a comment to D6904: [identity] GetSessionInitializationInfo RPC.

Yeah but it makes it much harder whenever we want to change it. Protobufs / gRPC don't handle versioning of schemas very well. @jon, do you have a good story on how we'll handle it if we need to add a new entry?

Feb 28 2023, 2:08 PM
ashoat added a comment to D6908: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`.

Missed this previously

Feb 28 2023, 2:06 PM
kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Fixing wrong rebasing

Feb 28 2023, 11:25 AM
kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Another try to fix rebasing

Feb 28 2023, 11:23 AM
kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Rebase

Feb 28 2023, 11:22 AM
tomek accepted D6894: [desktop] Handle macos notifications.
Feb 28 2023, 11:21 AM
kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Rebase

Feb 28 2023, 11:17 AM
tomek accepted D6832: [web] Handle notifications in service worker.
Feb 28 2023, 11:04 AM
kamil accepted D6891: [desktop/web] Expose callbacks needed for desktop notifications.
Feb 28 2023, 10:45 AM
jon added a comment to D6910: [identity] add session initialization info to RegisterUser and LoginUser RPCs.

the rust is pretty boilerplate, but I'll defer to someone else about intent

Feb 28 2023, 10:18 AM
bartek accepted D6910: [identity] add session initialization info to RegisterUser and LoginUser RPCs.
Feb 28 2023, 8:27 AM
bartek accepted D6899: [identity] db client method to get session initialization info.
Feb 28 2023, 8:08 AM
atul abandoned D6405: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`.
Feb 28 2023, 7:13 AM
atul abandoned D6172: [CommCoreModule] Remove `userID` argument from `initializeCryptoAccount(...)`.
Feb 28 2023, 7:12 AM
varun updated the diff for D6910: [identity] add session initialization info to RegisterUser and LoginUser RPCs.

clean up imports

Feb 28 2023, 5:36 AM
jon added inline comments to D6904: [identity] GetSessionInitializationInfo RPC.
Feb 28 2023, 4:36 AM
jon accepted D6899: [identity] db client method to get session initialization info.

Looks okay to me, I'm assuming this is part of https://linear.app/comm/issue/ENG-2759

Feb 28 2023, 4:13 AM
varun requested review of D6910: [identity] add session initialization info to RegisterUser and LoginUser RPCs.
Feb 28 2023, 4:00 AM
atul closed D6911: [keyserver] Check `primaryIdentityPublicKeys.ed25519` against SIWE statement `primaryIdentityPublicKey`.
Feb 28 2023, 3:52 AM
atul committed rCOMMadcf374c60af: [keyserver] Check `primaryIdentityPublicKeys.ed25519` against SIWE statement….
Feb 28 2023, 3:52 AM
atul updated the diff for D6911: [keyserver] Check `primaryIdentityPublicKeys.ed25519` against SIWE statement `primaryIdentityPublicKey`.

rebase + land

Feb 28 2023, 3:51 AM
atul closed D6909: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`.
Feb 28 2023, 3:50 AM
atul committed rCOMMe24fd69b5b83: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`.
Feb 28 2023, 3:50 AM
atul updated the diff for D6909: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`.

rebase + land

Feb 28 2023, 3:49 AM
atul closed D6908: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`.
Feb 28 2023, 3:47 AM
atul committed rCOMMde9ea3310c90: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`.
Feb 28 2023, 3:47 AM
atul updated the diff for D6908: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`.

rebase + land

Feb 28 2023, 3:46 AM
ashoat added a comment to D6909: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`.

Never mind that's D6911

Feb 28 2023, 3:43 AM
ashoat accepted D6911: [keyserver] Check `primaryIdentityPublicKeys.ed25519` against SIWE statement `primaryIdentityPublicKey`.
Feb 28 2023, 3:43 AM
ashoat accepted D6909: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`.
Feb 28 2023, 3:43 AM
atul published D6911: [keyserver] Check `primaryIdentityPublicKeys.ed25519` against SIWE statement `primaryIdentityPublicKey` for review.
Feb 28 2023, 3:34 AM
atul published D6909: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth` for review.
Feb 28 2023, 3:14 AM
ashoat added inline comments to D6904: [identity] GetSessionInitializationInfo RPC.
Feb 28 2023, 3:10 AM
ashoat accepted D6904: [identity] GetSessionInitializationInfo RPC.
Feb 28 2023, 3:10 AM
ashoat accepted D6908: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`.
Feb 28 2023, 3:09 AM
varun updated the diff for D6904: [identity] GetSessionInitializationInfo RPC.

address feedback

Feb 28 2023, 2:14 AM
atul attached a referenced file: F404710: 52524c.png.
Feb 28 2023, 1:49 AM
atul published D6908: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login` for review.
Feb 28 2023, 1:49 AM
Harbormaster failed remote builds in B16970: Diff 23205 for D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table!
Feb 28 2023, 1:37 AM
atul closed D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table.
Feb 28 2023, 1:29 AM
atul committed rCOMMb3a783e613e6: [keyserver] Replace `public_key` column with `signed_identity_keys` in….
Feb 28 2023, 1:29 AM
atul updated the diff for D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table.

rebase + land

Feb 28 2023, 1:28 AM
atul closed D6906: [keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth` endpoints.
Feb 28 2023, 12:51 AM
atul committed rCOMMca5a871c35cd: [keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth`….
Feb 28 2023, 12:51 AM
atul updated the diff for D6906: [keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth` endpoints.

rebase + land

Feb 28 2023, 12:51 AM
atul added a comment to D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table.

So is the format basically { +payload: string, +signature: string }, where payload is the previously agreed upon JSON format?

Feb 28 2023, 12:36 AM
ashoat accepted D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table.

So is the format basically { +payload: string, +signature: string }, where payload is the previously agreed upon JSON format?

Feb 28 2023, 12:20 AM
ashoat accepted D6906: [keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth` endpoints.
Feb 28 2023, 12:18 AM
ashoat requested changes to D6904: [identity] GetSessionInitializationInfo RPC.
Feb 28 2023, 12:16 AM
Harbormaster failed remote builds in B16968: Diff 23202 for D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table!
Feb 28 2023, 12:16 AM
atul added inline comments to D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table.
Feb 28 2023, 12:09 AM
atul published D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table for review.
Feb 28 2023, 12:08 AM

Feb 27 2023

ashoat closed D6874: [lib] Make CreateSidebar notifs say when the OP tags the notif recipient.
Feb 27 2023, 11:56 PM
ashoat committed rCOMMb965736d93dd: [lib] Make CreateSidebar notifs say when the OP tags the notif recipient.
Feb 27 2023, 11:56 PM
ashoat closed D6873: [keyserver][lib] Pass notifTargetUserInfo to notificationTexts.
Feb 27 2023, 11:56 PM
ashoat closed D6872: [keyserver] Update notif prepare functions to take bag of params.
Feb 27 2023, 11:56 PM
ashoat committed rCOMMb78c6f05fcb3: [keyserver][lib] Pass notifTargetUserInfo to notificationTexts.
Feb 27 2023, 11:56 PM
ashoat closed D6871: [keyserver] Make sure we fetch username of all notif recipients.
Feb 27 2023, 11:56 PM
ashoat committed rCOMM9a53f51d3c24: [keyserver] Update notif prepare functions to take bag of params.
Feb 27 2023, 11:56 PM
ashoat committed rCOMMfea1dddf0ca5: [keyserver] Make sure we fetch username of all notif recipients.
Feb 27 2023, 11:56 PM
ashoat closed D6869: [lib] Collapse CreateSidebar and SidebarSource notifs together.
Feb 27 2023, 11:56 PM
ashoat closed D6870: [lib] Add invariant to SidebarSource notificationTexts.
Feb 27 2023, 11:56 PM
ashoat committed rCOMM26af81a8b67b: [lib] Add invariant to SidebarSource notificationTexts.
Feb 27 2023, 11:56 PM
ashoat committed rCOMM73d7ff10b795: [lib] Collapse CreateSidebar and SidebarSource notifs together.
Feb 27 2023, 11:56 PM
ashoat closed D6867: [keyserver] Check SIDEBAR_SOURCE's source message for @-mention notif override.
Feb 27 2023, 11:56 PM