Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Yesterday

will requested review of D13985: [keyserver/lib] Change frame image from hello world to channel image.

Wed, Nov 20, 9:03 PM

ashoat updated the diff for D13984: [lib] Fix incorrect timestamps for sidebars.

Changes in initial version broke useSearchSidebars comparison algo. Moved the sorting to getSidebarItems instead, which isn't used in useSearchSidebars and is only used in chat-selectors.js

Wed, Nov 20, 7:15 PM

will accepted D13984: [lib] Fix incorrect timestamps for sidebars.

Wed, Nov 20, 3:36 PM

will accepted D13983: [lib] Don't query Neynar for Farcaster channel avatars if unused.

Wed, Nov 20, 2:32 PM

will accepted D13982: [lib][native][web] Introduce FarcasterChannelPrefetchHandler.

Wed, Nov 20, 2:29 PM

will accepted D13981: [lib] Query for channel info in bulk whenever possible.

Wed, Nov 20, 2:28 PM

will accepted D13980: [lib] Introduce NeynarClient.fetchFarcasterChannelsByIDs.

Wed, Nov 20, 2:26 PM

will accepted D13979: [lib] Use channel instead of channel/search Neynar endpoint.

Wed, Nov 20, 2:24 PM

will accepted D13978: [lib] Fix bug in getCachedFarcasterChannelEntryForChannelID.

Wed, Nov 20, 2:22 PM

will accepted D13977: [lib] Wait to finish all followed channels queries before querying for a specific one.

Wed, Nov 20, 2:21 PM

will accepted D13976: [lib][keyserver][native][web] Introduce FCCache.getFollowedFarcasterChannelsForFID.

Wed, Nov 20, 1:19 PM

ashoat published D13984: [lib] Fix incorrect timestamps for sidebars for review.

Wed, Nov 20, 9:08 AM

bartek accepted D13937: [native_rust_library] update creating backup to return `backupID`.

Wed, Nov 20, 8:51 AM

bartek accepted D13936: [CommCoreModule] cleanup methods for creating backup.

Wed, Nov 20, 8:46 AM

will updated the diff for D13947: [keyserver] frog hello world example.

feedback

Wed, Nov 20, 8:19 AM

ashoat updated the diff for D13983: [lib] Don't query Neynar for Farcaster channel avatars if unused.

Fix rebase mistake

Wed, Nov 20, 8:05 AM

bartek accepted D13935: [native] implement creating User Keys backup.

Wed, Nov 20, 7:47 AM

bartek accepted D13934: [CommCoreModule] implement creating User Keys backup.

I implemented 1, which is not the best in terms of transferring data but it's the cleanest one - but I am open to updating. Note, that this API won't be used a lot.

Wed, Nov 20, 7:46 AM

ashoat published D13983: [lib] Don't query Neynar for Farcaster channel avatars if unused for review.

Wed, Nov 20, 7:16 AM

ashoat published D13982: [lib][native][web] Introduce FarcasterChannelPrefetchHandler for review.

Wed, Nov 20, 7:15 AM

ashoat published D13981: [lib] Query for channel info in bulk whenever possible for review.

Wed, Nov 20, 7:15 AM

ashoat published D13980: [lib] Introduce NeynarClient.fetchFarcasterChannelsByIDs for review.

Wed, Nov 20, 7:13 AM

ashoat published D13979: [lib] Use channel instead of channel/search Neynar endpoint for review.

Wed, Nov 20, 7:11 AM

ashoat published D13978: [lib] Fix bug in getCachedFarcasterChannelEntryForChannelID for review.

Wed, Nov 20, 7:11 AM

ashoat published D13977: [lib] Wait to finish all followed channels queries before querying for a specific one for review.

Wed, Nov 20, 7:10 AM

ashoat requested review of D13976: [lib][keyserver][native][web] Introduce FCCache.getFollowedFarcasterChannelsForFID.

Wed, Nov 20, 7:04 AM

varun accepted D13975: [keyserver][native][web] Use FCCache instead of calling fetchFarcasterChannelByID directly.

Wed, Nov 20, 6:59 AM

varun accepted D13974: [lib] Get rid of fetchFollowedFarcasterChannelsWithFilter.

Wed, Nov 20, 6:57 AM

ashoat requested review of D13975: [keyserver][native][web] Use FCCache instead of calling fetchFarcasterChannelByID directly.

Wed, Nov 20, 6:57 AM

ashoat requested review of D13974: [lib] Get rid of fetchFollowedFarcasterChannelsWithFilter.

Wed, Nov 20, 6:56 AM

bartek accepted D13963: [lib] create hook to run Device List Update Protocol.

Nice work on the stack 👍

Wed, Nov 20, 6:44 AM

bartek accepted D13968: [native] avoid showing SIWE backup message screen for non-primary devices.

Wed, Nov 20, 6:43 AM

bartek accepted D13967: [lib] ignore `DEVICE_LIST_UPDATE_SUCCESS` when auth connection is created.

Nice

Wed, Nov 20, 6:42 AM

bartek accepted D13966: [native][lib] remove `requestBackupKeys` from `SECONDARY_DEVICE_REGISTRATION_SUCCESS`.

Wed, Nov 20, 6:41 AM

bartek accepted D13965: [native][lib] merge `BackupDataKeyMessage` with `DeviceListUpdateSuccess`.

Wed, Nov 20, 6:40 AM

bartek accepted D13964: [lib] temporary remove code performing backup restore.

Wed, Nov 20, 6:39 AM

varun accepted D13973: [reports] Upgrade Postmark crate to fix TLS.

Wed, Nov 20, 6:36 AM

bartek published D13973: [reports] Upgrade Postmark crate to fix TLS for review.

Wed, Nov 20, 6:12 AM

will accepted D13970: [Tunnelbroker] add missing error logs for notifs.

Wed, Nov 20, 5:49 AM

varun closed D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.

Wed, Nov 20, 5:20 AM

varun committed rCOMM183ac09a25b3: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames (authored by varun).

[keyserver] return threadInfo in fetchAllCommunityInfosWithNames

Wed, Nov 20, 5:20 AM

varun closed D13852: [keyserver] new fetchPrivilegedThreadInfos function.

Wed, Nov 20, 5:20 AM

varun committed rCOMM1490b842faf6: [keyserver] new fetchPrivilegedThreadInfos function (authored by varun).

[keyserver] new fetchPrivilegedThreadInfos function

Wed, Nov 20, 5:20 AM

ashoat added a comment to D13939: [lib] Consider thread infos in useUsersSupportThickThreads().

Yes, exactly!

Wed, Nov 20, 4:24 AM

ashoat accepted D13963: [lib] create hook to run Device List Update Protocol.

Wed, Nov 20, 4:23 AM

ashoat accepted D13972: [lib] standarize broadcasting device list update when removing device.

Wed, Nov 20, 4:23 AM

ashoat added inline comments to D13972: [lib] standarize broadcasting device list update when removing device.

Wed, Nov 20, 4:23 AM

ashoat accepted D13971: [keyserver] implement invite link button to frog hono route.

Wed, Nov 20, 4:20 AM

ashoat added inline comments to D13947: [keyserver] frog hello world example.

Wed, Nov 20, 4:17 AM

ashoat accepted D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.

Wed, Nov 20, 4:15 AM

ashoat accepted D13852: [keyserver] new fetchPrivilegedThreadInfos function.

Wed, Nov 20, 4:14 AM

angelika added a comment to D13939: [lib] Consider thread infos in useUsersSupportThickThreads().

@ashoat Do I understand correctly that the threads check is not needed and I just need to check for existence of device list instead of using userHasDeviceList?

Wed, Nov 20, 4:06 AM

kamil added a comment to D13970: [Tunnelbroker] add missing error logs for notifs.

In D13970#389656, @will wrote:

Testing that adding WEB_PUSH_ERROR and APNS_ERROR error types to an error log will trigger an alarm + email notif has already been tested. I don't think this needs further testing.

The best way of testing this would be to ensure that failing to sending APNs error or Web Push notif logs the error. Cloudwatch alarms will take care of the rest

Doing this locally and ensuring you can find the error logs should be sufficient imo

Wed, Nov 20, 3:32 AM

kamil updated the test plan for D13970: [Tunnelbroker] add missing error logs for notifs.

Wed, Nov 20, 3:31 AM

kamil published D13972: [lib] standarize broadcasting device list update when removing device for review.

Wed, Nov 20, 3:10 AM

kamil added inline comments to D13963: [lib] create hook to run Device List Update Protocol.

Wed, Nov 20, 3:09 AM

Tue, Nov 19

will requested review of D13971: [keyserver] implement invite link button to frog hono route.

Tue, Nov 19, 10:08 PM

varun added inline comments to D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.

Tue, Nov 19, 9:27 PM

varun added inline comments to D13852: [keyserver] new fetchPrivilegedThreadInfos function.

Tue, Nov 19, 9:25 PM

varun updated the diff for D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.

address feedback

Tue, Nov 19, 9:24 PM

varun updated the diff for D13852: [keyserver] new fetchPrivilegedThreadInfos function.

address feedback

Tue, Nov 19, 9:24 PM

will updated the diff for D13947: [keyserver] frog hello world example.

feedback and changed button label from "Invite Link" to "Join chat"

Tue, Nov 19, 9:11 PM

will accepted D13969: [Tunnelbroker] deprecate errors about invalidating WNS device token.

Tue, Nov 19, 1:30 PM

will added a comment to D13970: [Tunnelbroker] add missing error logs for notifs.

Testing that adding WEB_PUSH_ERROR and APNS_ERROR error types to an error log will trigger an alarm + email notif has already been tested. I don't think this needs further testing.

Tue, Nov 19, 1:26 PM

ashoat committed rCOMM64e3d1dad642: [terraform] Bump keyserver image to 1.0.144 (authored by ashoat).

[terraform] Bump keyserver image to 1.0.144

Tue, Nov 19, 12:28 PM

ashoat added a reverting change for rCOMMcd4943fc4074: [native] Temporary changes for staff release: rCOMM579ec909f09a: Revert "[native] Temporary changes for staff release".

Tue, Nov 19, 8:40 AM

ashoat committed rCOMM579ec909f09a: Revert "[native] Temporary changes for staff release" (authored by ashoat).

Revert "[native] Temporary changes for staff release"

Tue, Nov 19, 8:40 AM

ashoat committed rCOMMe371bd8ec52c: [native] codeVersion -> 444 (authored by ashoat).

[native] codeVersion -> 444

Tue, Nov 19, 8:39 AM

ashoat committed rCOMMcd4943fc4074: [native] Temporary changes for staff release (authored by ashoat).

[native] Temporary changes for staff release

Tue, Nov 19, 8:39 AM

ashoat committed rCOMM3c0553e3f578: [native] codeVersion -> 443 (authored by ashoat).

[native] codeVersion -> 443

Tue, Nov 19, 8:39 AM

ashoat committed rCOMM77e5e2667861: [web][keyserver] codeVersion -> 144 (authored by ashoat).

[web][keyserver] codeVersion -> 144

Tue, Nov 19, 8:39 AM

ashoat added inline comments to D13963: [lib] create hook to run Device List Update Protocol.

Tue, Nov 19, 8:30 AM

ashoat added inline comments to D13963: [lib] create hook to run Device List Update Protocol.

Tue, Nov 19, 8:28 AM

bartek accepted D13962: [terraform] upgrade backup prod to 0.5.1.

Tue, Nov 19, 6:47 AM

kamil published D13970: [Tunnelbroker] add missing error logs for notifs for review.

Tue, Nov 19, 6:47 AM

kamil published D13969: [Tunnelbroker] deprecate errors about invalidating WNS device token for review.

Tue, Nov 19, 6:46 AM

kamil added inline comments to D13963: [lib] create hook to run Device List Update Protocol.

Tue, Nov 19, 6:44 AM

varun accepted D13962: [terraform] upgrade backup prod to 0.5.1.

Tue, Nov 19, 6:22 AM

bartek accepted D13933: [CommCoreModule] remove capturing logs.

Tue, Nov 19, 5:45 AM

bartek accepted D13932: [backup-client][native_rust_library] refactor uploading files to not ignore User Keys.

Tue, Nov 19, 5:45 AM

ashoat added inline comments to D13963: [lib] create hook to run Device List Update Protocol.

Tue, Nov 19, 5:44 AM

bartek accepted D13931: [backup-client][native_rust_library] implement creating User Keys backup.

Tue, Nov 19, 5:41 AM

bartek accepted D13930: [backup-client][native_rust_library] update backup client to run cleanup on any failure.

Tue, Nov 19, 5:41 AM

bartek accepted D13929: [backup-client][native_rust_library] update file cleanup to ignore missing files.

Tue, Nov 19, 5:38 AM

bartek accepted D13928: [backup-client] avoid adding `attachments` when uploading User Keys.

Tue, Nov 19, 5:37 AM

angelika closed D13952: [keyserver] Log on keyserver when session recovery is attempted.

Tue, Nov 19, 5:31 AM

angelika committed rCOMM601de810f74f: [keyserver] Log on keyserver when session recovery is attempted (authored by angelika).

[keyserver] Log on keyserver when session recovery is attempted

Tue, Nov 19, 5:31 AM

angelika closed D13951: [keyserver] Log on keyserver when INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE is sent to the client.

Tue, Nov 19, 5:30 AM

angelika committed rCOMM287b768e8ff4: [keyserver] Log on keyserver when INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE is… (authored by angelika).

[keyserver] Log on keyserver when INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE is…

Tue, Nov 19, 5:30 AM

Harbormaster failed remote builds in B32711: Diff 45877 for D13951: [keyserver] Log on keyserver when INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE is sent to the client!

Tue, Nov 19, 5:28 AM

kamil published D13968: [native] avoid showing SIWE backup message screen for non-primary devices for review.

Tue, Nov 19, 4:28 AM

kamil published D13967: [lib] ignore `DEVICE_LIST_UPDATE_SUCCESS` when auth connection is created for review.

Tue, Nov 19, 4:27 AM

kamil updated the test plan for D13966: [native][lib] remove `requestBackupKeys` from `SECONDARY_DEVICE_REGISTRATION_SUCCESS`.

Tue, Nov 19, 4:27 AM

kamil updated the test plan for D13965: [native][lib] merge `BackupDataKeyMessage` with `DeviceListUpdateSuccess`.

Tue, Nov 19, 4:26 AM

kamil published D13966: [native][lib] remove `requestBackupKeys` from `SECONDARY_DEVICE_REGISTRATION_SUCCESS` for review.

Tue, Nov 19, 4:12 AM

kamil published D13965: [native][lib] merge `BackupDataKeyMessage` with `DeviceListUpdateSuccess` for review.

Tue, Nov 19, 4:12 AM

kamil published D13964: [lib] temporary remove code performing backup restore for review.

Tue, Nov 19, 4:12 AM

kamil published D13963: [lib] create hook to run Device List Update Protocol for review.

Tue, Nov 19, 4:12 AM

ashoat requested changes to D13946: [native] Update the QR login screen to mention the primary device.

Passing to @tomek's queue

Tue, Nov 19, 3:58 AM

angelika closed D13961: [lib] Add staff-only alert when client attempts keyserver session recovery.

Tue, Nov 19, 3:32 AM