Page MenuHomePhabricator
Differential D7124

[web-db] add unit tests for draft store queries
ClosedPublic
Actions

Authored by kamil on Mar 21 2023, 8:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 1:28 AM
Unknown Object (File)
Mon, Nov 4, 11:12 PM
Unknown Object (File)
Mon, Nov 4, 11:12 PM
Unknown Object (File)
Mon, Nov 4, 11:12 PM
Unknown Object (File)
Mon, Nov 4, 11:11 PM
Unknown Object (File)
Mon, Nov 4, 11:11 PM
Unknown Object (File)
Sat, Nov 2, 12:30 AM
Unknown Object (File)
Sat, Nov 2, 12:30 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
michal
tomek
marcin
ashoat
Commits
rCOMMceff50b57731: [web-db] add unit tests for draft store queries
Summary

Logically should match the native equivalent.

Depends on D7123

Test Plan

run tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Mar 21 2023, 8:24 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 21 2023, 8:24 AM
kamil mentioned this in D7122: [web-db] implement Draft Store Operations.Mar 21 2023, 8:24 AM
kamil mentioned this in D7123: [web-db] implement function get all drafts from SQLite.
Harbormaster completed remote builds in B17474: Diff 23933.Mar 21 2023, 8:39 AM
kamil updated this revision to Diff 24023.Mar 23 2023, 6:06 AM

rebase

kamil added a child revision: D7153: [web-db] process Draft Store Operations on worker.Mar 23 2023, 6:13 AM
kamil published this revision for review.Mar 23 2023, 6:19 AM
Harbormaster completed remote builds in B17548: Diff 24023.Mar 23 2023, 6:21 AM
ashoat accepted this revision.Mar 23 2023, 12:49 PM

Did not review this closely

web/database/queries/draft-queries.test.js
24–25 ↗(On Diff #24023)

Please try to consistently use 2-space indents

This revision is now accepted and ready to land.Mar 23 2023, 12:49 PM
atul added a comment.Mar 23 2023, 12:51 PM

(Really great to see we're adding DB tests right off the bat)

kamil updated this revision to Diff 24359.Mar 30 2023, 12:20 AM

fix query formatting

Harbormaster completed remote builds in B17804: Diff 24359.Mar 30 2023, 12:35 AM
Closed by commit rCOMMceff50b57731: [web-db] add unit tests for draft store queries (authored by kamil). · Explain WhyMar 30 2023, 1:24 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMM640ebb7a374d: [web-db] implement Draft Store Operations.
kamil mentioned this in rCOMM85b420a7217c: [web-db] implement function get all drafts from SQLite.
kamil added a commit: rCOMMceff50b57731: [web-db] add unit tests for draft store queries.

Revision Contents
Changeset List

PathSize
web/
database/
queries/
114 lines

Diff 24365

View Options

web/database/queries/draft-queries.test.js

Loading...