Page MenuHomePhabricator

[lib] add local is field to reports
ClosedPublic

Authored by kamil on May 22 2023, 6:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 7, 2:40 PM
Unknown Object (File)
Jan 22 2024, 1:31 AM
Unknown Object (File)
Dec 18 2023, 2:16 PM
Unknown Object (File)
Dec 16 2023, 2:17 AM
Unknown Object (File)
Dec 15 2023, 2:51 PM
Unknown Object (File)
Dec 14 2023, 11:38 AM
Unknown Object (File)
Dec 1 2023, 12:32 AM
Unknown Object (File)
Nov 12 2023, 7:23 AM
Subscribers

Details

Summary

Those ids will help with moving reports to SQLite - we will not have to compare entire objects, only ids.

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.May 23 2023, 1:35 AM
tomek added inline comments.
lib/types/report-types.js
109 ↗(On Diff #26776)

Why this is optional?

This revision is now accepted and ready to land.May 23 2023, 3:00 AM
lib/types/report-types.js
109 ↗(On Diff #26776)

To make id logically correct, adding this as optional, in next diffs making sure that this field will not have to be optional, and then updating this in D7916.

This revision was automatically updated to reflect the committed changes.