Details

Reviewers

tomek
michal

Commits

rCOMMc26472a54487: [lib] make report id mandatory

Summary

At this point id is added to existing reports, added on each creation and extracted before sending request to keyserver, so it's safe to make it mandatory as this will be needed to move reports to database.

Depends on D7913

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 22 2023, 7:10 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 22 2023, 7:10 AM

Harbormaster completed remote builds in B19604: Diff 26793.May 22 2023, 7:28 AM

kamil added a child revision: D7918: [CommCoreModule] add table and methods for report store.May 22 2023, 9:23 AM

kamil added a child revision: D7919: [lib] add tests for report reducer.May 22 2023, 10:14 AM

kamil published this revision for review.May 23 2023, 1:41 AM

tomek accepted this revision.May 23 2023, 3:16 AM

This revision is now accepted and ready to land.May 23 2023, 3:16 AM

kamil mentioned this in D7909: [lib] add local is field to reports.May 29 2023, 1:46 AM

rebase

Harbormaster completed remote builds in B19810: Diff 27124.May 29 2023, 3:00 AM

Closed by commit rCOMMc26472a54487: [lib] make report id mandatory (authored by kamil). · Explain WhyMay 29 2023, 3:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMc26472a54487: [lib] make report id mandatory.

We didn't update the validators to match this
The types should've been optional for the "server" versions, since the keyserver still has to support older clients

The new version of Flow is catching these type errors and forcing me to address them.

ashoat mentioned this in D9863: [Flow202][keyserver][skip-ci] [14/x] Address type errors with report-responders.js.Tue, Nov 14, 6:01 AM

kamil mentioned this in D9893: [Flow] improve report related types.Wed, Nov 15, 4:07 AM

kamil mentioned this in rCOMMb9ee04633890: [Flow] improve report related types.Wed, Nov 15, 5:21 AM