Page MenuHomePhabricator

[lib] make report id mandatory
ClosedPublic

Authored by kamil on May 22 2023, 7:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 1:21 AM
Unknown Object (File)
Wed, Jun 12, 8:28 AM
Unknown Object (File)
Tue, Jun 11, 11:08 AM
Unknown Object (File)
Sun, Jun 9, 2:15 AM
Unknown Object (File)
Thu, Jun 6, 1:03 PM
Unknown Object (File)
Tue, Jun 4, 2:51 PM
Unknown Object (File)
Tue, Jun 4, 2:21 AM
Unknown Object (File)
Mon, Jun 3, 11:37 PM
Subscribers

Details

Summary

At this point id is added to existing reports, added on each creation and extracted before sending request to keyserver, so it's safe to make it mandatory as this will be needed to move reports to database.

Depends on D7913

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.May 23 2023, 1:41 AM
This revision is now accepted and ready to land.May 23 2023, 3:16 AM
This revision was automatically updated to reflect the committed changes.
  1. We didn't update the validators to match this
  2. The types should've been optional for the "server" versions, since the keyserver still has to support older clients

The new version of Flow is catching these type errors and forcing me to address them.